This is the mail archive of the binutils@sourceware.cygnus.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: binutils 2.9.5.0.46: IEEE support is broken in binutils because of `slashpatch'


> From: "Alexander Aganichev" <AAganichev@hypercom.com>
> Date: Tue, 20 Jun 2000 10:03:05 +0100
> 
> I've made the changes you suggested and attach the patch to this message.
> (See attached file: dosslash.fix.diff)
[snip]
> -	filename = file + 1;
> +	filename = file + 2;
> -	    temp = program_name + 1;
> +	    temp = program_name + 2;

I think the above two changes in ar.c (and a similar change in
bucomm.c) are wrong: this code is handling the case of "d:foo", where
there's no slash or backslash in the file name, but there is a drive
letter.  In this case, the basename begins right after the colon.
However, the code later on increments `filename' and `temp', like
this:

  if (filename != (char *) NULL)
    filename++;
  else
    filename = file;

Therefore, we should set `filename' to point to the colon, not to the
character after it.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]