This is the mail archive of the binutils@sourceware.cygnus.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [patch] binary file endianness


Hi Velco,

: This patch fixes ppc_elf_merge_private_data so it
: doesn't give an error if one of the files is a non-ELF one,
: e.g. binary.
: mcore, mips and sh have the same problem.

: From: Geoff Keating <geoffk@cygnus.com>
:
: >    /* Check if we have the same endianess */
: >    if (ibfd->xvec->byteorder != obfd->xvec->byteorder
: >        && obfd->xvec->byteorder != BFD_ENDIAN_UNKNOWN)
: 
: Perhaps we need a test for ibfd->xvec->byteorder != BFD_ENDIAN_UNKNOWN.

I tend to agree with Geoff here.  Could you try adding the test of
ibfd and see if that also fixes the problem you encountered ?

Cheers
	Nick

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]