RE: bfd/peigen.c problems and fix

[Donn Terry <donnte at microsoft dot com>]

Try kernel32.dll (for an import table that's not in .idata)
and ntdll.dll or kernel32.dll (for import/export tables that are
not in .idata and .edata).  This is true both on win2K and
NT4 (can't say whether there are similar examples on win98).

I'm not arguing that there currently is a problem with
ImageBase (since not all the patches that needed to be
applied DID get applied, that happened; I'm still working
on getting that fixed, but it's far more than just at
technical problem).  However, the code that finds 
the import and export tables when they're not in .idata
and .edata is still applicable.  Please restore it
so that it can find them.  There will be patches forthcoming
that fix all this (and more), if I can ever get past
all the problems in my way.

Speaking only for myself.

Donn

> -----Original Message-----
> From: Szabolcs Szakacsits [mailto:szaka@F-Secure.com]
> Sent: Tuesday, May 09, 2000 9:01 AM
> To: Donn Terry
> Cc: 'Alan Modra'; binutils@sourceware.cygnus.com
> Subject: RE: bfd/peigen.c problems and fix
> 
> 
> 
> On Mon, 8 May 2000, Donn Terry wrote:
> 
> > I'm still not to the point of being able to dig thru all
> > of what's going on with this, but the patch made to peigen.c
> > (1.9) doesn't seem right to me.
> 
> Maybe it doesn't *seem* right to you but now it *works* for 
> me for every
> dll's and exe's that I tested.
>  
> > Primarily, it removes a lot of code that doesn't have anything
> > to do with the problem of Image Base.  In fact it removes code
> > that allows it to dump DLLs that it otherwise could not dump.
> 
> The above statment correctly, 
> In fact it removes code that *disallows* it to dump DLLs that 
> it otherwise
> *could* dump.
> 
> Before it was pretty annoying to watch the "There is an 
> import table, but
> the section containing it could not be found" messages, what 
> I remember
> you added but I don't have the picture what the reason was to 
> break PEI so
> badly.
> 
> > The change to insert or delete ImageBase (until the base problem
> > gets fixed) is reasonable, but the other stuff should be left
> > in place.
> 
> Yes, if you want a non-functioning objdump in the future as 
> well. Please
> send me testcases that don't work since I can't found [sure I don't
> have sample from all of the PEI variants]. Thanks.
> 
> 	Szaka
>