This is the mail archive of the
binutils-cvs@sourceware.org
mailing list for the binutils project.
[binutils-gdb] Check error return from bfd_canonicalize_dynamic_reloc
- From: H.J.Lu <hjl at sourceware dot org>
- To: bfd-cvs at sourceware dot org
- Date: 18 Sep 2017 20:10:19 -0000
- Subject: [binutils-gdb] Check error return from bfd_canonicalize_dynamic_reloc
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=94670f6cf11fc29cc6db6814b38c4305d9bcac96
commit 94670f6cf11fc29cc6db6814b38c4305d9bcac96
Author: H.J. Lu <hjl.tools@gmail.com>
Date: Mon Sep 18 13:05:25 2017 -0700
Check error return from bfd_canonicalize_dynamic_reloc
Since bfd_canonicalize_dynamic_reloc returns -1 on error, check it in
_bfd_x86_elf_get_synthetic_symtab.
PR ld/22148
* elfxx-x86.c (_bfd_x86_elf_get_synthetic_symtab): Check error
return from bfd_canonicalize_dynamic_reloc.
Diff:
---
bfd/ChangeLog | 6 ++++++
bfd/elfxx-x86.c | 2 ++
2 files changed, 8 insertions(+)
diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 5f6b423..c607549 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,9 @@
+2017-09-18 H.J. Lu <hongjiu.lu@intel.com>
+
+ PR ld/22148
+ * elfxx-x86.c (_bfd_x86_elf_get_synthetic_symtab): Check error
+ return from bfd_canonicalize_dynamic_reloc.
+
2017-09-15 Alan Modra <amodra@gmail.com>
PR 22116
diff --git a/bfd/elfxx-x86.c b/bfd/elfxx-x86.c
index c41dbef..2145308 100644
--- a/bfd/elfxx-x86.c
+++ b/bfd/elfxx-x86.c
@@ -1807,6 +1807,8 @@ _bfd_x86_elf_get_synthetic_symtab (bfd *abfd,
dynrelcount = bfd_canonicalize_dynamic_reloc (abfd, dynrelbuf,
dynsyms);
+ if (dynrelcount < 0)
+ return -1;
/* Sort the relocs by address. */
qsort (dynrelbuf, dynrelcount, sizeof (arelent *),