This is the mail archive of the
binutils-cvs@sourceware.org
mailing list for the binutils project.
[binutils-gdb] change some variable's type to op_err
- From: Trevor Saunders <tbsaunde at sourceware dot org>
- To: bfd-cvs at sourceware dot org
- Date: 24 May 2016 12:37:49 -0000
- Subject: [binutils-gdb] change some variable's type to op_err
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=6610dc6daa661b7cd042bc6313a29859b87263d9
commit 6610dc6daa661b7cd042bc6313a29859b87263d9
Author: Trevor Saunders <tbsaunde+binutils@tbsaunde.org>
Date: Fri May 13 04:05:59 2016 -0400
change some variable's type to op_err
They only hold values from the op_err enum, so it should be clearer to give
them the enum type.
gas/ChangeLog:
2016-05-24 Trevor Saunders <tbsaunde+binutils@tbsaunde.org>
* config/tc-cr16.c (check_range): Make type of retval op_err.
* config/tc-crx.c: Likewise.
Diff:
---
gas/ChangeLog | 5 +++++
gas/config/tc-cr16.c | 2 +-
gas/config/tc-crx.c | 2 +-
3 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/gas/ChangeLog b/gas/ChangeLog
index 64e890b..41518df 100644
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,3 +1,8 @@
+2016-05-24 Trevor Saunders <tbsaunde+binutils@tbsaunde.org>
+
+ * config/tc-cr16.c (check_range): Make type of retval op_err.
+ * config/tc-crx.c: Likewise.
+
2016-05-23 Claudiu Zissulescu <claziss@synopsys.com>
* config/tc-arc.c (md_begin): Add XY registers.
diff --git a/gas/config/tc-cr16.c b/gas/config/tc-cr16.c
index b7fffa7..229f51a 100644
--- a/gas/config/tc-cr16.c
+++ b/gas/config/tc-cr16.c
@@ -1993,7 +1993,7 @@ static op_err
check_range (long *num, int bits, int unsigned flags, int update)
{
long min, max;
- int retval = OP_LEGAL;
+ op_err retval = OP_LEGAL;
long value = *num;
if (bits == 0 && value > 0) return OP_OUT_OF_RANGE;
diff --git a/gas/config/tc-crx.c b/gas/config/tc-crx.c
index 4b829c2..9a943d5 100644
--- a/gas/config/tc-crx.c
+++ b/gas/config/tc-crx.c
@@ -1325,7 +1325,7 @@ static op_err
check_range (long *num, int bits, int unsigned flags, int update)
{
uint32_t max;
- int retval = OP_LEGAL;
+ op_err retval = OP_LEGAL;
int bin;
uint32_t upper_64kb = 0xffff0000;
uint32_t value = *num;