Re: Improved linker-debugger interface

[Gary Benson <gbenson at redhat dot com>]

Jan Kratochvil wrote:
> On Wed, 25 May 2011 17:36:50 +0200, Gary Benson wrote:
> > --- a/sysdeps/generic/ldsodefs.h
> > +++ b/sysdeps/generic/ldsodefs.h
> [...]
> > +/* The dynamic linker calls this function after having changed any
> > +   shared object mappings.  */
> > +extern void _dl_debug_state_extended (Lmid_t ns, struct r_debug *r)
> > +     internal_function;
> > +
> [...]
> > --- a/elf/dl-debug.c
> > +++ b/elf/dl-debug.c
> > @@ -76,3 +76,19 @@ _dl_debug_state (void)
> >  {
> >  }
> >  rtld_hidden_def (_dl_debug_state)
> > +
> > +
> > +/* This function exists solely to contain SystemTap probes which the
> > +   debugger can set breakpoints on.  */
> 
> Here should be also `internal_function' otherwise on i686 it will:
> 
> dl-debug.c:84:1: error: conflicting types for '_dl_debug_state_extended'
> ../sysdeps/generic/ldsodefs.h:963:13: note: previous declaration of '_dl_debug_state_extended' was here
> 
> > +void
> > +_dl_debug_state_extended (Lmid_t ns, struct r_debug *r)
...

Thanks Jan.

Cheers,
Gary

-- 
http://gbenson.net/