This is the mail archive of the archer@sourceware.org mailing list for the Archer project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFC] Koenig lookup patch 3

From: Tom Tromey <tromey at redhat dot com>
To: Sami Wagiaalla <swagiaal at redhat dot com>
Cc: Project Archer <archer at sourceware dot org>
Date: Tue, 17 Nov 2009 13:49:48 -0700
Subject: Re: [RFC] Koenig lookup patch 3
References: <49BABABE.9080606@redhat.com> <m3d4clrs4z.fsf@fleche.redhat.com><49F87751.8050405@redhat.com> <m3iqkndmck.fsf@fleche.redhat.com><4A969900.6040100@redhat.com> <m3zl9lorki.fsf@fleche.redhat.com><4AD6340F.9070108@redhat.com> <4AD63BA4.4070309@redhat.com><m3tyy0tmcd.fsf@fleche.redhat.com> <4AEF2E3C.30601@redhat.com><m3my2vh4zj.fsf@fleche.redhat.com> <4B02C888.5000409@redhat.com>
Reply-to: Tom Tromey <tromey at redhat dot com>

>>>>> "Sami" == Sami Wagiaalla <swagiaal@redhat.com> writes:

Sami> +    if (sym == NULL && !lookup_minimal_symbol (tmp, NULL, NULL) && parse_language->la_language == language_cplus)

This wraps.

More importantly, order the conditions so that the slowest one comes last.

Otherwise it seems reasonable to me.

Tom

References:
- Re: [RFC] Koenig lookup patch 3
  - From: Sami Wagiaalla
- Re: [RFC] Koenig lookup patch 3
  - From: Sami Wagiaalla
- Re: [RFC] Koenig lookup patch 3
  - From: Tom Tromey
- Re: [RFC] Koenig lookup patch 3
  - From: Sami Wagiaalla
- Re: [RFC] Koenig lookup patch 3
  - From: Tom Tromey
- Re: [RFC] Koenig lookup patch 3
  - From: Sami Wagiaalla

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]