Re: [patch] Fix python/10805

[Phil Muldoon <pmuldoon at redhat dot com>]

On 10/30/2009 10:18 PM, Tom Tromey wrote:
> > > > > > "Phil" == Phil Muldoon<pmuldoon@redhat.com>  writes:
> > > > > >              
> Phil>  This patch fixes python/10805. When fields were being constructed, the
> Phil>  convert_fields function was not checking if the type was a class
> Phil>  before determining if it was a base class. Added a check to gate this
> Phil>  behaviour.
>
> Looks good, thanks.
>
> Phil>  Additionally, I started a testsuite for Python types. This suite only
> Phil>  tests for this regression, but it can be expanded later, in separate
> Phil>  efforts.
>    


Thanks. Committed: as dad6b53fe4a6df586dcd0a57e2151e7663191f18

> Awesome.
>
> The is_base_class thing isn't upstream.
> It would be good to submit all this sometime.
>    


I'll dig out the is_base_class author name and submit the patch and 
ChangeLog upstream, as well as this patchlet.

Cheers,

Phil