This is the mail archive of the archer@sourceware.org mailing list for the Archer project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Fix for heap corruption in python pretty printing.

From: Tom Tromey <tromey at redhat dot com>
To: "Paul Pluzhnikov" <ppluzhnikov at google dot com>
Cc: archer at sourceware dot org
Date: Wed, 22 Oct 2008 09:21:08 -0600
Subject: Re: [patch] Fix for heap corruption in python pretty printing.
References: <8ac60eac0810211500j28788718ic6c455989fc2d4d4@mail.gmail.com><m3bpxd7bbv.fsf@fleche.redhat.com><8ac60eac0810211943p2f032e81m4f2fe935fa20f716@mail.gmail.com>
Reply-to: Tom Tromey <tromey at redhat dot com>

Paul> Could this be because .owned_by_gdb is left uninitialized, doesn't
Paul> happen to be zero, and so value_free() never fires?

Yeah, could be.

Not initializing there caused other crashes.  They were pretty simple
to find with valgrind; that would be worth running against cvs head.

Paul> Should I just check in the fix without creating a test case for it?

Upstream would have to decide that.

Tom> I've just been checking in my changes without comment.  Would you
Tom> prefer that I email them here with explanations?  I'm happy to do that
Tom> if it would be useful to you.

Paul> Yes, it is sometimes hard to figure out what has changed and why.

No problem, I'll start doing that.

Tom

References:
- [patch] Fix for heap corruption in python pretty printing.
  - From: Paul Pluzhnikov
- Re: [patch] Fix for heap corruption in python pretty printing.
  - From: Tom Tromey
- Re: [patch] Fix for heap corruption in python pretty printing.
  - From: Paul Pluzhnikov

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]