From fc218865bfdc05c745038665c455745d88b7f469 Mon Sep 17 00:00:00 2001 From: Zdenek Kabelac Date: Mon, 25 Oct 2010 12:05:46 +0000 Subject: [PATCH] Ensure we always have origin defined Reported by clang as: Logic error Dereference of null pointer Make sure the code path could not use NULL origin because of some internal code error. --- tools/lvcreate.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/lvcreate.c b/tools/lvcreate.c index de5b59cfb..a9e3c2d8f 100644 --- a/tools/lvcreate.c +++ b/tools/lvcreate.c @@ -179,6 +179,10 @@ static int _update_extents_params(struct volume_group *vg, lp->origin); return 0; } + if (!origin) { + log_error(INTERNAL_ERROR "Couldn't find origin volume."); + return 0; + } lp->extents = lp->extents * origin->le_count / 100; break; case PERCENT_NONE: -- 2.43.5