From fb2f985dfe55d3bd0522850899181ca92802469d Mon Sep 17 00:00:00 2001 From: Zdenek Kabelac Date: Thu, 4 Aug 2011 12:13:50 +0000 Subject: [PATCH] Add test for fcntl error in singlenode client code. Static analyzer noticed this check could be handy. --- WHATS_NEW | 1 + daemons/clvmd/clvmd-singlenode.c | 5 ++++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/WHATS_NEW b/WHATS_NEW index 11499e711..7ce5620c9 100644 --- a/WHATS_NEW +++ b/WHATS_NEW @@ -1,5 +1,6 @@ Version 2.02.87 - =============================== + Add test for fcntl error in singlenode client code. Remove --force option from lvrename manpage. Add missing new line in lvrename help text. Add basic support for RAID 1/4/5/6 (i.e. create, remove, display) diff --git a/daemons/clvmd/clvmd-singlenode.c b/daemons/clvmd/clvmd-singlenode.c index 26c1f7ed5..3a46fb609 100644 --- a/daemons/clvmd/clvmd-singlenode.c +++ b/daemons/clvmd/clvmd-singlenode.c @@ -55,7 +55,10 @@ static int init_comms(void) goto error; } /* Set Close-on-exec */ - fcntl(listen_fd, F_SETFD, 1); + if (fcntl(listen_fd, F_SETFD, 1)) { + DEBUGLOG("Setting CLOEXEC on client fd faile: %s\n", strerror(errno)); + goto error; + } memset(&addr, 0, sizeof(addr)); memcpy(addr.sun_path, SINGLENODE_CLVMD_SOCKNAME, -- 2.43.5