From f6575ec824964ee2f830746e12b12a887c95e7f7 Mon Sep 17 00:00:00 2001 From: Zdenek Kabelac Date: Thu, 5 May 2016 23:12:30 +0200 Subject: [PATCH] cleanup: just switch error path Check for error case in if() like we normally do. Let code continue on success. --- lib/metadata/lv_manip.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/lib/metadata/lv_manip.c b/lib/metadata/lv_manip.c index 45dd1f52e..9bfef4544 100644 --- a/lib/metadata/lv_manip.c +++ b/lib/metadata/lv_manip.c @@ -7771,16 +7771,16 @@ struct logical_volume *lv_create_single(struct volume_group *vg, if (!(lv = _lv_create_an_lv(vg, lp, lp->pool_name))) return_NULL; - if (lv_is_cache(lv)) { - /* Here it's been converted via lvcreate */ - log_print_unless_silent("Logical volume %s is now cached.", - display_lvname(lv)); - return lv; + if (!lv_is_cache(lv)) { + log_error(INTERNAL_ERROR "Logical volume is not cache %s.", + display_lvname(lv)); + return NULL; } - log_error(INTERNAL_ERROR "Logical volume is not cache %s.", - display_lvname(lv)); - return NULL; + /* Convertion via lvcreate */ + log_print_unless_silent("Logical volume %s is now cached.", + display_lvname(lv)); + return lv; } else { log_error(INTERNAL_ERROR "Creation of pool for unsupported segment type %s.", lp->segtype->name); -- 2.43.5