From f3d8974dc92de4c67ecdf489ccb607f60dee00f8 Mon Sep 17 00:00:00 2001 From: Zdenek Kabelac Date: Fri, 17 Jun 2011 14:24:18 +0000 Subject: [PATCH] Add couple FIXMEs around suspicious code --- lib/activate/activate.c | 4 +++- lib/metadata/mirror.c | 1 + 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/activate/activate.c b/lib/activate/activate.c index 1e8998af3..bc7d62986 100644 --- a/lib/activate/activate.c +++ b/lib/activate/activate.c @@ -795,12 +795,14 @@ static int _lv_is_active(struct logical_volume *lv, goto out; } + /* FIXME: Is this fallback alright? */ if (activate_lv_excl(lv->vg->cmd, lv)) { if (!deactivate_lv(lv->vg->cmd, lv)) stack; + /* FIXME: locally & exclusive are undefined. */ return 0; } - + /* FIXME: Check exclusive value here. */ out: if (locally) *locally = l; diff --git a/lib/metadata/mirror.c b/lib/metadata/mirror.c index 54ac978dc..3a02178b2 100644 --- a/lib/metadata/mirror.c +++ b/lib/metadata/mirror.c @@ -2020,6 +2020,7 @@ int lv_add_mirrors(struct cmd_context *cmd, struct logical_volume *lv, } if (vg_is_clustered(lv->vg)) { + /* FIXME: review check of lv_is_active_remotely */ if (!(lv->status & ACTIVATE_EXCL) && !cluster_mirror_is_available(lv)) { log_error("Shared cluster mirrors are not available."); -- 2.43.5