From eb39bfad81bd8ea7bc357814d4d46e298887cec6 Mon Sep 17 00:00:00 2001 From: Dave Wysochanski Date: Sun, 26 Jul 2009 02:32:00 +0000 Subject: [PATCH] Move 'size' from lvcreate_params into lvcreate_cmdline_params. The main _lvcreate function should deal with extents - the 'size' parameter is just an intermediate step. Should be no functional change. Author: Dave Wysochanski --- tools/lvcreate.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/lvcreate.c b/tools/lvcreate.c index f921d40b2..cca8fc822 100644 --- a/tools/lvcreate.c +++ b/tools/lvcreate.c @@ -20,6 +20,7 @@ struct lvcreate_cmdline_params { percent_t percent; + uint64_t size; }; /* FIXME: refactor and reduce the size of this struct! */ @@ -47,7 +48,6 @@ struct lvcreate_params { /* size */ uint32_t extents; - uint64_t size; uint32_t voriginextents; uint64_t voriginsize; struct dm_list *pvh; @@ -171,8 +171,8 @@ static int _update_extents_params(struct volume_group *vg, { uint32_t pv_extent_count; - if (lp->size && - !(lp->extents = _extents_from_size(vg->cmd, lp->size, + if (lcp->size && + !(lp->extents = _extents_from_size(vg->cmd, lcp->size, vg->extent_size))) return_0; @@ -242,7 +242,7 @@ static int _read_size_params(struct lvcreate_params *lp, log_error("Negative size is invalid"); return 0; } - lp->size = arg_uint64_value(cmd, size_ARG, UINT64_C(0)); + lcp->size = arg_uint64_value(cmd, size_ARG, UINT64_C(0)); lcp->percent = PERCENT_NONE; } -- 2.43.5