From e65561feaebef14ff45b92c6bb0dc0c22f2c03cb Mon Sep 17 00:00:00 2001 From: Zdenek Kabelac Date: Wed, 22 Dec 2010 15:36:41 +0000 Subject: [PATCH] Add backtraces for backup and backup_remove fail paths --- WHATS_NEW | 1 + lib/metadata/metadata.c | 3 ++- tools/vgrename.c | 6 ++++-- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/WHATS_NEW b/WHATS_NEW index 4fc811bc5..96a95355f 100644 --- a/WHATS_NEW +++ b/WHATS_NEW @@ -1,5 +1,6 @@ Version 2.02.80 - ==================================== + Add backtraces for backup and backup_remove fail paths. Detect errors from dm_task_set calls in _get_device_info (dmeventd). Add backtraces for archive and backup_locally in check_current_backup(). Fix memory leak in debug mode of restart_clvmd() error path. diff --git a/lib/metadata/metadata.c b/lib/metadata/metadata.c index 5f75a66dc..27abaea38 100644 --- a/lib/metadata/metadata.c +++ b/lib/metadata/metadata.c @@ -611,7 +611,8 @@ int vg_remove(struct volume_group *vg) } } - backup_remove(vg->cmd, vg->name); + if (!backup_remove(vg->cmd, vg->name)) + stack; if (ret) log_print("Volume group \"%s\" successfully removed", vg->name); diff --git a/tools/vgrename.c b/tools/vgrename.c index 98be9a960..7a4e730e2 100644 --- a/tools/vgrename.c +++ b/tools/vgrename.c @@ -164,8 +164,10 @@ static int vg_rename_path(struct cmd_context *cmd, const char *old_vg_path, } } - backup(vg); - backup_remove(cmd, vg_name_old); + if (!backup(vg)) + stack; + if (!backup_remove(cmd, vg_name_old)) + stack; unlock_vg(cmd, vg_name_new); unlock_and_free_vg(cmd, vg, vg_name_old); -- 2.43.5