From e1154dd09e5a89d960bfe5ab05e520111dbb2b20 Mon Sep 17 00:00:00 2001 From: Jonathan Earl Brassow Date: Tue, 19 Jul 2011 16:23:52 +0000 Subject: [PATCH] Fix potential null ptr deref in 'origin_from_cow' return NULL rather than segfaulting if lv->snapshot is not set --- lib/metadata/snapshot_manip.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/metadata/snapshot_manip.c b/lib/metadata/snapshot_manip.c index 184157ecb..12ac9de5b 100644 --- a/lib/metadata/snapshot_manip.c +++ b/lib/metadata/snapshot_manip.c @@ -81,7 +81,9 @@ struct lv_segment *find_cow(const struct logical_volume *lv) /* Given a cow LV, return its origin */ struct logical_volume *origin_from_cow(const struct logical_volume *lv) { - return lv->snapshot->origin; + if (lv->snapshot) + return lv->snapshot->origin; + return NULL; } void init_snapshot_seg(struct lv_segment *seg, struct logical_volume *origin, -- 2.43.5