From dda823f922ac7294cd24eeb4b1bb7436af24c8c7 Mon Sep 17 00:00:00 2001 From: hunt Date: Mon, 12 Nov 2007 22:04:35 +0000 Subject: [PATCH] 2007-11-12 Martin Hunt * systemtap.base/*.stp: Replace log() calls with println() (or printf() if formatting would help.) * systemtap.maps/*.stp: Ditto. * systemtap.samples/*.stp: Ditto. * systemtap.stress/*.stp: Ditto. --- testsuite/ChangeLog | 8 ++++ testsuite/buildok/context_test.stp | 20 +++++----- testsuite/systemtap.base/add.stp | 10 ++--- testsuite/systemtap.base/array_size.stp | 6 +-- testsuite/systemtap.base/be_order.stp | 8 ++-- testsuite/systemtap.base/deref.stp | 6 +-- testsuite/systemtap.base/deref2.stp | 4 +- testsuite/systemtap.base/equal.stp | 14 +++---- testsuite/systemtap.base/finloop2.stp | 12 +++--- testsuite/systemtap.base/global_init.stp | 8 ++-- testsuite/systemtap.base/if.stp | 12 +++--- testsuite/systemtap.base/inc.stp | 24 +++++++----- testsuite/systemtap.base/kfunct.stp | 6 +-- testsuite/systemtap.base/kmodule.stp | 6 +-- testsuite/systemtap.base/logical_and.stp | 22 +++++------ testsuite/systemtap.base/not.stp | 12 +++--- testsuite/systemtap.base/print.stp | 39 ++++++++++---------- testsuite/systemtap.base/prologues.stp | 2 +- testsuite/systemtap.base/simple.stp | 4 +- testsuite/systemtap.base/tri.stp | 16 ++++---- testsuite/systemtap.maps/absentstats.stp | 4 +- testsuite/systemtap.printf/hello2.stp | 2 +- testsuite/systemtap.samples/args.stp | 2 +- testsuite/systemtap.samples/arith.stp | 6 +-- testsuite/systemtap.samples/arith_limits.stp | 7 ++-- testsuite/systemtap.samples/ioblocktest.stp | 4 +- testsuite/systemtap.samples/iotask.stp | 16 ++++---- testsuite/systemtap.samples/iotask2.stp | 4 +- testsuite/systemtap.samples/primes.stp | 6 ++- testsuite/systemtap.stress/current.stp | 16 ++++---- 30 files changed, 159 insertions(+), 147 deletions(-) diff --git a/testsuite/ChangeLog b/testsuite/ChangeLog index 58f0cc134..302fda250 100644 --- a/testsuite/ChangeLog +++ b/testsuite/ChangeLog @@ -1,3 +1,11 @@ +2007-11-12 Martin Hunt + + * systemtap.base/*.stp: Replace log() calls with + println() (or printf() if formatting would help.) + * systemtap.maps/*.stp: Ditto. + * systemtap.samples/*.stp: Ditto. + * systemtap.stress/*.stp: Ditto. + 2007-11-09 Masami Hiramatsu PR3858 diff --git a/testsuite/buildok/context_test.stp b/testsuite/buildok/context_test.stp index 36bf8ca69..e98b0065b 100755 --- a/testsuite/buildok/context_test.stp +++ b/testsuite/buildok/context_test.stp @@ -8,16 +8,16 @@ function print_stuff () { print("\n\n") print_stack(bt) print("\n\n") - log("execname is \"" . execname() . "\"") - log("pid is " . sprint(pid())) - log("tid is " . sprint(tid())) - log("pexecname is \"" . pexecname() . "\"") - log("ppid is " . sprint(ppid())) - log("uid is " . sprint(uid())) - log("euid is " . sprint(euid())) - log("gid is " . sprint(gid())) - log("egid is " . sprint(egid())) - log("pp is '" . pp() . "'") + printf("execname is %s\n", execname()) + printf("pid is %d\n",pid()) + printf("tid is %d\n", tid()) + printf("pexecname is %s\n", pexecname()) + printf("ppid is %d\n", ppid()) + printf("uid is %d\n", uid()) + printf("euid is %d\n", euid()) + printf("gid is %d\n", gid()) + printf("egid is %d\n", egid()) + printf("pp is %s\n", pp()) } probe kernel.function("uptime_read_proc") { diff --git a/testsuite/systemtap.base/add.stp b/testsuite/systemtap.base/add.stp index 3fa7be382..8ae46f10a 100644 --- a/testsuite/systemtap.base/add.stp +++ b/testsuite/systemtap.base/add.stp @@ -1,7 +1,7 @@ /* * add.stp * - * Check the systemtap "addition" works + * Check that systemtap "addition" works */ global x3 @@ -10,17 +10,17 @@ global x2 probe begin { - log("systemtap starting probe") + println("systemtap starting probe") x1 = 42; x2 = 53; } probe end { - log("systemtap ending probe") + println("systemtap ending probe") x3 = x1 + x2; if (x3 != 95 ) { - log("systemtap test failure"); + println("systemtap test failure") } else { - log("systemtap test success"); + println("systemtap test success") } } diff --git a/testsuite/systemtap.base/array_size.stp b/testsuite/systemtap.base/array_size.stp index cf597a618..7b4572478 100644 --- a/testsuite/systemtap.base/array_size.stp +++ b/testsuite/systemtap.base/array_size.stp @@ -6,8 +6,8 @@ * Call with MAXMAPENTRIES << 100 */ -probe begin { log("systemtap starting probe") } -probe end { log("systemtap ending probe") } +probe begin { println("systemtap starting probe") } +probe end { println("systemtap ending probe") } global a[100] @@ -24,7 +24,7 @@ probe end(1) { ++bad } if (ok == 100 && bad == 0) - log("systemtap test success") + println("systemtap test success") else printf("systemtap test failure - ok:%d, bad:%d\n", ok, bad) } diff --git a/testsuite/systemtap.base/be_order.stp b/testsuite/systemtap.base/be_order.stp index 166d0dca7..57effb1f5 100644 --- a/testsuite/systemtap.base/be_order.stp +++ b/testsuite/systemtap.base/be_order.stp @@ -4,8 +4,8 @@ * Check that ordering of begin/end probes works */ -probe begin { log("systemtap starting probe") } -probe end { log("systemtap ending probe") } +probe begin { println("systemtap starting probe") } +probe end { println("systemtap ending probe") } global beginstr, endstr @@ -24,12 +24,12 @@ probe end(9223372036854775807) { endstr .= "z" if (beginstr == "abccde") - log("systemtap test success") + println("systemtap test success") else printf("systemtap test failure - beginstr:%s != abccde\n", beginstr) if (endstr == "vwxxyz") - log("systemtap test success") + println("systemtap test success") else printf("systemtap test failure - endstr:%s != vwxxyz\n", endstr) } diff --git a/testsuite/systemtap.base/deref.stp b/testsuite/systemtap.base/deref.stp index b003d6579..3f76bfb66 100644 --- a/testsuite/systemtap.base/deref.stp +++ b/testsuite/systemtap.base/deref.stp @@ -4,8 +4,8 @@ * Check that the deref mechanisms work correctly. */ -probe begin { log("systemtap starting probe") } -probe end { log("systemtap ending probe") } +probe begin { println("systemtap starting probe") } +probe end { println("systemtap ending probe") } probe end(1) { log_test("kread u8", kread_u8()) @@ -29,7 +29,7 @@ probe end(1) { function log_test(test:string, result:long) { if (result) - log("systemtap test success") + println("systemtap test success") else printf("systemtap test failure - %s\n", test) } diff --git a/testsuite/systemtap.base/deref2.stp b/testsuite/systemtap.base/deref2.stp index aa59490c1..0008bae7b 100644 --- a/testsuite/systemtap.base/deref2.stp +++ b/testsuite/systemtap.base/deref2.stp @@ -3,7 +3,7 @@ # It's just an ordinary function that returns a 4-byte signed value, # even on a 64-bit hosts. probe kernel.function("sock_alloc_fd").return { - log ($return < 0 ? "neg" : "pos") + println ($return < 0 ? "neg" : "pos") } probe timer.s (5) { exit () } -probe begin { log ("start") } \ No newline at end of file +probe begin { println ("start") } diff --git a/testsuite/systemtap.base/equal.stp b/testsuite/systemtap.base/equal.stp index 83ca0115e..0333307ad 100644 --- a/testsuite/systemtap.base/equal.stp +++ b/testsuite/systemtap.base/equal.stp @@ -7,22 +7,22 @@ global count global count2 -probe begin { log("systemtap starting probe") } +probe begin { println("systemtap starting probe") } probe kernel.function("schedule") { ++count; ++count2; } probe end { - log("systemtap ending probe") - log("count = " . sprint(count)); - log("count2 = " . sprint(count)); + println("systemtap ending probe") + printf("count = %d\n", count) + printf("count2 = %d\n", count) if ( count == count2) { if ( (count-1) == count2 ) { - log("systemtap test failure"); + println("systemtap test failure"); } else { - log("systemtap test success"); + println("systemtap test success"); } } else { - log("systemtap test failure"); + println("systemtap test failure"); } } diff --git a/testsuite/systemtap.base/finloop2.stp b/testsuite/systemtap.base/finloop2.stp index 8f12fd8a5..b675be41e 100644 --- a/testsuite/systemtap.base/finloop2.stp +++ b/testsuite/systemtap.base/finloop2.stp @@ -10,7 +10,7 @@ global loop_count probe begin { - log("systemtap starting probe") + println("systemtap starting probe") } probe kernel.function("schedule") @@ -23,12 +23,12 @@ probe kernel.function("schedule") probe end { - log("systemtap ending probe") - log("count = " . sprint(count)); - log("loop_count = " . sprint(loop_count)); + println("systemtap ending probe") + printf("count = %d\n", count) + printf("loop_count = %d\n", loop_count) if ( count * 10 == loop_count) { - log("systemtap test success"); + println("systemtap test success"); } else { - log("systemtap test failure"); + println("systemtap test failure"); } } diff --git a/testsuite/systemtap.base/global_init.stp b/testsuite/systemtap.base/global_init.stp index a5d7e58e4..304788464 100644 --- a/testsuite/systemtap.base/global_init.stp +++ b/testsuite/systemtap.base/global_init.stp @@ -4,8 +4,8 @@ * Check that global variables are initialized before all begin probes */ -probe begin { log("systemtap starting probe") } -probe end { log("systemtap ending probe") } +probe begin { println("systemtap starting probe") } +probe end { println("systemtap ending probe") } global gnum = 42 global gstr = "foobar" @@ -19,12 +19,12 @@ probe begin(-9223372036854775808) { probe end { if (gnum_saved == 42) - log("systemtap test success") + println("systemtap test success") else printf("systemtap test failure - gnum_saved:%d != 42\n", gnum_saved) if (gstr_saved == "foobar") - log("systemtap test success") + println("systemtap test success") else printf("systemtap test failure - gstr_saved:%s != foobar\n", gstr_saved) } diff --git a/testsuite/systemtap.base/if.stp b/testsuite/systemtap.base/if.stp index bcbafd517..fa4da54d0 100644 --- a/testsuite/systemtap.base/if.stp +++ b/testsuite/systemtap.base/if.stp @@ -4,19 +4,19 @@ * Check the systemtap if statement works */ -probe begin { log("systemtap starting probe") } +probe begin { println("systemtap starting probe") } probe end { - log("systemtap ending probe") + println("systemtap ending probe") if (1) { - log("systemtap test success"); + println("systemtap test success"); } else { - log("systemtap test failure"); + println("systemtap test failure"); } if (0) { - log("systemtap test failure"); + println("systemtap test failure"); } else { - log("systemtap test success"); + println("systemtap test success"); } } diff --git a/testsuite/systemtap.base/inc.stp b/testsuite/systemtap.base/inc.stp index f37b2ceea..17d6dc7c6 100644 --- a/testsuite/systemtap.base/inc.stp +++ b/testsuite/systemtap.base/inc.stp @@ -1,24 +1,28 @@ /* * inc.stp * - * Check the systemtap ++ works + * Check that systemtap ++ works */ global x1 probe begin { - log("systemtap starting probe"); - x1 = 41; + println("systemtap starting probe") + x1 = 41 } probe end { - log("systemtap ending probe"); - ++x1; - if (x1 != 42 ) { - log("systemtap test failure"); - } else { - log("systemtap test success"); - } + println("systemtap ending probe") + x1++ + if (x1 == 42) { + ++x1 + if (x1 != 43 ) { + println("systemtap test failure") + } else { + println("systemtap test success") + } + } else + println("systemtap test failure") } diff --git a/testsuite/systemtap.base/kfunct.stp b/testsuite/systemtap.base/kfunct.stp index 15be51bd3..930313951 100644 --- a/testsuite/systemtap.base/kfunct.stp +++ b/testsuite/systemtap.base/kfunct.stp @@ -9,7 +9,7 @@ global count probe begin { - log("systemtap starting probe") + println("systemtap starting probe") } probe kernel.function("schedule") @@ -19,6 +19,6 @@ probe kernel.function("schedule") probe end { - log("systemtap ending probe") - log("count = " . sprint(count)); + println("systemtap ending probe") + printf("count = %d\n", count) } diff --git a/testsuite/systemtap.base/kmodule.stp b/testsuite/systemtap.base/kmodule.stp index 9c718f29f..19241cab3 100644 --- a/testsuite/systemtap.base/kmodule.stp +++ b/testsuite/systemtap.base/kmodule.stp @@ -9,7 +9,7 @@ global count probe begin { - log("systemtap starting probe") + println("systemtap starting probe") } probe module("ext3").function("ext3_sync_file") ?, @@ -22,6 +22,6 @@ probe module("ext3").function("ext3_sync_file") ?, probe end { - log("systemtap ending probe") - log("count = " . sprint(count)); + println("systemtap ending probe") + println("count = " . sprint(count)); } diff --git a/testsuite/systemtap.base/logical_and.stp b/testsuite/systemtap.base/logical_and.stp index 5017190ba..3f4961b46 100644 --- a/testsuite/systemtap.base/logical_and.stp +++ b/testsuite/systemtap.base/logical_and.stp @@ -1,7 +1,7 @@ /* * logical_and.stp * - * Check the systemtap "logical and" works + * Check that systemtap "logical and" works */ global x1_0 @@ -11,31 +11,31 @@ global x4_1 probe begin { - log("systemtap starting probe") + println("systemtap starting probe") x1_0 = 0; x2_1 = 1; x3_0 = 0; x4_1 = 1; } probe end { - log("systemtap ending probe") + println("systemtap ending probe") if (x1_0 && x3_0 ) { - log("systemtap test failure"); + println("systemtap test failure"); } else { - log("systemtap test success"); + println("systemtap test success"); } if (x2_1 && x3_0 ) { - log("systemtap test failure"); + println("systemtap test failure"); } else { - log("systemtap test success"); + println("systemtap test success"); } if (x1_0 && x4_1 ) { - log("systemtap test failure"); + println("systemtap test failure"); } else { - log("systemtap test success"); + println("systemtap test success"); } if (x2_1 && x4_1 ) { - log("systemtap test success"); + println("systemtap test success"); } else { - log("systemtap test failure"); + println("systemtap test failure"); } } diff --git a/testsuite/systemtap.base/not.stp b/testsuite/systemtap.base/not.stp index 3e1bbd505..166346dfe 100644 --- a/testsuite/systemtap.base/not.stp +++ b/testsuite/systemtap.base/not.stp @@ -1,24 +1,24 @@ /* * neg.stp * - * Check the systemtap negation works + * Check that systemtap negation works */ global x2, x1 probe begin { - log("systemtap starting probe") + println("systemtap starting probe") x1 = 0xaaaaaaaaaaaaaaaa } probe end { - log("systemtap ending probe") - x2 = ~x1; + println("systemtap ending probe") + x2 = ~x1 if ( x2 != 0x5555555555555555 ) { - log("systemtap test failure"); + println("systemtap test failure") } else { - log("systemtap test success"); + println("systemtap test success") } } diff --git a/testsuite/systemtap.base/print.stp b/testsuite/systemtap.base/print.stp index e1b64c357..161be4b4c 100644 --- a/testsuite/systemtap.base/print.stp +++ b/testsuite/systemtap.base/print.stp @@ -8,32 +8,33 @@ global s1, s2, s3 probe begin { - log("systemtap starting probe") - s1 = "systemtap" - s2 = "test" - s3 = "success" + println("systemtap starting probe") + s1 = "systemtap" + s2 = "test" + s3 = "success" } probe end { - log("systemtap ending probe") + println("systemtap ending probe") - print(s1, " ", s2, " ", s3, "\n") - print(sprint(s1, " ", s2, " ", s3, "\n")) + print(s1, " ", s2, " ", s3, "\n") + print(sprint(s1, " ", s2, " ", s3, "\n")) - println(s1, " ", s2, " ", s3) - print(sprintln(s1, " ", s2, " ", s3)) + println(s1, " ", s2, " ", s3) + print(sprintln(s1, " ", s2, " ", s3)) - printd(" ", s1, s2, s3 . "\n") - print(sprintd(" ", s1, s2, s3 . "\n")) + printd(" ", s1, s2, s3 . "\n") + print(sprintd(" ", s1, s2, s3 . "\n")) - printdln(" ", s1, s2, s3) - print(sprintdln(" ", s1, s2, s3)) + printdln(" ", s1, s2, s3) + print(sprintdln(" ", s1, s2, s3)) - // check that formatting characters get escaped correctly in the delimiter - s = sprintd("%% % \\ \"", 1, 2, 3) - if (s == "1%% % \\ \"2%% % \\ \"3") - log("systemtap test success") - else - log("systemtap test failure") + // Check that formatting characters get escaped correctly + // in the delimiter. + s = sprintd("%% % \\ \"", 1, 2, 3) + if (s == "1%% % \\ \"2%% % \\ \"3") + println("systemtap test success") + else + println("systemtap test failure") } diff --git a/testsuite/systemtap.base/prologues.stp b/testsuite/systemtap.base/prologues.stp index fc32ccd90..cbda14f98 100644 --- a/testsuite/systemtap.base/prologues.stp +++ b/testsuite/systemtap.base/prologues.stp @@ -1,6 +1,6 @@ # These sys_ functions often display prologue sensitivity probe syscall.read, syscall.write { - log (name . argstr) + printf("%s (%s)\n", name, argstr) if (num++ > 20) exit() } global num diff --git a/testsuite/systemtap.base/simple.stp b/testsuite/systemtap.base/simple.stp index 28a81cffa..ee8a97a84 100644 --- a/testsuite/systemtap.base/simple.stp +++ b/testsuite/systemtap.base/simple.stp @@ -7,10 +7,10 @@ probe begin { - log("systemtap starting probe") + println("systemtap starting probe") } probe end { - log("systemtap ending probe") + println("systemtap ending probe") } diff --git a/testsuite/systemtap.base/tri.stp b/testsuite/systemtap.base/tri.stp index 80aed1e78..92b788015 100644 --- a/testsuite/systemtap.base/tri.stp +++ b/testsuite/systemtap.base/tri.stp @@ -8,29 +8,29 @@ global x1, x2, x3, x4, x5, x6 probe begin { - log("systemtap starting probe"); + println("systemtap starting probe"); x1 = 0; x2 = 1; x3=30; } probe end { - log("systemtap ending probe") + println("systemtap ending probe") x4 = x1 ? 9: 10; x5 = x2 ? 99: 100; x6 = x3 ? 999: 1000; if (x4 != 10 ) { - log("systemtap test failure"); + println("systemtap test failure"); } else { - log("systemtap test success"); + println("systemtap test success"); } if (x5 != 99 ) { - log("systemtap test failure"); + println("systemtap test failure"); } else { - log("systemtap test success"); + println("systemtap test success"); } if (x6 != 999 ) { - log("systemtap test failure"); + println("systemtap test failure"); } else { - log("systemtap test success"); + println("systemtap test success"); } } diff --git a/testsuite/systemtap.maps/absentstats.stp b/testsuite/systemtap.maps/absentstats.stp index 641af5d35..aeb176a1f 100644 --- a/testsuite/systemtap.maps/absentstats.stp +++ b/testsuite/systemtap.maps/absentstats.stp @@ -1,7 +1,7 @@ # stap -DMAXERRORS=40 global sc -probe begin { log(sprint(@count(sc))) } +probe begin { println(@count(sc)) } probe begin { print(@sum(sc)) } probe begin { print(@max(sc)) } probe begin { print(@min(sc)) } @@ -10,7 +10,7 @@ probe begin { print(@hist_log(sc)) } probe begin { x=@hist_log(sc)[5]; print(x) } global ry -probe begin { log(sprint(@count(ry[4]))) } +probe begin { println(@count(ry[4])) } probe begin { print(@sum(ry[4])) } probe begin { print(@max(ry[4])) } probe begin { print(@min(ry[4])) } diff --git a/testsuite/systemtap.printf/hello2.stp b/testsuite/systemtap.printf/hello2.stp index aa0798fa7..de3db5888 100644 --- a/testsuite/systemtap.printf/hello2.stp +++ b/testsuite/systemtap.printf/hello2.stp @@ -1,7 +1,7 @@ probe begin { print("Print"); - log("Systemtap"); + println("Systemtap"); warn("warning"); exit() } diff --git a/testsuite/systemtap.samples/args.stp b/testsuite/systemtap.samples/args.stp index 85e731aca..84b6080e3 100644 --- a/testsuite/systemtap.samples/args.stp +++ b/testsuite/systemtap.samples/args.stp @@ -3,7 +3,7 @@ global foo, bar probe begin { - log ("foo=" . foo . " bar=" . sprint (bar+0 /* cast bar to integer */)) + printf("foo=%s bar=%d\n", foo, bar) exit () } diff --git a/testsuite/systemtap.samples/arith.stp b/testsuite/systemtap.samples/arith.stp index 80f0c0408..59016dcb7 100644 --- a/testsuite/systemtap.samples/arith.stp +++ b/testsuite/systemtap.samples/arith.stp @@ -8,7 +8,7 @@ function test (v,n1,n2) { failures ++ result = "fail" } - log ("test " . (sprint (++testno)) . " [" . v . "]\t" . result) + println ("test " . (sprint (++testno)) . " [" . v . "]\t" . result) } function stest (v,n1,n2) { @@ -19,7 +19,7 @@ function stest (v,n1,n2) { failures ++ result = "fail" } - log ("test " . (sprint (++testno)) . " [" . v . "]\t" . result) + println ("test " . (sprint (++testno)) . " [" . v . "]\t" . result) } @@ -75,5 +75,5 @@ probe timer.jiffies(1) { # some time after all the begin probes } probe end { - log ("passes: " . sprint(passes) . " failures: " . sprint(failures)) + printf ("passes: %d failures: %d\n", passes, failures) } diff --git a/testsuite/systemtap.samples/arith_limits.stp b/testsuite/systemtap.samples/arith_limits.stp index f38a5a681..6c6208300 100644 --- a/testsuite/systemtap.samples/arith_limits.stp +++ b/testsuite/systemtap.samples/arith_limits.stp @@ -8,7 +8,7 @@ function test (v,n1,n2) { failures ++ result = "fail" } - log ("test " . (sprint (testno++)) . " [" . v . "]\t\t" . result) + printf ("test %d [%s]\t\t%s\n", testno++, v, result) } # Exactly the same as test() except it will magically work for strings. @@ -22,7 +22,7 @@ function teststr (v,n1,n2) { failures ++ result = "fail" } - log ("test " . (sprint (testno++)) . " [" . v . "]\t\t" . result) + printf ("test %d [%s]\t\t%s\n", testno++, v, result) } @@ -76,6 +76,5 @@ probe begin { } probe end { - print ("passes: " . sprint(passes)) - print (" failures: " . sprint(failures). "\n") + printf ("passes: %d failures: %d\n", passes, failures) } diff --git a/testsuite/systemtap.samples/ioblocktest.stp b/testsuite/systemtap.samples/ioblocktest.stp index 4aa3c3a93..f8a1c5685 100644 --- a/testsuite/systemtap.samples/ioblocktest.stp +++ b/testsuite/systemtap.samples/ioblocktest.stp @@ -1,12 +1,12 @@ #! stap global teststr -probe begin { log("systemtap starting probe") } +probe begin { println("systemtap starting probe") } probe ioblock.request, ioblock.end { teststr = sprintf("ioblock: %s\t%d\t%s\t%d\n", devname, sector, bio_rw_str(rw), bio_rw_num(rw)) } probe end { - log("systemtap ending probe") + println("systemtap ending probe") printf("%s", teststr) } diff --git a/testsuite/systemtap.samples/iotask.stp b/testsuite/systemtap.samples/iotask.stp index 13d273a33..ee0ae4b44 100644 --- a/testsuite/systemtap.samples/iotask.stp +++ b/testsuite/systemtap.samples/iotask.stp @@ -23,23 +23,21 @@ probe kernel.function("sys_write") { write_bytes[execname()] += $count; } -probe begin { log( "starting probe" ); } +probe begin { println( "starting probe" ); } probe end { foreach( name in names){ - log ("process: " . name); + printf ("process: %s\n", name); if (opens[name]) - log( "opens n=" . sprint(opens[name])); - if ( reads[name]){ + printf ("opens=%d\n",opens[name]) + if (reads[name]){ count = reads[name]; total=read_bytes[name]; - log("reads n, sum, avg=". sprint(count) - . "," . sprint(total) . "," . sprint(total/count)); + printf("reads=%d, sum=%d, avg=%d\n", count, total, total/count); } if (writes[name]){ count = writes[name]; total=write_bytes[name]; - log("writes n, sum, avg=". sprint(count) - . "," . sprint(total) . "," . sprint(total/count)); + printf("writes=%d, sum=%d, avg=%d\n", count, total, total/count); } - log(""); + println(""); } } diff --git a/testsuite/systemtap.samples/iotask2.stp b/testsuite/systemtap.samples/iotask2.stp index 1f3248e3a..cc4707b75 100644 --- a/testsuite/systemtap.samples/iotask2.stp +++ b/testsuite/systemtap.samples/iotask2.stp @@ -1,9 +1,9 @@ global names, opens, reads, writes -probe begin { log("starting probe") } +probe begin { println("starting probe") } probe timer.ms(10000) { - log("stopping probe after 10 seconds") + println("stopping probe after 10 seconds") exit() } diff --git a/testsuite/systemtap.samples/primes.stp b/testsuite/systemtap.samples/primes.stp index 7e7aeb372..1072b4b25 100644 --- a/testsuite/systemtap.samples/primes.stp +++ b/testsuite/systemtap.samples/primes.stp @@ -1,5 +1,7 @@ #! stap + global odds, evens + probe begin { # "no" and "ne" are local integers for (i=1; i<10; i++) { @@ -13,9 +15,9 @@ probe begin { probe end { foreach (x+ in odds) { - log("odds[" . sprint(x) . "] = " . sprint(odds[x])) + printf("odds[%d] = %d\n", x, odds[x]) } foreach (x in evens-) { - log("evens[" . sprint(x) . "] = " . sprint(evens[x])) + printf("evens[%d] = %d\n", x, evens[x]) } } diff --git a/testsuite/systemtap.stress/current.stp b/testsuite/systemtap.stress/current.stp index ff2a99419..4c0f824c0 100644 --- a/testsuite/systemtap.stress/current.stp +++ b/testsuite/systemtap.stress/current.stp @@ -14,7 +14,7 @@ function pcommlen:long () %{ THIS->__retvalue = strlen(current->parent->comm); %} -probe begin { log("systemtap starting probe") } +probe begin { println("systemtap starting probe") } probe timer.profile, @@ -73,7 +73,7 @@ function get_TASK_COMM_LEN:long() %{ %} probe end { - log("systemtap ending probe") + println("systemtap ending probe") printf("count = %d\n", @count(length)) printf("sum = %d\n", @sum(length)) printf("min = %d\n", @min(length)) @@ -86,15 +86,15 @@ probe end { * valid, even though it dereferenced without crashing. */ if (@min(length) > 0) { - log("systemtap test success") + println("systemtap test success") } else { - log("unexpected minimum length") - log("systemtap test failure") + println("unexpected minimum length") + println("systemtap test failure") } if (@max(length) < get_TASK_COMM_LEN()) { - log("systemtap test success") + println("systemtap test success") } else { - log("unexpected maximum length") - log("systemtap test failure") + println("unexpected maximum length") + println("systemtap test failure") } } -- 2.43.5