From c892ae04f47908479220247a311bc0067229b592 Mon Sep 17 00:00:00 2001 From: Leonardo Sandoval Date: Thu, 4 Oct 2018 16:40:36 -0500 Subject: [PATCH] benchtests: Set float type on --threshold argument Otherwise, we see the following runtime error when using the parameter: File "./glibc/benchtests/scripts/compare_bench.py", line 46, in do_compare if d > threshold: TypeError: '>' not supported between instances of 'float' and 'str' * benchtests/scripts/compare_bench.py (main): set float type on threshold argument. --- ChangeLog | 5 +++++ benchtests/scripts/compare_bench.py | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 70782a6dd5..af0f15b468 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2018-10-08 Leonardo Sandoval + + * benchtests/scripts/compare_bench.py (main): set float type on + threshold argument. + 2018-10-08 Rafal Luzynski [BZ #23740] diff --git a/benchtests/scripts/compare_bench.py b/benchtests/scripts/compare_bench.py index 88e8911d81..f4b7742f90 100755 --- a/benchtests/scripts/compare_bench.py +++ b/benchtests/scripts/compare_bench.py @@ -175,7 +175,7 @@ if __name__ == '__main__': parser.add_argument('--schema', default=os.path.join(os.path.dirname(os.path.realpath(__file__)),'benchout.schema.json'), help='JSON file to validate source/dest files (default: %(default)s)') - parser.add_argument('--threshold', default=10.0, help='Only print those with equal or higher threshold (default: %(default)s)') + parser.add_argument('--threshold', default=10.0, type=float, help='Only print those with equal or higher threshold (default: %(default)s)') args = parser.parse_args() -- 2.43.5