From c539cb3d727e05981227cee40930fec7daae9028 Mon Sep 17 00:00:00 2001 From: David Smith Date: Mon, 30 Oct 2017 15:39:11 -0500 Subject: [PATCH] Match non-executable shared libraries in glob patterns. Shared libraries in Debian do not have executable permissions. This patch makes glob patterns work for those. Debian policy 8.1: "Shared libraries should not be installed executable, since the dynamic linker does not require this and trying to execute a shared library usually results in a core dump." --- tapsets.cxx | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tapsets.cxx b/tapsets.cxx index 36eb73c08..f571b8825 100644 --- a/tapsets.cxx +++ b/tapsets.cxx @@ -8054,8 +8054,7 @@ glob_executable(const string& pattern) const char* globbed = the_blob.gl_pathv[i]; struct stat st; - if (access (globbed, X_OK) == 0 - && stat (globbed, &st) == 0 + if (stat (globbed, &st) == 0 && S_ISREG (st.st_mode)) // see find_executable() { // Need to call resolve_path here, in order to path-expand -- 2.43.5