From bfd774a20a22f8224a8bc3b507c4564fe6f54fc6 Mon Sep 17 00:00:00 2001 From: Jonathan Earl Brassow Date: Tue, 13 Sep 2011 14:37:48 +0000 Subject: [PATCH] Fix for bug 737125 - unable to create mirror on 1K extent size VG _alloc_init calculates the number of necessary log extents via 'mirror_log_extents'. 'mirror_log_extents' takes 3 arguments: region_size, pe_size, and size of the mirror LV. Unfortunately, _alloc_init is guessing at the mirror size by using 'ah->new_extents / ah->area_multiple' - the number of extents that the mirror images have. However, this is /always/ wrong when allocating the log separately. Further, the log is always allocated separately unless we are up-converting the mirror at the same time. It was by luck alone that a default value of '1' reflects what we want in most cases. In order to get a decent value computed, we need to pass in the 'lv' argument to allocate_extents. This would normally imply a desire for cling/contiguous allocation to the given LV, but since we are not allocating any parallel extents and only log extents, it works fine. --- WHATS_NEW | 1 + lib/metadata/mirror.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/WHATS_NEW b/WHATS_NEW index 43e621e10..77de51f7c 100644 --- a/WHATS_NEW +++ b/WHATS_NEW @@ -1,5 +1,6 @@ Version 2.02.89 - ================================== + Fix log size calculation when only a log is being added to a mirror. Work around resume_lv causing error LV scanning during splitmirror operation. Add 7th lv_attr char to show the related kernel target. Terminate pv_attr field correctly. (2.02.86) diff --git a/lib/metadata/mirror.c b/lib/metadata/mirror.c index ef8b76d66..fd863df4f 100644 --- a/lib/metadata/mirror.c +++ b/lib/metadata/mirror.c @@ -1966,7 +1966,7 @@ int add_mirror_log(struct cmd_context *cmd, struct logical_volume *lv, } /* allocate destination extents */ - ah = allocate_extents(lv->vg, NULL, segtype, + ah = allocate_extents(lv->vg, lv, segtype, 0, 0, log_count - old_log_count, region_size, 0, allocatable_pvs, alloc, parallel_areas); if (!ah) { -- 2.43.5