From b13837c2c0408f23309b0e8d03f6ba01a0f1177d Mon Sep 17 00:00:00 2001 From: Zdenek Kabelac Date: Tue, 30 Nov 2010 22:40:19 +0000 Subject: [PATCH] Add stack trace for error path If dm_task_set_cookie() fails print stack trace, but keep going on. --- WHATS_NEW | 1 + libdm/ioctl/libdm-iface.c | 7 ++++--- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/WHATS_NEW b/WHATS_NEW index b4006848c..05b037928 100644 --- a/WHATS_NEW +++ b/WHATS_NEW @@ -1,5 +1,6 @@ Version 2.02.78 - ==================================== + Add error path stack traces for _process_mapper_dir(), _create_and_load_v4(). Add missing test for failed pool allocation in write_config_node(). Replace snprintf with dm_snprintf in clvmd-command.c. Check reallocated buffer for NULL before use in clvmd do_command(). diff --git a/libdm/ioctl/libdm-iface.c b/libdm/ioctl/libdm-iface.c index 3bc19096b..b18249a9d 100644 --- a/libdm/ioctl/libdm-iface.c +++ b/libdm/ioctl/libdm-iface.c @@ -1779,9 +1779,10 @@ static int _create_and_load_v4(struct dm_task *dmt) if (dmt->cookie_set) { cookie = (dmt->event_nr & ~DM_UDEV_FLAGS_MASK) | (DM_COOKIE_MAGIC << DM_UDEV_FLAGS_SHIFT); - dm_task_set_cookie(dmt, &cookie, - (dmt->event_nr & DM_UDEV_FLAGS_MASK) >> - DM_UDEV_FLAGS_SHIFT); + if (!dm_task_set_cookie(dmt, &cookie, + (dmt->event_nr & DM_UDEV_FLAGS_MASK) >> + DM_UDEV_FLAGS_SHIFT)) + stack; /* keep going */ } if (!dm_task_run(dmt)) -- 2.43.5