From ac0945bc4a14dfe8def578f9132e7261f254a279 Mon Sep 17 00:00:00 2001 From: Zdenek Kabelac Date: Fri, 14 Jul 2017 20:16:54 +0200 Subject: [PATCH] tests: aux.sh fix double quote Patch 72a58ce4b0f68f6e45ae30606fe5af21caa42b43 was wronly placing double quotes around this variable which we want to pass expanded, as it's just set of 'space' device args ATM. TODO consider using array[@] to make this cleaner. Add shellcheck directive to skip warning here --- test/lib/aux.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/lib/aux.sh b/test/lib/aux.sh index a0e05ffbf..9a4868958 100644 --- a/test/lib/aux.sh +++ b/test/lib/aux.sh @@ -224,8 +224,9 @@ prepare_lvmetad() { # Default debug is "-l all" and could be override # by setting LVM_TEST_LVMETAD_DEBUG_OPTS before calling inittest. echo -n "## preparing lvmetad..." + # shellcheck disable=SC2086 $run_valgrind lvmetad -f "$@" -s "$TESTDIR/lvmetad.socket" \ - "${LVM_TEST_LVMETAD_DEBUG_OPTS--l all}" & + ${LVM_TEST_LVMETAD_DEBUG_OPTS--l all} & echo $! > LOCAL_LVMETAD for i in {1..100} ; do test "$i" -eq 100 && die "Startup of lvmetad is too slow." -- 2.43.5