From 99c2b40803e83bb5d572e379677d9938237f5ca3 Mon Sep 17 00:00:00 2001 From: Jonathan Lebon Date: Fri, 9 Jan 2015 11:29:05 -0500 Subject: [PATCH] tracepoint_query: make private what need not be public And document each member with a small comment. --- tapsets.cxx | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/tapsets.cxx b/tapsets.cxx index 7df42cd65..a66c166aa 100644 --- a/tapsets.cxx +++ b/tapsets.cxx @@ -10860,16 +10860,11 @@ tracepoint_derived_probe_group::emit_module_exit (systemtap_session& s) struct tracepoint_query : public base_query { - string system; - string tracepoint; - string current_system; - probe * base_probe; probe_point * base_loc; vector & results; set probed_names; - string retrieve_trace_system(); void handle_query_module(); int handle_query_cu(Dwarf_Die * cudie); int handle_query_func(Dwarf_Die * func); @@ -10914,6 +10909,13 @@ struct tracepoint_query : public base_query if (this->tracepoint.empty()) throw SEMANTIC_ERROR (_("invalid tracepoint string provided")); } + +private: + string system; // target subsystem(s) to query + string tracepoint; // target tracepoint(s) to query + string current_system; // subsystem of module currently being visited + + string retrieve_trace_system(); }; // name of section where TRACE_SYSTEM is stored @@ -10963,7 +10965,7 @@ tracepoint_query::retrieve_trace_system() void tracepoint_query::handle_query_module() { - // Get the TRACE_SYSTEM for this CU, if any. It will be found in the + // Get the TRACE_SYSTEM for this module, if any. It will be found in the // STAP_TRACE_SYSTEM section if it exists. current_system = retrieve_trace_system(); -- 2.43.5