From 8df4c3748a630a88ae6569b0851a624b14d710ce Mon Sep 17 00:00:00 2001 From: Milan Broz Date: Wed, 13 Aug 2008 12:44:24 +0000 Subject: [PATCH] Fix vgcfgbackup to properly check filename if template is used. --- WHATS_NEW | 1 + tools/vgcfgbackup.c | 6 +++--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/WHATS_NEW b/WHATS_NEW index f1a765d29..c6e1502d7 100644 --- a/WHATS_NEW +++ b/WHATS_NEW @@ -1,5 +1,6 @@ Version 2.02.40 - ================================ + Fix vgcfgbackup to properly check filename if template is used. configure aborts if lcov or genhtml are missing with --enable-profiling vgremove tries to remove lv snapshot first. Added function lv_remove_with_dependencies(). diff --git a/tools/vgcfgbackup.c b/tools/vgcfgbackup.c index 90f64b37f..6418e04d4 100644 --- a/tools/vgcfgbackup.c +++ b/tools/vgcfgbackup.c @@ -34,8 +34,7 @@ static char *_expand_filename(const char *template, const char *vg_name, dm_free(filename); return NULL; } - if (*last_filename && !strncmp(*last_filename, filename, - strlen(template))) { + if (*last_filename && !strncmp(*last_filename, filename, PATH_MAX)) { log_error("VGs must be backed up into different files. " "Use %%s in filename for VG name."); dm_free(filename); @@ -70,7 +69,8 @@ static int vg_backup_single(struct cmd_context *cmd, const char *vg_name, return ECMD_FAILED; } - backup_to_file(filename, vg->cmd->cmd_line, vg); + if (!backup_to_file(filename, vg->cmd->cmd_line, vg)) + return ECMD_FAILED; } else { if (!consistent) { log_error("No backup taken: specify filename with -f " -- 2.43.5