From 8c1c00e93e78b3c9504fff318d3b07a28749cd99 Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Sun, 8 Sep 1996 15:05:55 +0000 Subject: [PATCH] TAGS fixup --- ChangeLog | 8 ++++++++ Makefile.am | 8 +++----- Makefile.in | 8 +++----- TODO | 2 ++ lib/am/Makefile.am | 8 +++----- tags-clean.am | 9 +++++++-- 6 files changed, 26 insertions(+), 17 deletions(-) diff --git a/ChangeLog b/ChangeLog index 75f777a9..1c50032c 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,11 @@ +Sun Sep 8 09:00:37 1996 Tom Tromey + + * Makefile.am (installcheck-local): Check all scripts. + +Sat Sep 7 19:22:32 1996 Tom Tromey + + * tags-clean.am: Do deletions here again. + Thu Sep 5 09:06:23 1996 Tom Tromey * automake.in (usage): Include bug-reporting information. diff --git a/Makefile.am b/Makefile.am index 2f0e4a92..0831b4ac 100644 --- a/Makefile.am +++ b/Makefile.am @@ -33,11 +33,9 @@ TAGS_DEPENDENCIES = automake.in aclocal.in automake.texi ## doesn't exist, then this test is meaningless anyway. # Check to make sure some installed files are executable. installcheck-local: - $(PERL) -e "exit ! -x '$(pkgdatadir)/config.guess';" - $(PERL) -e "exit ! -x '$(pkgdatadir)/config.sub';" - $(PERL) -e "exit ! -x '$(pkgdatadir)/install-sh';" - $(PERL) -e "exit ! -x '$(pkgdatadir)/mdate-sh';" - $(PERL) -e "exit ! -x '$(pkgdatadir)/mkinstalldirs';" + for file in $(pkgdata_SCRIPTS); do \ + $(PERL) -e "exit ! -x $(pkgdatadir)/$$file;" || exit 1; \ + done # Some simple checks, and then ordinary check. These are only really # guaranteed to work on my machine. diff --git a/Makefile.in b/Makefile.in index ceee986d..62a9a3c2 100644 --- a/Makefile.in +++ b/Makefile.in @@ -427,11 +427,9 @@ maintainer-clean-generic clean mostlyclean distclean maintainer-clean # Check to make sure some installed files are executable. installcheck-local: - $(PERL) -e "exit ! -x '$(pkgdatadir)/config.guess';" - $(PERL) -e "exit ! -x '$(pkgdatadir)/config.sub';" - $(PERL) -e "exit ! -x '$(pkgdatadir)/install-sh';" - $(PERL) -e "exit ! -x '$(pkgdatadir)/mdate-sh';" - $(PERL) -e "exit ! -x '$(pkgdatadir)/mkinstalldirs';" + for file in $(pkgdata_SCRIPTS); do \ + $(PERL) -e "exit ! -x $(pkgdatadir)/$$file;" || exit 1; \ + done # Some simple checks, and then ordinary check. These are only really # guaranteed to work on my machine. diff --git a/TODO b/TODO index 39811c7a..2300e100 100644 --- a/TODO +++ b/TODO @@ -7,6 +7,7 @@ Priorities for release: !! remove autosystem-specific macros !! should write autoconf-style doc entries for each m4 macro + [ this should really go into autoconf in some automatic way ] Joel> I know that the following is needed at the end of configure.in: Joel> [test -z "$CONFIG_HEADERS" || echo timestamp >stamp-h]) Joel> However, if automake checked that this line is present, it would @@ -47,6 +48,7 @@ characters long. * Don't include any symbolic links in the distribution itself. (ditto hard links) * Make sure that all the files in the distribution are world-readable. +** also, check --help output and --version output. Idea from François consider supporting "var+= stuff" syntax. rewrite to just var=... on output. This is sometimes convenient when you want to write a diff --git a/lib/am/Makefile.am b/lib/am/Makefile.am index 2f0e4a92..0831b4ac 100644 --- a/lib/am/Makefile.am +++ b/lib/am/Makefile.am @@ -33,11 +33,9 @@ TAGS_DEPENDENCIES = automake.in aclocal.in automake.texi ## doesn't exist, then this test is meaningless anyway. # Check to make sure some installed files are executable. installcheck-local: - $(PERL) -e "exit ! -x '$(pkgdatadir)/config.guess';" - $(PERL) -e "exit ! -x '$(pkgdatadir)/config.sub';" - $(PERL) -e "exit ! -x '$(pkgdatadir)/install-sh';" - $(PERL) -e "exit ! -x '$(pkgdatadir)/mdate-sh';" - $(PERL) -e "exit ! -x '$(pkgdatadir)/mkinstalldirs';" + for file in $(pkgdata_SCRIPTS); do \ + $(PERL) -e "exit ! -x $(pkgdatadir)/$$file;" || exit 1; \ + done # Some simple checks, and then ordinary check. These are only really # guaranteed to work on my machine. diff --git a/tags-clean.am b/tags-clean.am index 2a52b339..62c143a6 100644 --- a/tags-clean.am +++ b/tags-clean.am @@ -19,8 +19,13 @@ mostlyclean-tags: clean-tags: +## The GNU Standards mandates that tags files be removed by +## maintainer-clean. But I'm told (by François Pinard) that this is +## really because RMS usually includes TAGS files in his +## distributions. Since we do not, we instead have "distclean" remove +## them. The rule is: if the user built it, "distclean" removes it. +## If it is shipped, "maintainer-clean" removes it. distclean-tags: + rm -f TAGS ID -## The GNU Standards mandates that tags files be removed here. maintainer-clean-tags: - rm -f TAGS ID -- 2.43.5