From 85933f336cbcfc58e2ca017d9bd6b897c9525025 Mon Sep 17 00:00:00 2001 From: Zdenek Kabelac Date: Tue, 23 Nov 2010 21:19:45 +0000 Subject: [PATCH] Add missing fclose Fixing resource leak in _umount(). CHECKME: mountpoints with spaces need to be checked --- WHATS_NEW | 1 + daemons/dmeventd/plugins/snapshot/dmeventd_snapshot.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/WHATS_NEW b/WHATS_NEW index 669ebd40b..d984b9bdd 100644 --- a/WHATS_NEW +++ b/WHATS_NEW @@ -1,5 +1,6 @@ Version 2.02.78 - ==================================== + Fix missing fclose for _umount() in dmeventd snapshot plugin. Fix out-of-scope variable usage in process_each_lv(). Fix dm_task_destroy(NULL) call in _node_clear_table() error path. Fix resource leak in _rm_blks(). diff --git a/daemons/dmeventd/plugins/snapshot/dmeventd_snapshot.c b/daemons/dmeventd/plugins/snapshot/dmeventd_snapshot.c index 00fc43622..6fc9f562a 100644 --- a/daemons/dmeventd/plugins/snapshot/dmeventd_snapshot.c +++ b/daemons/dmeventd/plugins/snapshot/dmeventd_snapshot.c @@ -170,6 +170,9 @@ static void _umount(const char *device, int major, int minor) device, words[1], strerror(errno)); } } + + if (fclose(mounts)) + syslog(LOG_ERR, "Failed to close /proc/mounts.\n"); } void process_event(struct dm_task *dmt, -- 2.43.5