From 81b1c8cbb5b486da60e81ba8435ddf08e554206a Mon Sep 17 00:00:00 2001 From: Samuel Thibault Date: Mon, 29 Jun 2020 10:09:14 +0200 Subject: [PATCH] hurd: Simplify usleep timeout computation as suggested by Andreas Schwab * sysdeps/mach/usleep.c (usleep): Divide timeout in an overflow-safe way. --- sysdeps/mach/usleep.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/sysdeps/mach/usleep.c b/sysdeps/mach/usleep.c index 75514b2e35..bb989e2733 100644 --- a/sysdeps/mach/usleep.c +++ b/sysdeps/mach/usleep.c @@ -27,16 +27,13 @@ usleep (useconds_t useconds) { mach_port_t recv; int cancel_oldtype; - useconds_t useconds_up = useconds + 999; - - if (useconds_up < useconds) - useconds_up = UINT32_MAX; + mach_msg_timeout_t timeout = useconds / 1000 + (useconds % 1000 != 0); recv = __mach_reply_port (); cancel_oldtype = LIBC_CANCEL_ASYNC(); (void) __mach_msg (NULL, MACH_RCV_MSG|MACH_RCV_TIMEOUT|MACH_RCV_INTERRUPT, - 0, 0, recv, useconds_up / 1000, MACH_PORT_NULL); + 0, 0, recv, timeout, MACH_PORT_NULL); LIBC_CANCEL_RESET (cancel_oldtype); __mach_port_destroy (mach_task_self (), recv); -- 2.43.5