From 80bb5935632faf8a8e94daf976340e549be9d4c5 Mon Sep 17 00:00:00 2001 From: "H.J. Lu" Date: Sun, 22 Oct 2017 08:07:48 -0700 Subject: [PATCH] x86-64: Add powf with FMA For workload-spec2017.wrf, on Skylake, it improves performance by: Before After Improvement reciprocal-throughput 35.4713 27.3842 29% latency 82.4537 66.3175 24% * sysdeps/x86_64/fpu/multiarch/Makefile (libm-sysdep_routines): Add e_powf-fma. (CFLAGS-e_powf-fma.c): New. * sysdeps/x86_64/fpu/multiarch/e_powf-fma.c: New file. * sysdeps/x86_64/fpu/multiarch/e_powf.c: Likewise. --- ChangeLog | 8 +++++ sysdeps/x86_64/fpu/multiarch/Makefile | 4 ++- sysdeps/x86_64/fpu/multiarch/e_powf-fma.c | 3 ++ sysdeps/x86_64/fpu/multiarch/e_powf.c | 43 +++++++++++++++++++++++ 4 files changed, 57 insertions(+), 1 deletion(-) create mode 100644 sysdeps/x86_64/fpu/multiarch/e_powf-fma.c create mode 100644 sysdeps/x86_64/fpu/multiarch/e_powf.c diff --git a/ChangeLog b/ChangeLog index 7e904dbdd4..28df1d25c6 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,11 @@ +2017-10-22 H.J. Lu + + * sysdeps/x86_64/fpu/multiarch/Makefile (libm-sysdep_routines): + Add e_powf-fma. + (CFLAGS-e_powf-fma.c): New. + * sysdeps/x86_64/fpu/multiarch/e_powf-fma.c: New file. + * sysdeps/x86_64/fpu/multiarch/e_powf.c: Likewise. + 2017-10-22 H.J. Lu * sysdeps/x86_64/fpu/multiarch/Makefile (libm-sysdep_routines): diff --git a/sysdeps/x86_64/fpu/multiarch/Makefile b/sysdeps/x86_64/fpu/multiarch/Makefile index 5338a6b41b..c78624b47d 100644 --- a/sysdeps/x86_64/fpu/multiarch/Makefile +++ b/sysdeps/x86_64/fpu/multiarch/Makefile @@ -37,12 +37,14 @@ CFLAGS-slowpow-fma.c = -mfma -mavx2 CFLAGS-s_sin-fma.c = -mfma -mavx2 CFLAGS-s_tan-fma.c = -mfma -mavx2 -libm-sysdep_routines += e_exp2f-fma e_expf-fma e_log2f-fma e_logf-fma +libm-sysdep_routines += e_exp2f-fma e_expf-fma e_log2f-fma e_logf-fma \ + e_powf-fma CFLAGS-e_exp2f-fma.c = -mfma -mavx2 CFLAGS-e_expf-fma.c = -mfma -mavx2 CFLAGS-e_log2f-fma.c = -mfma -mavx2 CFLAGS-e_logf-fma.c = -mfma -mavx2 +CFLAGS-e_powf-fma.c = -mfma -mavx2 libm-sysdep_routines += e_exp-fma4 e_log-fma4 e_pow-fma4 s_atan-fma4 \ e_asin-fma4 e_atan2-fma4 s_sin-fma4 s_tan-fma4 \ diff --git a/sysdeps/x86_64/fpu/multiarch/e_powf-fma.c b/sysdeps/x86_64/fpu/multiarch/e_powf-fma.c new file mode 100644 index 0000000000..fdf5dcc56a --- /dev/null +++ b/sysdeps/x86_64/fpu/multiarch/e_powf-fma.c @@ -0,0 +1,3 @@ +#define __powf __powf_fma + +#include diff --git a/sysdeps/x86_64/fpu/multiarch/e_powf.c b/sysdeps/x86_64/fpu/multiarch/e_powf.c new file mode 100644 index 0000000000..c110dbaffb --- /dev/null +++ b/sysdeps/x86_64/fpu/multiarch/e_powf.c @@ -0,0 +1,43 @@ +/* Multiple versions of powf. + Copyright (C) 2017 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +#define powf __redirect_powf +#define __DECL_SIMD___redirect_powf +#include +#undef powf + +#define SYMBOL_NAME powf +#include "ifunc-fma.h" + +libc_ifunc_redirected (__redirect_powf, __powf, IFUNC_SELECTOR ()); + +#ifdef SHARED +__hidden_ver1 (__powf, __GI___powf, __redirect_powf) + __attribute__ ((visibility ("hidden"))); + +# include +versioned_symbol (libm, __powf, powf, GLIBC_2_27); +#else +weak_alias (__powf, powf) +#endif + +strong_alias (__powf, __ieee754_powf) +strong_alias (__powf, __powf_finite) + +#define __powf __powf_sse2 +#include -- 2.43.5