From 79a9cb910a98e2c93c5df85fae6d03ed17019b08 Mon Sep 17 00:00:00 2001 From: Zdenek Kabelac Date: Tue, 23 Nov 2010 15:00:52 +0000 Subject: [PATCH] Move va_end(ap) so we do not leave with return -1 without calling it. Remove unneeded ';' --- libdm/libdm-string.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libdm/libdm-string.c b/libdm/libdm-string.c index d8fca1a90..365e7ec0d 100644 --- a/libdm/libdm-string.c +++ b/libdm/libdm-string.c @@ -144,6 +144,8 @@ int dm_asprintf(char **result, const char *format, ...) while (!ok) { va_start(ap, format); n = vsnprintf(buf, size, format, ap); + va_end(ap); + if (0 <= n && n < size) ok = 1; else { @@ -152,8 +154,7 @@ int dm_asprintf(char **result, const char *format, ...) buf = dm_malloc(size); if (!buf) return -1; - }; - va_end(ap); + } } *result = dm_strdup(buf); -- 2.43.5