From 6d0f09f4783061054152ae0013d7ebfad949c343 Mon Sep 17 00:00:00 2001 From: David Teigland Date: Mon, 29 Apr 2019 15:42:20 -0500 Subject: [PATCH] pvscan: remove fixme comment that is fixed Remove the fixme comment describing the case that was fixed by aa75b31db54782fb24b6b7e3c681a61b3579117c "pvscan: handle case of scanning PV without metadata last" --- tools/pvscan.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/tools/pvscan.c b/tools/pvscan.c index 61d9cc8ff..d3b2b8e5c 100644 --- a/tools/pvscan.c +++ b/tools/pvscan.c @@ -1062,18 +1062,6 @@ int pvscan_cache_cmd(struct cmd_context *cmd, int argc, char **argv) cmd->pvscan_recreate_hints = 1; pvscan_recreate_hints_begin(cmd); - /* - * FIXME: if _online_pvscan_all_devs scans a PV without - * metadata as the final PV to complete the VG, then - * that VG is not added to the complete_vgnames list. - * To fix this, we could also keep an incomplete_vg list, - * and each incomplete_vg entry would list the PVIDs it - * still needed. If a PV without metadata is scanned, - * its PVID would be removed from the incomplete_vg entry, - * and if the entry had no remaining PVs needed, the vgname - * would be added to complete_vgnames. - */ - log_verbose("pvscan all devices for requested refresh."); _online_files_remove(_pvs_online_dir); _online_files_remove(_vgs_online_dir); -- 2.43.5