From 5dab79f1c71deac521f4a5d412ba205e2a34b1a8 Mon Sep 17 00:00:00 2001 From: snitzer Date: Thu, 30 Jul 2009 17:18:03 +0000 Subject: [PATCH] Formalize pe_start policy as split between .pv_setup and .pv_write. Document existing pe_start policy. Fix issue in _text_pv_setup() where existing pe_start case could have the pv->pe_start set to pv->pe_align even though pe_start shouldn't ever change. vgconvert and pvcreate have a facility to preserve the existing start of the on-disk data extents, known as pe_start. They indicate this by passing the existing value to the pvsetup function which must preserve it. This patch avoids one particular case where the value could get changed incorrectly now that the alignment settings are configurable. Signed-off-by: Mike Snitzer --- WHATS_NEW | 1 + lib/format_text/format-text.c | 10 +++++++--- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/WHATS_NEW b/WHATS_NEW index 3293fde48..27568728c 100644 --- a/WHATS_NEW +++ b/WHATS_NEW @@ -1,5 +1,6 @@ Version 2.02.51 - ================================ + Formalize pe_start policy as split between .pv_setup and .pv_write. Document -I option of clvmd in the man page. Fix configure script to handle multiple clvmd selections. Fix lvm2app.pc installation filename. diff --git a/lib/format_text/format-text.c b/lib/format_text/format-text.c index d8e03f01d..a5e6664c6 100644 --- a/lib/format_text/format-text.c +++ b/lib/format_text/format-text.c @@ -1595,6 +1595,13 @@ static struct metadata_area_ops _metadata_text_raw_ops = { }; /* pvmetadatasize in sectors */ +/* + * pe_start policy: + * - In cases where a pre-existing pe_start is provided (pvcreate --restorefile + * and vgconvert): pe_start must not be changed (so pv->pe_start = pe_start). + * - In cases where pe_start is 0: leave pv->pe_start as 0 and defer the + * setting of pv->pe_start to .pv_write + */ static int _text_pv_setup(const struct format_type *fmt, uint64_t pe_start, uint32_t extent_count, uint32_t extent_size, unsigned long data_alignment, @@ -1702,9 +1709,6 @@ static int _text_pv_setup(const struct format_type *fmt, "%lu sectors (requested %lu sectors)", pv_dev_name(pv), pv->pe_align, data_alignment); - if (pv->pe_start < pv->pe_align) - pv->pe_start = pv->pe_align; - if (extent_count) pe_end = pe_start + extent_count * extent_size - 1; if (!_mda_setup(fmt, pe_start, pe_end, pvmetadatacopies, -- 2.43.5