From 52aa8cabe34d36e3b5b926bf9f0772ad2fb592ce Mon Sep 17 00:00:00 2001 From: Zdenek Kabelac Date: Mon, 25 Oct 2010 12:01:38 +0000 Subject: [PATCH] Print vg_name and do not to access vg->name Reported by clang as: Logic error Dereference of null pointer Replace pointer dereference with vg_name. --- WHATS_NEW | 1 + tools/pvresize.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/WHATS_NEW b/WHATS_NEW index 3dcdf6cdf..678ff87d4 100644 --- a/WHATS_NEW +++ b/WHATS_NEW @@ -1,5 +1,6 @@ Version 2.02.75 - ===================================== + Fix pointer for VG name in _pv_resize_single error code path. Fix warning for changed alignment requirements for dmeventd read/write func. Add global/metadata_read_only to use unrepaired metadata in read-only cmds. Don't take write lock in vgchange --refresh, --poll or --monitor. diff --git a/tools/pvresize.c b/tools/pvresize.c index ccd025a3d..af499e5bc 100644 --- a/tools/pvresize.c +++ b/tools/pvresize.c @@ -148,7 +148,7 @@ static int _pv_resize_single(struct cmd_context *cmd, if (!is_orphan_vg(vg_name)) { if (!vg_write(vg) || !vg_commit(vg)) { log_error("Failed to store physical volume \"%s\" in " - "volume group \"%s\"", pv_name, vg->name); + "volume group \"%s\"", pv_name, vg_name); goto out; } backup(vg); -- 2.43.5