From 4e8859d851cc94bf013925b23060346a0fde9cb7 Mon Sep 17 00:00:00 2001 From: Milan Broz Date: Wed, 31 Mar 2010 17:20:44 +0000 Subject: [PATCH] Remove vg_validate call when parsing cached metadata. vg_validate call is an adept to optimisation, it is very ineeficient and slow. Anyway, we should call it only before writing data to disk. The call in lvmcache was just temporary validation, we realy do not need to revalidate cached metadata every time. (Actually, I added that there just to prove that cache works properly and forgot to remove it.) Patch removes it from lvmcache completely, this can hit only internal bug in export function (and this bug must be detected in any vg_write call anyway before). --- WHATS_NEW | 1 + lib/cache/lvmcache.c | 3 +-- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/WHATS_NEW b/WHATS_NEW index 3ecbd27fc..563eb95e8 100644 --- a/WHATS_NEW +++ b/WHATS_NEW @@ -1,5 +1,6 @@ Version 2.02.63 - ================================ + Remove vg_validate call when parsing cached metadata. Use hash table of LVs to speed up parsing of text metadata with many LVs. Fix two messages, add a whitespace and parentheses When dmeventd is not forking because of -d flag, don't kill the parent process diff --git a/lib/cache/lvmcache.c b/lib/cache/lvmcache.c index 0ce034a79..9caa216bf 100644 --- a/lib/cache/lvmcache.c +++ b/lib/cache/lvmcache.c @@ -610,8 +610,7 @@ struct volume_group *lvmcache_get_vg(const char *vgid, unsigned precommitted) vgid, NULL))) return_NULL; - if (!(vg = import_vg_from_buffer(vginfo->vgmetadata, fid)) || - !vg_validate(vg)) { + if (!(vg = import_vg_from_buffer(vginfo->vgmetadata, fid))) { _free_cached_vgmetadata(vginfo); vg_release(vg); return_NULL; -- 2.43.5