From 458baea830d900ddb36bef0df3cef0ada7b20372 Mon Sep 17 00:00:00 2001 From: Dave Wysochanski Date: Sun, 26 Jul 2009 02:02:22 +0000 Subject: [PATCH] Remove use of void * from pvcreate_single. We should use struct pvcreate_params to utilize compiler typechecking. Author: Dave Wysochanski --- lib/metadata/metadata-exported.h | 2 +- lib/metadata/metadata.c | 7 ++----- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/lib/metadata/metadata-exported.h b/lib/metadata/metadata-exported.h index aa096ef94..0ebb08398 100644 --- a/lib/metadata/metadata-exported.h +++ b/lib/metadata/metadata-exported.h @@ -355,7 +355,7 @@ struct pvcreate_params { }; pv_t * pvcreate_single(struct cmd_context *cmd, const char *pv_name, - void *handle); + struct pvcreate_params *pp); /* * Utility functions diff --git a/lib/metadata/metadata.c b/lib/metadata/metadata.c index 4031ea68c..8e96e89f6 100644 --- a/lib/metadata/metadata.c +++ b/lib/metadata/metadata.c @@ -1119,19 +1119,16 @@ static void fill_default_pvcreate_params(struct pvcreate_params *pp) * pv_t * (non-NULL): handle to physical volume created */ pv_t * pvcreate_single(struct cmd_context *cmd, const char *pv_name, - void *handle) + struct pvcreate_params *pp) { - struct pvcreate_params *pp; void *pv; struct device *dev; struct dm_list mdas; struct pvcreate_params default_pp; fill_default_pvcreate_params(&default_pp); - if (!handle) + if (!pp) pp = &default_pp; - else - pp = (struct pvcreate_params *) handle; if (pp->idp) { if ((dev = device_from_pvid(cmd, pp->idp)) && -- 2.43.5