From 42f7fd0590ad792ee865f0259e5f6a95b42e3357 Mon Sep 17 00:00:00 2001 From: Jonathan Earl Brassow Date: Wed, 23 Jun 2010 13:57:26 +0000 Subject: [PATCH] The function that runs to compress a stacked mirror after converting from 2-way to 3-way mirror (collapse_mirrored_lv) was calling '_remove_mirror_images' with the 'remove_log' parameter set. When the code was put in to fix 599898 to honor log parameters during conversion, this argument was suddenly being honored. Thus, when someone would convert from a 2-way to 3-way mirror, the log would get removed. 'collapse_mirrored_lv' should not be calling '_remove_mirror_images' with 'remove_log' set. --- lib/metadata/mirror.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/metadata/mirror.c b/lib/metadata/mirror.c index 50082578b..08ba85568 100644 --- a/lib/metadata/mirror.c +++ b/lib/metadata/mirror.c @@ -1038,7 +1038,7 @@ int collapse_mirrored_lv(struct logical_volume *lv) if (!_remove_mirror_images(mirror_seg->lv, mirror_seg->area_count - 1, - _no_removable_images, NULL, 1, 1, NULL)) { + _no_removable_images, NULL, 0, 1, NULL)) { log_error("Failed to release mirror images"); return 0; } -- 2.43.5