From 3dab1e488aae1787e1ada0bfbda2fb71bd449687 Mon Sep 17 00:00:00 2001 From: Corinna Vinschen Date: Wed, 9 Jul 2014 10:41:11 +0000 Subject: [PATCH] * exceptions.cc (exception::myfault_handle): Rephrase comment. --- winsup/cygwin/ChangeLog | 4 ++++ winsup/cygwin/exceptions.cc | 5 ++++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/winsup/cygwin/ChangeLog b/winsup/cygwin/ChangeLog index 82fc1d366..d940017fe 100644 --- a/winsup/cygwin/ChangeLog +++ b/winsup/cygwin/ChangeLog @@ -1,3 +1,7 @@ +2014-07-09 Corinna Vinschen + + * exceptions.cc (exception::myfault_handle): Rephrase comment. + 2014-07-09 Corinna Vinschen * exceptions.cc (exception::myfault_handle): Fix typo in comment. diff --git a/winsup/cygwin/exceptions.cc b/winsup/cygwin/exceptions.cc index 60cef57ab..0e8a977d4 100644 --- a/winsup/cygwin/exceptions.cc +++ b/winsup/cygwin/exceptions.cc @@ -564,7 +564,10 @@ exception::myfault_handle (LPEXCEPTION_POINTERS ep) case STATUS_ACCESS_VIOLATION: case STATUS_DATATYPE_MISALIGNMENT: #if 0 - /* Short-circuiting STATUS_STACK_OVERFLOW disables stack commits. */ + /* PAGE_GUARD-based stack commits are based on structured exception + handling. Short-circuiting STATUS_STACK_OVERFLOW in a vectored + exception handler disables that, which can ultimately result in + a spurious SEGV. */ case STATUS_STACK_OVERFLOW: #endif case STATUS_ARRAY_BOUNDS_EXCEEDED: -- 2.43.5