From 3b93574beb071ed7354d8db04754c3f8f752fec7 Mon Sep 17 00:00:00 2001 From: Giuliano Procida Date: Thu, 9 Jul 2020 14:14:28 +0100 Subject: [PATCH] Remove unused is_reference_or_pointer_diff. The function is_reference_or_pointer_diff was added in commit 85929105 Fix redundancy marking for change of types used directly and was updated to peel typedefs as a first step in ef9d20c9 Fix redundancy detection through fn ptr and typedef paths which, however, also made it obsolete. This commit removes the function's declaration and definition. There are no functional changes. * include/abg-comparison.h (is_reference_or_pointer_diff): Drop function declaration. * src/abg-comparison.cc (is_reference_or_pointer_diff): Drop function definition. Signed-off-by: Giuliano Procida --- include/abg-comparison.h | 2 -- src/abg-comparison.cc | 15 --------------- 2 files changed, 17 deletions(-) diff --git a/include/abg-comparison.h b/include/abg-comparison.h index 84258209..c4eb5925 100644 --- a/include/abg-comparison.h +++ b/include/abg-comparison.h @@ -2852,8 +2852,6 @@ is_reference_diff(const diff* diff); const qualified_type_diff* is_qualified_type_diff(const diff* diff); -bool -is_reference_or_pointer_diff(const diff* diff); const fn_parm_diff* is_fn_parm_diff(const diff* diff); diff --git a/src/abg-comparison.cc b/src/abg-comparison.cc index 636a4737..7f91753a 100644 --- a/src/abg-comparison.cc +++ b/src/abg-comparison.cc @@ -788,21 +788,6 @@ const qualified_type_diff* is_qualified_type_diff(const diff* diff) {return dynamic_cast(diff);} -/// Test if a diff node is either a reference diff node or a pointer -/// diff node. Note that this function also works on diffs of -/// typedefs of reference or pointer. -/// -/// @param diff the diff node to test. -/// -/// @return true iff @p diff is either reference diff node or a -/// pointer diff node. -bool -is_reference_or_pointer_diff(const diff* diff) -{ - diff = peel_typedef_diff(diff); - return is_reference_diff(diff) || is_pointer_diff(diff); -} - /// Test if a diff node is a reference or pointer diff node to a /// change that is neither basic type change nor distinct type change. /// -- 2.43.5