From 2496a3637f4bcb5617c661ef33e3e1a1cc5e93c1 Mon Sep 17 00:00:00 2001 From: Christopher Faylor Date: Sat, 1 Sep 2001 05:38:46 +0000 Subject: [PATCH] * tty.cc (tty::create_inuse): Eliminate unneeded argument. * tty.h: Reflect above change. * fhandler_tty.cc: Reflect argument reduction in tty::create_inuse, throughout. Always make inuse inheritable. --- winsup/cygwin/ChangeLog | 7 +++++++ winsup/cygwin/fhandler_tty.cc | 6 +++--- winsup/cygwin/tty.cc | 4 ++-- winsup/cygwin/tty.h | 2 +- 4 files changed, 13 insertions(+), 6 deletions(-) diff --git a/winsup/cygwin/ChangeLog b/winsup/cygwin/ChangeLog index aa491eabb..c661e8ba8 100644 --- a/winsup/cygwin/ChangeLog +++ b/winsup/cygwin/ChangeLog @@ -1,3 +1,10 @@ +Sat Sep 1 01:37:13 2001 Christopher Faylor + + * tty.cc (tty::create_inuse): Eliminate unneeded argument. + * tty.h: Reflect above change. + * fhandler_tty.cc: Reflect argument reduction in tty::create_inuse, + throughout. Always make inuse inheritable. + Sat Sep 1 01:10:07 2001 Christopher Faylor * debug.cc (mark_closed): Rename from debug_mark_closed and make diff --git a/winsup/cygwin/fhandler_tty.cc b/winsup/cygwin/fhandler_tty.cc index dc6c3d396..d5c5f739b 100644 --- a/winsup/cygwin/fhandler_tty.cc +++ b/winsup/cygwin/fhandler_tty.cc @@ -62,7 +62,7 @@ fhandler_tty_master::init (int ntty) cygwin_shared->tty[ttynum]->common_init (this); - inuse = get_ttyp ()->create_inuse (TTY_MASTER_ALIVE, FALSE); + inuse = get_ttyp ()->create_inuse (TTY_MASTER_ALIVE); h = makethread (process_input, NULL, 0, "ttyin"); if (h == NULL) @@ -509,7 +509,7 @@ fhandler_tty_slave::open (const char *, int flags, mode_t) /* FIXME: Needs a method to eliminate tty races */ { acquire_output_mutex (500); - inuse = get_ttyp ()->create_inuse (TTY_SLAVE_ALIVE, TRUE); + inuse = get_ttyp ()->create_inuse (TTY_SLAVE_ALIVE); get_ttyp ()->was_opened = TRUE; release_output_mutex (); } @@ -972,7 +972,7 @@ fhandler_pty_master::open (const char *, int flags, mode_t) return 0; cygwin_shared->tty[ttynum]->common_init (this); - inuse = get_ttyp ()->create_inuse (TTY_MASTER_ALIVE, FALSE); + inuse = get_ttyp ()->create_inuse (TTY_MASTER_ALIVE); set_flags (flags); set_open_status (); diff --git a/winsup/cygwin/tty.cc b/winsup/cygwin/tty.cc index ee31b193b..613aa2969 100644 --- a/winsup/cygwin/tty.cc +++ b/winsup/cygwin/tty.cc @@ -301,13 +301,13 @@ tty::alive (const char *fmt) } HANDLE -tty::create_inuse (const char *fmt, BOOL inherit) +tty::create_inuse (const char *fmt) { HANDLE h; char buf[sizeof (TTY_MASTER_ALIVE) + 16]; __small_sprintf (buf, fmt, ntty); - h = CreateEvent ((inherit ? &sec_all : &sec_all_nih), TRUE, FALSE, buf); + h = CreateEvent (&sec_all, TRUE, FALSE, buf); termios_printf ("%s = %p", buf, h); if (!h) termios_printf ("couldn't open inuse event, %E", buf); diff --git a/winsup/cygwin/tty.h b/winsup/cygwin/tty.h index 0730e51a9..a081502c1 100644 --- a/winsup/cygwin/tty.h +++ b/winsup/cygwin/tty.h @@ -100,7 +100,7 @@ public: BOOL was_opened; /* True if opened at least once. */ void init (); - HANDLE create_inuse (const char *, BOOL); + HANDLE create_inuse (const char *); BOOL common_init (fhandler_pty_master *); BOOL alive (const char *fmt); BOOL slave_alive (); -- 2.43.5