From 1f84f09381a7546b94bc61d0c800634f8889831c Mon Sep 17 00:00:00 2001 From: Alasdair Kergon Date: Tue, 4 Jul 2006 19:52:47 +0000 Subject: [PATCH] Differentiate between the two 'log device failed' cases in vgreduce. --- tools/vgreduce.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/tools/vgreduce.c b/tools/vgreduce.c index fe8eb4c4f..0c6d8f776 100644 --- a/tools/vgreduce.c +++ b/tools/vgreduce.c @@ -286,13 +286,18 @@ static int _make_vg_consistent(struct cmd_context *cmd, struct volume_group *vg) list_iterate_items(seg, &mirrored_seg->log_lv->segments) { /* FIXME: The second test shouldn't be required */ if ((seg->segtype == - get_segtype_from_string(vg->cmd, "error")) || - (!strcmp(seg->segtype->name, "error"))) { + get_segtype_from_string(vg->cmd, "error"))) { log_print("The log device for %s/%s has failed.", vg->name, mirrored_seg->lv->name); remove_log = 1; break; } + if (!strcmp(seg->segtype->name, "error")) { + log_print("Log device for %s/%s has failed.", + vg->name, mirrored_seg->lv->name); + remove_log = 1; + break; + } } } -- 2.43.5