From 1d67c9393558047bb939f0041a06f16cfc22ab63 Mon Sep 17 00:00:00 2001 From: "Frank Ch. Eigler" Date: Thu, 5 Dec 2013 11:32:24 -0500 Subject: [PATCH] runtime: don't require CONFIG_KPROBES for user-space backtraces * runtime/stack.c: Drop an unnecessary #ifdef CONFIG_KPROBES that wrapped even pure-userspace stack-unwinding-related code, and caused unnecessary -p4 failures. Reported-By: calcifer_ on irc.freenode.net --- runtime/stack.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/runtime/stack.c b/runtime/stack.c index aaa3ec54b..a467c88f1 100644 --- a/runtime/stack.c +++ b/runtime/stack.c @@ -161,10 +161,6 @@ static void _stp_stack_print_fallback(unsigned long s, int v, int l, int k) { #endif /* defined(STAPCONF_KERNEL_STACKTRACE) || defined(STAPCONF_KERNEL_STACKTRACE_NO_BP) */ -// Without KPROBES very little works atm. -// But this file is unconditionally imported, while these two functions are only -// used through context-unwind.stp. -#if defined (CONFIG_KPROBES) /** Gets user space registers when available, also sets context * full_uregs_p if appropriate. Should be used instead of accessing @@ -638,6 +634,4 @@ static void _stp_stack_user_sprint(char *str, int size, struct context* c, pb->len = 0; } -#endif /* CONFIG_KPROBES */ - #endif /* _STACK_C_ */ -- 2.43.5