From 0db2d39105cf8c9e0d3d5da61fb5c7b6e559a2b1 Mon Sep 17 00:00:00 2001 From: Mike Snitzer Date: Fri, 28 Jan 2011 02:58:00 +0000 Subject: [PATCH] Improve lvcreate "insufficient extents" errors to "insufficient free space". --- WHATS_NEW | 1 + lib/metadata/lv_manip.c | 7 ++++--- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/WHATS_NEW b/WHATS_NEW index ab682c3c8..1ab991b16 100644 --- a/WHATS_NEW +++ b/WHATS_NEW @@ -1,6 +1,7 @@ Version 2.02.83 - =================================== Always use O_DIRECT when opening block devices to check for partitioning. + Improve lvcreate "insufficient extents" errors to "insufficient free space". Version 2.02.82 - 24th January 2011 =================================== diff --git a/lib/metadata/lv_manip.c b/lib/metadata/lv_manip.c index 6f7d0bef5..f6bb68c27 100644 --- a/lib/metadata/lv_manip.c +++ b/lib/metadata/lv_manip.c @@ -1481,7 +1481,7 @@ static int _allocate(struct alloc_handle *ah, } if (log_needs_allocating) { - log_error("Insufficient extents for log allocation " + log_error("Insufficient free space for log allocation " "for logical volume %s.", lv ? lv->name : ""); goto out; @@ -3232,8 +3232,9 @@ int lv_create_single(struct volume_group *vg, if (!seg_is_virtual(lp) && vg->free_count < lp->extents) { - log_error("Insufficient free extents (%u) in volume group %s: " - "%u required", vg->free_count, vg->name, lp->extents); + log_error("Volume group \"%s\" has insufficient free space " + "(%u extents): %u required.", + vg->name, vg->free_count, lp->extents); return 0; } -- 2.43.5