From 08df2e23a75190fced8c1a2446ebaee4f469eb96 Mon Sep 17 00:00:00 2001 From: Corinna Vinschen Date: Sat, 24 Feb 2024 10:46:54 +0100 Subject: [PATCH] Cygwin: newgrp: fix invalid usage of argv Fix an error message accessing argv[1] even after it has been potentially moved. Print group name from group DB instead. Fixes: 8bd56ec873453 ("Cygwin: newgrp: first full version") Signed-off-by: Corinna Vinschen --- winsup/utils/newgrp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/winsup/utils/newgrp.c b/winsup/utils/newgrp.c index 88586352e..e312a3c51 100644 --- a/winsup/utils/newgrp.c +++ b/winsup/utils/newgrp.c @@ -160,6 +160,7 @@ main (int argc, const char **argv) if (argv[1] == NULL) { gid = pw->pw_gid; + gr = getgrgid (gid); } else { @@ -179,7 +180,7 @@ main (int argc, const char **argv) if (setgid (gid) != 0) { fprintf (stderr, "%s: can't switch primary group to '%s'\n", - program_invocation_short_name, argv[1]); + program_invocation_short_name, gr->gr_name); return 2; } -- 2.43.5