]> sourceware.org Git - glibc.git/commit
Fix segfault in maybe_script_execute.
authorStefan Liebler <stli@linux.ibm.com>
Thu, 6 Sep 2018 12:27:03 +0000 (14:27 +0200)
committerStefan Liebler <stli@linux.ibm.com>
Thu, 6 Sep 2018 12:27:03 +0000 (14:27 +0200)
commit28669f86f6780a18daca264f32d66b1428c9c6f1
tree5d84685410e38ea533838ad1785ad4d037b302a5
parenta33650d1a63b4e5d52ef02bb629d045c217e16ff
Fix segfault in maybe_script_execute.

If glibc is built with gcc 8 and -march=z900,
the testcase posix/tst-spawn4-compat crashes with a segfault.

In function maybe_script_execute, the new_argv array is dynamically
initialized on stack with (argc + 1) elements.
The function wants to add _PATH_BSHELL as the first argument
and writes out of bounds of new_argv.
There is an off-by-one because maybe_script_execute fails to count
the terminating NULL when sizing new_argv.

ChangeLog:

* sysdeps/unix/sysv/linux/spawni.c (maybe_script_execute):
Increment size of new_argv by one.
ChangeLog
sysdeps/unix/sysv/linux/spawni.c
This page took 0.037385 seconds and 5 git commands to generate.