]>
sourceware.org Git - lvm2.git/log
Marian Csontos [Thu, 16 May 2024 10:12:06 +0000 (12:12 +0200)]
post-release
Marian Csontos [Thu, 16 May 2024 10:12:06 +0000 (12:12 +0200)]
pre-release
Marian Csontos [Thu, 21 Dec 2023 12:48:50 +0000 (13:48 +0100)]
pages: Use gitlab pages and ikiwiki for doc
Marian Csontos [Thu, 16 May 2024 09:16:21 +0000 (11:16 +0200)]
doc: Update TESTING file
Zdenek Kabelac [Tue, 14 May 2024 14:54:00 +0000 (16:54 +0200)]
makefiles: use properly defined varitable
Variable used for tracking dependencies is USE_TRACKING.
Zdenek Kabelac [Tue, 14 May 2024 15:47:33 +0000 (17:47 +0200)]
tests: add basics for dm_hash unit testing
Better code coverage.
Zdenek Kabelac [Tue, 14 May 2024 15:45:49 +0000 (17:45 +0200)]
gcc: clean cast with -Wbad-function-cast
Makes gcc happier.
Zdenek Kabelac [Tue, 14 May 2024 13:36:34 +0000 (15:36 +0200)]
gcc: same signess
Zdenek Kabelac [Tue, 14 May 2024 13:35:07 +0000 (15:35 +0200)]
gcc: use proper commnent
Zdenek Kabelac [Mon, 13 May 2024 20:47:36 +0000 (22:47 +0200)]
gcc: better initilizer for older gcc compilers
So use { { } }.
Zdenek Kabelac [Mon, 13 May 2024 21:19:15 +0000 (23:19 +0200)]
activation: log_debug_activation
Correcting debug class.
Zdenek Kabelac [Mon, 13 May 2024 16:00:52 +0000 (18:00 +0200)]
tests: reduce number of created LVs
lvm2 for a while already optimizes 'vgremove' operation to
a single commit when possible if all LVs can be
easily deactivated.
So the number of LVs doesn't matter much - but the tested
case 'test_delete_non_complete_job' seems to be taking
some time anyway to capture the exception.
So just reducing the running time of the test significatanly
as we don't need to create 64LVs for 4 'execution mode' runs.
Zdenek Kabelac [Mon, 13 May 2024 15:29:15 +0000 (17:29 +0200)]
cov: ensure pointer has defined value
Add initialization of 'fin' pointer.
Zdenek Kabelac [Mon, 13 May 2024 15:13:08 +0000 (17:13 +0200)]
dmfilemapd: assign 0 to integer
Avoid mixing enumeration assign with 0, so just pick some integer
from filemap_monitor, stucture will be fully zeroed anyway....
Zdenek Kabelac [Mon, 13 May 2024 15:04:48 +0000 (17:04 +0200)]
libdevmapper-event: correct switch break
Replace 'continue' within 'switch' statement with correct break.
David Teigland [Mon, 13 May 2024 14:15:42 +0000 (09:15 -0500)]
man: lvmlockd: remove dash in option name
for consistency with other man pages
Zdenek Kabelac [Mon, 13 May 2024 12:49:54 +0000 (14:49 +0200)]
lvmcmdline: check for NULL
Althought this code likely never is hit with NULL, just add
check to be sure.
Zdenek Kabelac [Mon, 13 May 2024 12:48:46 +0000 (14:48 +0200)]
cov: enusure _table doesn't leak
If someone would enter _table multiple times by mistatek,
there is 'teroretical' leak - although doesn't matter much
in this case...
Zdenek Kabelac [Mon, 13 May 2024 10:43:05 +0000 (12:43 +0200)]
make: generate
Zdenek Kabelac [Mon, 13 May 2024 10:00:59 +0000 (12:00 +0200)]
lv_types: sort order of types
Order is used for man page generation (although not completely).
So place 'zero & error' to the end of list.
Keep linear,striped,snapshot in front.
For the rest use alphabetic order.
Zdenek Kabelac [Mon, 13 May 2024 09:36:54 +0000 (11:36 +0200)]
cleanup: local const arrays
No need for relocation entries for locally used arrays.
Zdenek Kabelac [Mon, 13 May 2024 09:33:17 +0000 (11:33 +0200)]
cleanup: static missed _
Zdenek Kabelac [Mon, 13 May 2024 09:21:37 +0000 (11:21 +0200)]
cleanup: remove unuable code path
Eliminate some ancient unreachable code
for historical version of libdm.
Zdenek Kabelac [Mon, 13 May 2024 09:18:20 +0000 (11:18 +0200)]
cleanup: some missed public symbols static
Zdenek Kabelac [Sun, 12 May 2024 23:49:00 +0000 (01:49 +0200)]
label: make scan_bcache local
Seems there are no users of scan_bcache, so make it local.
TODO: such variable should be ideally in cmd_context.
Zdenek Kabelac [Sun, 12 May 2024 23:37:27 +0000 (01:37 +0200)]
cleanup: drop unused declared struct
Zdenek Kabelac [Mon, 13 May 2024 00:10:08 +0000 (02:10 +0200)]
cleanup: use static vars
Drop global visibility.
Zdenek Kabelac [Sun, 12 May 2024 22:04:28 +0000 (00:04 +0200)]
cleanup: add static _
Zdenek Kabelac [Sun, 12 May 2024 23:11:05 +0000 (01:11 +0200)]
lv_type: simplier macro usage
Use more simple macros - as there is likely not going to happen
any macro replacement - so use more effient structure layout.
Zdenek Kabelac [Sun, 12 May 2024 23:01:18 +0000 (01:01 +0200)]
lv_prop: simplier macro usage
Use more simple macros - as there is likely not going to happen
any macro replacement - so use more effient structure layout.
Zdenek Kabelac [Sun, 12 May 2024 20:07:58 +0000 (22:07 +0200)]
command: validation code only for man-generator
Don't waste time with string order validation within command,
check within 'man-generator -c' is enough.
Zdenek Kabelac [Sun, 12 May 2024 16:29:31 +0000 (18:29 +0200)]
command: refactor inner loop
Move part of the 'inner' loop which is would be otherwise
always production same results for all 'opt_enum' values
out of the loop, so it can be evaluated just once.
Zdenek Kabelac [Sun, 12 May 2024 15:12:19 +0000 (17:12 +0200)]
command: replace strcmp with enum
Here we already know 'enum' value, so compare
just those instead of calling strcmp().
Zdenek Kabelac [Sun, 12 May 2024 14:46:02 +0000 (16:46 +0200)]
lvmcmdline: runtime function resolving
Instead of resolving and storing 'command_fn'
withing 'struct command' use just funtion enum
and resolve function pointer just in place,
where it is really needed - first try to resolve
'new style' and fallback to 'old style' named.
Zdenek Kabelac [Sun, 12 May 2024 14:00:48 +0000 (16:00 +0200)]
command: use command_id_to_enum
Instead of storing command_id as string, direcly
translate string to enum index and use 'command_enum()'
to get string when needed for printing.
This way we can easily detect error in the structure
while parsing it - and we can later avoid separate
'translation' loop.
Zdenek Kabelac [Sun, 12 May 2024 13:39:18 +0000 (15:39 +0200)]
command: refactor code for simplier lookup
We can more efficiently use command_name struct to
lookup for lvm_command_enum and avoid many repeated
command name searches since we already know
the enum index that is now stored in 'struct command'.
Zdenek Kabelac [Sun, 12 May 2024 10:04:54 +0000 (12:04 +0200)]
lvmcmdline: use strcut as const
Constity members in cmdline_context, would be nice, to replace
this static struct with couple function calls.
Also replace some 'while' loops with for loops, so code
is more readable.
Zdenek Kabelac [Sun, 12 May 2024 08:17:11 +0000 (10:17 +0200)]
command: return if already factored
We can directly return here, when we spot already counted varitants.
Zdenek Kabelac [Sat, 11 May 2024 23:14:14 +0000 (01:14 +0200)]
command: refactor struct command_name
Split struct command_name to the constant part (keep the name)
and new 'struct command_name_args' which holds runtime computed
info. To get to the _args part - we can easily use
lvm_command_enum as equivalent index.
Constified part 'struct command_name' is now fully stored
in .data.rel.ro segment, while command_name_args part goes
to .bss segment.
Code will be further reduced with next refactoring.
Zdenek Kabelac [Sat, 11 May 2024 20:27:36 +0000 (22:27 +0200)]
command: better const usage for struct cmd_name
No need to store _CMD string - as it's not used anywhere.
Use LVM_COMMAND_COUNT as end of array.
Zdenek Kabelac [Sat, 11 May 2024 20:00:42 +0000 (22:00 +0200)]
command: reduce struct size
Reduce memory usage for parser.
If the sizes would need to be bigger, man-generator warns.
For struct command_name use just uint8_t to keep 1|0.
Zdenek Kabelac [Sat, 11 May 2024 19:59:48 +0000 (21:59 +0200)]
command: no need to duplicate const mem
No need to duplicate const char* here as
we refer already constant string in .rodata segment.
Zdenek Kabelac [Fri, 10 May 2024 22:42:49 +0000 (00:42 +0200)]
command: futher move to single struct
Refactor code to not allocate memory for rule->opts,
instead use uint16_t array of MAX_RULE_OPTS within cmd_rule.
Also print more info if array would not be enough (>= 8).
Zdenek Kabelac [Fri, 10 May 2024 20:04:06 +0000 (22:04 +0200)]
tests: check vg fields with one command
Zdenek Kabelac [Fri, 10 May 2024 19:42:00 +0000 (21:42 +0200)]
tests: keep more LVs inactive
Zdenek Kabelac [Fri, 10 May 2024 19:41:13 +0000 (21:41 +0200)]
tests: mask result from kill command
Zdenek Kabelac [Fri, 10 May 2024 15:48:47 +0000 (17:48 +0200)]
tests: wait for running dmeventd
Add slight delay for waiting until 'started' dmeventd is
responsing to other 'dmeventd -i' command.
TODO: race observed here is somewhat unclear, might need some more
details
Zdenek Kabelac [Fri, 10 May 2024 15:36:48 +0000 (17:36 +0200)]
tests: kill process in flock group
There is no reason to wait for 10sec when removing 'vg' at test
exit - we just need to kill 'sleep 10' process forked from flock.
(Not using 'flock -F' as this flag is not across all machines used
for testing)
Zdenek Kabelac [Fri, 10 May 2024 15:35:07 +0000 (17:35 +0200)]
tests: skip test on systems without delay_dev
On such systems this test only sleeps for 30sec.
Zdenek Kabelac [Fri, 10 May 2024 11:53:11 +0000 (13:53 +0200)]
libdm: reapply "fix condition"
This reverts commit
d16a8f80e9dd21d97b10056858a21b7e8fbd8c94 .
So the correction was OK, however we missed to fix also
cut&paste bug here - as the second check should be
actually checking field->type.
Zdenek Kabelac [Thu, 9 May 2024 23:08:55 +0000 (01:08 +0200)]
WHATS_NEW: update
Zdenek Kabelac [Thu, 9 May 2024 12:16:07 +0000 (14:16 +0200)]
make: generate
Zdenek Kabelac [Thu, 9 May 2024 22:24:23 +0000 (00:24 +0200)]
tests: vdo conversion updates
Zdenek Kabelac [Thu, 9 May 2024 12:05:24 +0000 (14:05 +0200)]
commands: move tabs to eol
Make the source code a bit easier to read.
Zdenek Kabelac [Thu, 9 May 2024 12:15:45 +0000 (14:15 +0200)]
commands: enable more options for vdo conversion
Update definitions to add support for some more VDO options
when converting volumes to be used as thin-pool with vdo data volume.
Split some option in existing OO_LVCONVERT_VDO to OO_LVCONVERT_VDO_POOL
and reused then with OO_LVCONVERT_THINPOOL.
Zdenek Kabelac [Thu, 9 May 2024 22:26:29 +0000 (00:26 +0200)]
lvconvert: vdo support conversion options
When convert already existing vdopool to be used as
thin-pool backend and user is passinng option for VDO configuration
process them - as we know converted LV is offline, we can do such
change easily instead of telling user to run separate lvchange later.
Zdenek Kabelac [Thu, 9 May 2024 22:25:39 +0000 (00:25 +0200)]
lvconvert: vdo control for signature wiping
When converting volumes to be used for thin-pool with VDO, allow
users to control wipesingature behaviour.
By default volumes should be checked against signature, and if
they are present, we promt user whether he wants to process with
conversion and lose i.e. filesystem present on such volume.
Users that want to bypass prompt in script can use either --yes
or they can disable wipe signature -Wn.
David Teigland [Wed, 8 May 2024 15:29:22 +0000 (10:29 -0500)]
man: lvmthin more extend options
Zdenek Kabelac [Wed, 8 May 2024 14:02:44 +0000 (16:02 +0200)]
tests: runner updates line with last timestamp
Zdenek Kabelac [Wed, 8 May 2024 12:24:21 +0000 (14:24 +0200)]
clean: use struct initializer
Zdenek Kabelac [Wed, 8 May 2024 12:35:20 +0000 (14:35 +0200)]
dmsetup: const string_args array
Convert _string_args to const char*.
Do not modify options read from getopt().
Zdenek Kabelac [Wed, 8 May 2024 12:19:17 +0000 (14:19 +0200)]
dmsetup: use tab for indent
Use \t for help indention.
Zdenek Kabelac [Wed, 8 May 2024 12:14:27 +0000 (14:14 +0200)]
dmsetup: more const strings
More strings into .rodata segment.
Zdenek Kabelac [Wed, 8 May 2024 12:04:12 +0000 (14:04 +0200)]
dmsetup: reduce parser code
Switch set upfront.
Only add code, which is not common for every switch.
Use just 16bit for switch counting.
Zdenek Kabelac [Wed, 8 May 2024 07:54:30 +0000 (09:54 +0200)]
libdm: fix invalid conversion
Previous commit missed to also add one to added 'len'.
Zdenek Kabelac [Wed, 8 May 2024 07:36:39 +0000 (09:36 +0200)]
libdm: stats uses overflowing counter
Here we need to annotate counter as it starts with UINT64_MAX
and overflows to 0 is expected.
Zdenek Kabelac [Tue, 7 May 2024 23:15:33 +0000 (01:15 +0200)]
clenaup: update local static with _
Zdenek Kabelac [Tue, 7 May 2024 20:06:35 +0000 (22:06 +0200)]
const: tests
Zdenek Kabelac [Mon, 6 May 2024 21:56:47 +0000 (23:56 +0200)]
man-generator: remove unused declarations
Zdenek Kabelac [Tue, 7 May 2024 13:25:32 +0000 (15:25 +0200)]
cov: remove dead code
Zdenek Kabelac [Tue, 7 May 2024 13:21:19 +0000 (15:21 +0200)]
cov: eliminate dead code
Deduplicate code and also drop some warn about dead code.
Zdenek Kabelac [Tue, 7 May 2024 12:48:55 +0000 (14:48 +0200)]
cov: avoid TOCTOU
Use just opendir() call and produce error message from errno state.
Zdenek Kabelac [Tue, 7 May 2024 15:19:55 +0000 (17:19 +0200)]
cov: enum mapping cache format
Cleanly map cache metadata format enumeration.
Zdenek Kabelac [Tue, 7 May 2024 14:33:03 +0000 (16:33 +0200)]
cov: enum health status
Cleanly map health char status to enum.
Zdenek Kabelac [Tue, 7 May 2024 14:27:08 +0000 (16:27 +0200)]
cov: enum matching type
Zdenek Kabelac [Tue, 7 May 2024 11:58:21 +0000 (13:58 +0200)]
cov: enum correct prototype
Cleanup enum usage.
Zdenek Kabelac [Tue, 7 May 2024 11:38:10 +0000 (13:38 +0200)]
cov: cast to matching prototype
Match function prototype with casting.
Zdenek Kabelac [Tue, 7 May 2024 11:24:01 +0000 (13:24 +0200)]
cov: check for overlow math
Add some extre protection to avoid integer overflow type of problems.
Zdenek Kabelac [Mon, 6 May 2024 21:59:59 +0000 (23:59 +0200)]
cov: annotate to silent some coverity warning
Zdenek Kabelac [Mon, 6 May 2024 20:46:09 +0000 (22:46 +0200)]
cov: use literal for printf
Use literal for printf and just empty string if needed.
Zdenek Kabelac [Mon, 6 May 2024 20:41:58 +0000 (22:41 +0200)]
cov: use literal for printf format
Prepare suffix ahead and use literal for printf().
Zdenek Kabelac [Tue, 7 May 2024 22:00:28 +0000 (00:00 +0200)]
cov: sanitize input buffer
Make coverity aware the input line is legit.
Eventually add more sanitize functionality.
Zdenek Kabelac [Mon, 6 May 2024 20:26:31 +0000 (22:26 +0200)]
cov: sanitize string for file path
Zdenek Kabelac [Sat, 4 May 2024 21:07:45 +0000 (23:07 +0200)]
cov: wrap pvck call
Resolve reported leak by renaming existing pckk() to pvck_mf()
and wrapping pvck() over this. This function can easily
free allocated buffer within the subfunction.
Zdenek Kabelac [Sat, 4 May 2024 20:31:21 +0000 (22:31 +0200)]
cov: strcpy mempcy
Zdenek Kabelac [Sat, 4 May 2024 20:00:51 +0000 (22:00 +0200)]
cov: replace strcat with safe snprintf
Zdenek Kabelac [Sat, 4 May 2024 19:56:34 +0000 (21:56 +0200)]
cov: replace strcpy with memcpy
Zdenek Kabelac [Sat, 4 May 2024 19:14:41 +0000 (21:14 +0200)]
cov: use sscanf buffer size limits
String parsing with buffer size limit.
Zdenek Kabelac [Sat, 4 May 2024 10:38:13 +0000 (12:38 +0200)]
cov: check for valid raid0 LV segment
Add internal error to quiet Coverity fear of NULL pointer deref.
Zdenek Kabelac [Sat, 4 May 2024 18:30:10 +0000 (20:30 +0200)]
raid: easier prompt message
Use printf capability of 'prompt()' funtions so use literal
when building this message.
Zdenek Kabelac [Sat, 4 May 2024 10:25:36 +0000 (12:25 +0200)]
lvmlockd-dlm: log_error message with literal
Use literals for printf() message construction.
Zdenek Kabelac [Tue, 7 May 2024 20:34:17 +0000 (22:34 +0200)]
libdm: unlink checks for ENOENT
Zdenek Kabelac [Sat, 4 May 2024 09:30:50 +0000 (11:30 +0200)]
libdm: use literal for error message
Use literals for printf messages.
Zdenek Kabelac [Tue, 7 May 2024 18:41:40 +0000 (20:41 +0200)]
const: daemon server logging backend struct
Zdenek Kabelac [Tue, 7 May 2024 14:55:24 +0000 (16:55 +0200)]
const: lvmpolld long_options
Rework usage of long_options so it can be constified,
and also correct use of 'enum action_index'.
Zdenek Kabelac [Sat, 4 May 2024 09:25:58 +0000 (11:25 +0200)]
const: rework conversion to enum
Easier code with string and also avoids mixing enums.
Zdenek Kabelac [Sat, 4 May 2024 09:17:29 +0000 (11:17 +0200)]
const: array of const values
Zdenek Kabelac [Sat, 4 May 2024 09:10:10 +0000 (11:10 +0200)]
const: libdm err_fmt as string
David Teigland [Mon, 6 May 2024 17:01:52 +0000 (12:01 -0500)]
man: lvmthin update
major refresh of text and organization
Zdenek Kabelac [Fri, 3 May 2024 23:53:54 +0000 (01:53 +0200)]
dmsetup: fix invalid loop test
Last patcheds had incorrect merging bug - fix loop test.
This page took 0.069952 seconds and 5 git commands to generate.