]>
sourceware.org Git - lvm2.git/log
Zdenek Kabelac [Fri, 3 May 2024 22:49:51 +0000 (00:49 +0200)]
WHATS_NEW: update
Zdenek Kabelac [Fri, 3 May 2024 22:47:06 +0000 (00:47 +0200)]
make: generate
Update for --wipesignatures for lvconvert.
Zdenek Kabelac [Fri, 3 May 2024 20:44:06 +0000 (22:44 +0200)]
dmsetup: use getopt defines
Replace 0/1 with getopts defines no/required_argument
Zdenek Kabelac [Fri, 3 May 2024 19:28:34 +0000 (21:28 +0200)]
const: dmsetup long_options
Zdenek Kabelac [Fri, 3 May 2024 15:12:23 +0000 (17:12 +0200)]
const: dmsetup string
Zdenek Kabelac [Fri, 3 May 2024 18:24:29 +0000 (20:24 +0200)]
const: cmirrord array
Zdenek Kabelac [Fri, 3 May 2024 18:17:39 +0000 (20:17 +0200)]
const: lvmlockctl options
Zdenek Kabelac [Fri, 3 May 2024 15:36:18 +0000 (17:36 +0200)]
const: dmfilemapd strings
Zdenek Kabelac [Fri, 3 May 2024 14:37:27 +0000 (16:37 +0200)]
const: array for _vdo_split
Zdenek Kabelac [Fri, 3 May 2024 13:39:32 +0000 (15:39 +0200)]
const: report_name
Zdenek Kabelac [Fri, 3 May 2024 13:18:46 +0000 (15:18 +0200)]
const: use common error path
Instead of defining _field_selection_value_alloc_failed_msg[],
use common error path code for printing field_id.
Zdenek Kabelac [Fri, 3 May 2024 12:16:39 +0000 (14:16 +0200)]
const: log level string
Zdenek Kabelac [Fri, 3 May 2024 12:28:58 +0000 (14:28 +0200)]
const: libdm cmd_data_v4
Zdenek Kabelac [Fri, 3 May 2024 10:58:40 +0000 (12:58 +0200)]
const: libdm tok_op
Zdenek Kabelac [Fri, 3 May 2024 10:43:14 +0000 (12:43 +0200)]
const: suffixes list
dm_tree_set_optional_uuid_suffixes() is safe to use with overcasted
array to (const char**)
Zdenek Kabelac [Fri, 3 May 2024 10:38:39 +0000 (12:38 +0200)]
const: suffixes
Zdenek Kabelac [Fri, 3 May 2024 10:24:02 +0000 (12:24 +0200)]
const: _reserved
Zdenek Kabelac [Fri, 3 May 2024 10:50:18 +0000 (12:50 +0200)]
const: use arrays of strings 2
Next set of changes.
Zdenek Kabelac [Fri, 3 May 2024 22:25:33 +0000 (00:25 +0200)]
const: use arrays of strings
Such string is stored directly in '.rodata' section.
Zdenek Kabelac [Fri, 3 May 2024 17:43:21 +0000 (19:43 +0200)]
const: drop static keyword
We don't need relocatable space to store 'const' number.
Zdenek Kabelac [Fri, 3 May 2024 17:43:33 +0000 (19:43 +0200)]
const: static array
Such array can be stored in .rodata section.
Zdenek Kabelac [Fri, 3 May 2024 22:25:48 +0000 (00:25 +0200)]
const: config items
Zdenek Kabelac [Fri, 3 May 2024 09:35:38 +0000 (11:35 +0200)]
const: raid takover arrays
Zdenek Kabelac [Fri, 3 May 2024 12:01:59 +0000 (14:01 +0200)]
const: _fns poll_function
Zdenek Kabelac [Fri, 3 May 2024 12:43:22 +0000 (14:43 +0200)]
const: _ops text_vg_version
Zdenek Kabelac [Fri, 3 May 2024 13:41:02 +0000 (15:41 +0200)]
const: _ops labeler _text_ops
Zdenek Kabelac [Fri, 3 May 2024 09:59:05 +0000 (11:59 +0200)]
const: _ops segtype handler
Zdenek Kabelac [Thu, 2 May 2024 18:52:40 +0000 (20:52 +0200)]
const: _ops text handler
Making sure these structures ends in '.data.rel.ro' section.
(instead of plain '.data' section).
Zdenek Kabelac [Fri, 3 May 2024 19:50:38 +0000 (21:50 +0200)]
libdm: fix condition
When we switch supported_reserved_types_with_range to const
gcc repots this problem:
warning: ‘and’ of mutually exclusive equal-tests is always 0
!(iter->type & supported_reserved_types_with_range))) {
It's not clear from the history what was the actual intention of this
internal error test, let's assume the check wanted to make sure
that when DM_REPORT_FIELD_RESERVED_VALUE_RANGE is set,
some other fields from supported_reserved_types_with_range set
are also selected.
Zdenek Kabelac [Fri, 3 May 2024 21:05:40 +0000 (23:05 +0200)]
libdm: ensure suffixes list elements are const
This was rather API mistake - the internal of libdm
do handle suffixes list as const string, just the API
was only using 'const char **'.
So the user may pass safely casted 'const char * const`.
Zdenek Kabelac [Fri, 3 May 2024 22:46:45 +0000 (00:46 +0200)]
lvonvert: support control over wipingsignature
When converting volume to a thin-pool allow control over
signature wiping.
TODO: likely should become more commonly supported option...
Zdenek Kabelac [Fri, 3 May 2024 19:12:45 +0000 (21:12 +0200)]
vdo: enhance error path
When the conversion to VDO fails, try to restore previous VG state
and also remove orphan DM node from table.
Zdenek Kabelac [Fri, 3 May 2024 14:16:16 +0000 (16:16 +0200)]
lvcreate: --yes option for thin-pool vdo creation
Correct typo and accept proper --yes option instead
of misplaced --force option.
Zdenek Kabelac [Thu, 2 May 2024 11:18:08 +0000 (13:18 +0200)]
command: correct lvresize
Code for supporting size reduction of pool metadata is not yet present
so don't pretend the option can work as pushed in previous commit.
Zdenek Kabelac [Thu, 2 May 2024 10:07:47 +0000 (12:07 +0200)]
WHATS_NEW: update
Zdenek Kabelac [Wed, 1 May 2024 21:24:20 +0000 (23:24 +0200)]
make: generate
Update lvresize options with +/-.
Zdenek Kabelac [Thu, 2 May 2024 09:11:53 +0000 (11:11 +0200)]
command-lines: improve spec for thin snapshot
man-generate --check actually noticed 2 same definitions
for snapshot create with 'lvreate -T [--snapshot]'
and 'lvcreate --snapshot [-T]'.
So drop the '-T' from second alternative variant as
thin type is already implied here.
Zdenek Kabelac [Wed, 1 May 2024 23:31:51 +0000 (01:31 +0200)]
use LVM_COMMAND_COUNT
Zdenek Kabelac [Wed, 1 May 2024 20:55:23 +0000 (22:55 +0200)]
man-generator: code reformating
Zdenek Kabelac [Wed, 1 May 2024 12:36:28 +0000 (14:36 +0200)]
command: refactor to use const command structure
Refactor code so the definitions may become 'static const'
and with configure_command_option_values() we update options
val_enum for actually running command option when used.
Also update _update_relative_opt() which is used for
generating man pages and command help.
Introduce enumeration for lvm2 commands - so we may
use enum cmd_COMMAND instead of string checking.
So running command now does not modified opt_names.
Zdenek Kabelac [Wed, 1 May 2024 10:45:10 +0000 (12:45 +0200)]
command: embedding strings to structs
Since we will make these struct const, we can also
embedding string content into them to avoid unnecessary
pointer relocations.
Zdenek Kabelac [Tue, 30 Apr 2024 11:49:45 +0000 (13:49 +0200)]
cleanup: tab indent and typo
Zdenek Kabelac [Tue, 30 Apr 2024 11:48:01 +0000 (13:48 +0200)]
cleanup: unlink passes with ENOENT
Zdenek Kabelac [Tue, 30 Apr 2024 11:43:32 +0000 (13:43 +0200)]
cleanup: remove unused code
Zdenek Kabelac [Wed, 1 May 2024 08:41:18 +0000 (10:41 +0200)]
writecache: reuse some API
Tiny code updates, reuse dm_pool_strdup().
Zdenek Kabelac [Tue, 30 Apr 2024 18:55:16 +0000 (20:55 +0200)]
memory: compile with VALGRIND_POOL
Function to _allocate_memory() was not compiled-in when lvm2 was
build with support for better tracking memory pool with valgrind.
Instead now correctly avoid this function only when running
withing valgrind environment.
Zdenek Kabelac [Tue, 30 Apr 2024 18:24:02 +0000 (20:24 +0200)]
memory: convert log_error
As the memory locking is not causing command's error - convert
error messages to warnings and debugs.
Zdenek Kabelac [Tue, 30 Apr 2024 18:22:09 +0000 (20:22 +0200)]
toolcontext: introduce var for run in valgrind
Zdenek Kabelac [Tue, 30 Apr 2024 18:21:05 +0000 (20:21 +0200)]
activation: interruptible sleep when talking to dmeventd
Zdenek Kabelac [Sun, 28 Apr 2024 18:15:10 +0000 (20:15 +0200)]
cleanup: drop double _
Zdenek Kabelac [Sun, 28 Apr 2024 20:09:05 +0000 (22:09 +0200)]
lvmcmdline: code update
Zdenek Kabelac [Sun, 28 Apr 2024 18:14:42 +0000 (20:14 +0200)]
command: more arrays keep static
Zdenek Kabelac [Sun, 28 Apr 2024 17:52:26 +0000 (19:52 +0200)]
command: more static const declaration
Use static const for declared arrays.
Access to arrays through get_ functions().
Zdenek Kabelac [Sun, 28 Apr 2024 16:14:27 +0000 (18:14 +0200)]
command: use const declaration for arrays
Zdenek Kabelac [Sun, 28 Apr 2024 15:59:42 +0000 (17:59 +0200)]
command: refactor common code to command_enum.h
Move shared code to command_enum.h and avoid duplicating code.
Zdenek Kabelac [Sat, 27 Apr 2024 18:25:30 +0000 (20:25 +0200)]
lvchange: constify option array
Zdenek Kabelac [Sat, 27 Apr 2024 11:39:33 +0000 (13:39 +0200)]
command: using single printf call
Use single string for 1 printf() call with \t tabs.
Zdenek Kabelac [Sat, 27 Apr 2024 11:04:25 +0000 (13:04 +0200)]
command: refactor loop test for end of string
Zdenek Kabelac [Sat, 27 Apr 2024 17:26:32 +0000 (19:26 +0200)]
command: refactor test for relative opt
Use _update_relative_opt to check for relative option and
update val_enum accordingly.
Zdenek Kabelac [Sat, 27 Apr 2024 18:15:36 +0000 (20:15 +0200)]
man-generator: some switch case refactoring
Zdenek Kabelac [Sat, 27 Apr 2024 09:36:55 +0000 (11:36 +0200)]
command: split man-generator code
Move code for generating man pages to man-generator.c
which is no longer a symlink to command.c and just
includes this file for the common code.
Zdenek Kabelac [Sat, 27 Apr 2024 09:36:42 +0000 (11:36 +0200)]
command: refactor if condition
Zdenek Kabelac [Sun, 28 Apr 2024 16:01:33 +0000 (18:01 +0200)]
lvconvert: use cmd_context variable
Do not modify flags field from 'strcut command_name' and
instead control this via cmd_context get_vgname_from_options.
Flag GET_VGNAME_FROM_OPTIONS is currently used only by lvconvert.
Zdenek Kabelac [Sun, 28 Apr 2024 21:32:00 +0000 (23:32 +0200)]
lvmdbusd: its fine if dir already exists
With previous patch, we now need to handle the case
when dir already exists.
Zdenek Kabelac [Fri, 26 Apr 2024 21:53:29 +0000 (23:53 +0200)]
dmeventd: use standard reopening mechanism
Apply same code for reopening /dev/null for 0,1,2 when daemonizing.
Zdenek Kabelac [Fri, 26 Apr 2024 21:51:38 +0000 (23:51 +0200)]
daemon-stray: correct size limitation for filename
Correct the buffer size for filename printing.
Kai Kang [Tue, 5 Dec 2023 07:50:21 +0000 (15:50 +0800)]
lvmdbusd: create dirs for lock file
Create leading dirs for lvmdbusd lock file, otherwise it fails to start:
| systemd[1]: Starting LVM2 D-Bus service...
| lvmdbusd[1602]: [1602]: Error during creation of lock file(/var/lock/lvm/lvmdbusd): errno(2), exiting!
Signed-off-by: Kai Kang <kai.kang@windriver.com>
Zdenek Kabelac [Fri, 26 Apr 2024 14:44:07 +0000 (16:44 +0200)]
WHATS_NEW: update
Zdenek Kabelac [Fri, 26 Apr 2024 18:54:57 +0000 (20:54 +0200)]
make: generate
Zdenek Kabelac [Fri, 26 Apr 2024 18:54:09 +0000 (20:54 +0200)]
cmdlines: use OO_LVCREATE_RAID
Common options in one OO_
Zdenek Kabelac [Fri, 26 Apr 2024 18:16:23 +0000 (20:16 +0200)]
cmdlines: simplify OO_LVCONVER/LVCREATE_THINPOOL
OO_LVCONVERT_THINPOOL always constains OO_LVCONVERT_POOL
OO_LVCREATE_THINPOOL always contains OO_LVCREATE_POOL
More readable description.
Zdenek Kabelac [Fri, 26 Apr 2024 17:56:58 +0000 (19:56 +0200)]
tests: resize thin-pool with vdo data
Zdenek Kabelac [Fri, 26 Apr 2024 17:55:47 +0000 (19:55 +0200)]
tests: correcting test for invalid commnad
Correting typo in specification of create --typo.
Also removing some unnecessary parts...
Zdenek Kabelac [Fri, 26 Apr 2024 14:20:59 +0000 (16:20 +0200)]
makefile: avoid creating shared lib for static only build
Zdenek Kabelac [Fri, 26 Apr 2024 17:10:04 +0000 (19:10 +0200)]
vdo: fix setting VDO size when stacked
When VDO is used as data LV for thin-pool, we need
to use correct function to propagate this through
the stack of volumes.
David Teigland [Fri, 26 Apr 2024 19:13:46 +0000 (14:13 -0500)]
lvmcache: stop saving duplicate pvs info between scans
In the past it was common for a single command to run
multiple lvmcache_label_scan, and this code was a way
to make each call select the same duplicate pvs. Now
commands run a single lvmcache_label_scan, so this is
not needed.
Zdenek Kabelac [Fri, 26 Apr 2024 10:43:03 +0000 (12:43 +0200)]
tests: wait for raid being in sync
Zdenek Kabelac [Thu, 25 Apr 2024 21:53:46 +0000 (23:53 +0200)]
cov: unused headers
Zdenek Kabelac [Thu, 25 Apr 2024 21:51:58 +0000 (23:51 +0200)]
cov: validation
Add internal error for missing vg.
Zdenek Kabelac [Thu, 25 Apr 2024 19:20:36 +0000 (21:20 +0200)]
toolcontext: check runtime valgrind
When reseting stream buffer - check for being run within valgrind
and only in this case skip this code.
Define VALGRIND_POOL was incorrectly used for this logic.
Zdenek Kabelac [Thu, 25 Apr 2024 19:07:36 +0000 (21:07 +0200)]
daemon-stray: compile also with VALGRIND_POOL
We can run and build this code just fine with VALGRIND_POOL
and just rely on runtime detection - so we do not close
descriptors also within running valgrind session.
Zdenek Kabelac [Wed, 24 Apr 2024 18:53:04 +0000 (20:53 +0200)]
spec: require ncurses only for readline
Hopefully editline can go without ncurses dependency.
Zdenek Kabelac [Wed, 24 Apr 2024 18:48:27 +0000 (20:48 +0200)]
makefiles: change condition
Old system do not work well with -l% in findstring,
so use a different strategy to recognize whether -lreadline needs
another library (-ltinfo, -lncourses...)
(So we don't need to solve this via 'configure')
Also for now comment out -Wl,-z,pack-relative-relocs and leave it
for the package maintainer whether they want to use.
Possibly add some 'configure' autodetection for usable switch,
as it's relatively new feature..
Zdenek Kabelac [Wed, 24 Apr 2024 11:54:05 +0000 (13:54 +0200)]
tests: avoid race check
Zdenek Kabelac [Wed, 24 Apr 2024 11:44:58 +0000 (13:44 +0200)]
tests: accept also closing status
Zdenek Kabelac [Wed, 24 Apr 2024 11:42:05 +0000 (13:42 +0200)]
makefiles: comman escape needs this trick
Zdenek Kabelac [Wed, 24 Apr 2024 09:35:05 +0000 (11:35 +0200)]
makefiles: add as-needed only for newer systems
Add some -Wl flags separatly and avoid their duplication.
Also add --as-needed only when system is using 'newer' readline
library - on these older system the usage of '--as-needed'
seems to be causing some hard to solve problem - so avoid it.
Zdenek Kabelac [Wed, 24 Apr 2024 09:34:35 +0000 (11:34 +0200)]
tests: correct linking order for RT_LIBS
Zdenek Kabelac [Tue, 23 Apr 2024 21:08:39 +0000 (23:08 +0200)]
configure: autoreconf
Zdenek Kabelac [Tue, 23 Apr 2024 21:30:35 +0000 (23:30 +0200)]
configure.ac: update ldflags args
Attach -Wl,-z,relro,-z,now,-z,pack-relative-relocs,--as-needed
to LDFLAGS, but only if LDFLAGS already doesn't contain 'relro'
(so it's not given repeatedly).
Also start to use -z,now linkage also when building libraries
with default compilation - this avoid calling symbol resolver
while library function are using function needing resolving.
Note: Fedora or RHEL rpm building is using:
CFLAGS=$(rpm --eval %{build_cflags})
LDFLAGS=$(rpm --eval %{build_ldflags})
Also split -DUSE_SD_NOTIFY into DEFS from CFLAGS.
Zdenek Kabelac [Tue, 23 Apr 2024 21:09:48 +0000 (23:09 +0200)]
configure.ac: leave LDFLAGS resolving on make time
Use LDFLAGS separately with every use of CLDFLAGS and leave
this flag only for handling versioning.
This will reflect any LDFLAGS setting use during make.
Zdenek Kabelac [Tue, 23 Apr 2024 14:07:36 +0000 (16:07 +0200)]
tests: update dmsecuretest
Look not only for whole 64byte sequence,
but seek also 32byte, 16byte and 8byte parts of the
key.
Currently to pass memcpy ZMM problems add possible
workaround in the form of GLIBC_TUNABLES setting.
Zdenek Kabelac [Fri, 19 Apr 2024 21:57:07 +0000 (23:57 +0200)]
make: generate
Zdenek Kabelac [Fri, 19 Apr 2024 21:46:40 +0000 (23:46 +0200)]
tests: look also for 16byte sequences
Zdenek Kabelac [Fri, 19 Apr 2024 21:08:11 +0000 (23:08 +0200)]
tests: add explicit call to lvs
Avoid using 'lvs' from 'get' shell - as that would wait until
whole group of processes is finished.
TODO: rethink what would be the point of starting 'dmeventd' with lvs.
It seems to break some rules.
Zdenek Kabelac [Fri, 19 Apr 2024 18:45:15 +0000 (20:45 +0200)]
spec: define rhel_version_file for rhel only
Do not define rhel_minor_version on non-rhel systems.
Zdenek Kabelac [Fri, 19 Apr 2024 18:45:00 +0000 (20:45 +0200)]
libdevmapper: _do_event waits for working dmeventd
Refactor _start_daemon and add synchronization delay waiting
untill new forked dmeventd actually open fifos and is ready
to process messages.
This closes some race window in testing.
David Teigland [Fri, 19 Apr 2024 15:48:19 +0000 (10:48 -0500)]
lvmlockd: check for multiple lock managers running
When no lock manager for the global lock had been set yet,
and the first global lock request was received, and both
dlm and sanlock were running, lvmlockd would assume it
should use the dlm for the global lock, and would start
the "lvm_global" dlm lockspace automatically. That's
not always correct, so don't assume the dlm should be used,
fail the lock request, and wait until a VG with a specific
lock type is started to determine the lock manager to use.
David Teigland [Wed, 17 Apr 2024 18:40:33 +0000 (13:40 -0500)]
lvcreate: allow raidintegrity option with implicit raid type
Allow "lvcreate -m1 --raidintegrity y" when raid1 is used, but
not explicit on the command line.
Zdenek Kabelac [Tue, 16 Apr 2024 19:08:22 +0000 (21:08 +0200)]
spec: correct condition
Test needs to make sure that it's either <RHX or <FXX.
However they are set to 0 when on different system.
So use '&&'.
This page took 0.151533 seconds and 5 git commands to generate.