]> sourceware.org Git - systemtap.git/log
systemtap.git
10 years agoAdd a NEWS item about the PR15982 fix.
David Smith [Mon, 30 Sep 2013 16:27:16 +0000 (11:27 -0500)]
Add a NEWS item about the PR15982 fix.

10 years agoFix PR15982 by making 'process.end' probes work reliably.
David Smith [Mon, 30 Sep 2013 15:12:47 +0000 (10:12 -0500)]
Fix PR15982 by making 'process.end' probes work reliably.

* runtime/linux/task_finder.c: Swith from using UTRACE_DEATH events to
  using UTRACE_EXIT events, to avoid missing 'process.end' probes.
* tapset-utrace.cxx (utrace_derived_probe_group::emit_linux_probe_decl):
  For CONFIG_UTRACE, use UTRACE_EXIT events instead of UTRACE_DEATH
  events.
* testsuite/systemtap.base/proc_exec.exp: Tweak expected output.

10 years agoPR15123: when PR15123_ASSUME_MFENTRY is set, don't check for -mfentry flag
Vincent Bernat [Sat, 28 Sep 2013 16:50:26 +0000 (18:50 +0200)]
PR15123: when PR15123_ASSUME_MFENTRY is set, don't check for -mfentry flag

-mfentry flag is recorded in `DW_AT_producer` only if
`CFLAGS=-grecord-gcc-switches` was used at compilation-time. We
provide PR15123_ASSUME_MFENTRY as an environment variable to override
this detection. The user is expected to set this variable only if it
is confident that that CFLAGS=-mfentry was used.

10 years agostap-report: add kernel compiler version
Frank Ch. Eigler [Fri, 27 Sep 2013 22:55:14 +0000 (18:55 -0400)]
stap-report: add kernel compiler version

10 years agoBasic SystemTap support for aarch64
William Cohen [Fri, 27 Sep 2013 18:49:44 +0000 (14:49 -0400)]
Basic SystemTap support for aarch64

The SystemTap runtime libraries needs a number of machine specific
details for each architecture to be specified.  This is an attempt to
provide the minimal set of them so that a "hello, world" SystemTap
script will compile.

10 years agoMake systemtap.examples/io/deviceseeks.stp work on older kernels.
David Smith [Thu, 26 Sep 2013 21:48:31 +0000 (16:48 -0500)]
Make systemtap.examples/io/deviceseeks.stp work on older kernels.

* testsuite/systemtap.examples/io/deviceseeks.stp: Handle older kernel's
  names for the sector size field.

10 years agotestsuite: New sdt_casm for STAP_PROBE_ASM
Josh Stone [Thu, 26 Sep 2013 21:35:00 +0000 (14:35 -0700)]
testsuite: New sdt_casm for STAP_PROBE_ASM

An attempted fix for PR13974 had broken STAP_PROBE_ASM, because in that
case there's some ambiguity whether %note and %progbits should be
%%-escaped.  We can't determine that in general, because it depends on
whether the user's asm() has operands.  That fix was thus reverted, and
we're testing to make sure STAP_PROBE_ASM doesn't regress again.

10 years agotestsuite: make sdt_asm.exp actually clean up
Josh Stone [Thu, 26 Sep 2013 21:34:29 +0000 (14:34 -0700)]
testsuite: make sdt_asm.exp actually clean up

10 years agoRevert "SDT: Use %foo for section types rather than "foo""
Josh Stone [Thu, 26 Sep 2013 19:45:45 +0000 (12:45 -0700)]
Revert "SDT: Use %foo for section types rather than "foo""

This reverts commit a31190f59188830b78dce26f0fbc42084f27c3c1.

We broke glibc's build on rawhide due to the way they use SDT_PROBE_ASM.
There's really no way to correctly use %note in that scenario, where we
can't know if there's operand parsing or not.

10 years agoPR15908: pass STAP_SUPPRESS_HANDLER_ERRORS to runtime
Frank Ch. Eigler [Thu, 26 Sep 2013 14:25:27 +0000 (10:25 -0400)]
PR15908: pass STAP_SUPPRESS_HANDLER_ERRORS to runtime

* session.cxx (parse_cmdline): Handle --suppress-handle-errors more.
* runtime/linux/uprobes-common.c: Respect new macro in MAXSKIPPED
  processing.

10 years agoAdd am64 support
William Cohen [Thu, 1 Jan 1970 00:19:29 +0000 (00:00 -0019)]
Add am64 support

The "uname -m" reports arm64 as aarch64. Some translation is needed to
convert the name to the proper arch name so the appropriate Makefile
can be found.  Also need to report the arch as a 64-bit architecture.

10 years agostap-report: 'ls' the contents of each database directory before analysing.
Dave Brolley [Wed, 25 Sep 2013 16:54:11 +0000 (12:54 -0400)]
stap-report: 'ls' the contents of each database directory before analysing.

10 years agotapset memory.stp: correct VM_FAULT_MINOR conditional handling
Paddie O'Brien [Wed, 25 Sep 2013 15:46:35 +0000 (11:46 -0400)]
tapset memory.stp: correct VM_FAULT_MINOR conditional handling

This impacts the pfaults.stp sample.

Reported-By: Thomas Knauth <thomas.knauth@gmx.de>
10 years agoOpen and close NSS certificate databases using an explicit "dbm:" prefix.
Dave Brolley [Wed, 25 Sep 2013 15:02:10 +0000 (11:02 -0400)]
Open and close NSS certificate databases using an explicit "dbm:" prefix.

Only if the NSS version is >= 3.12.

10 years agoAdd SEC_ERROR_LEGACY_DATABASE to the NSS errors known by systemtap.
Dave Brolley [Wed, 25 Sep 2013 15:00:55 +0000 (11:00 -0400)]
Add SEC_ERROR_LEGACY_DATABASE to the NSS errors known by systemtap.

10 years agostap-report: Report on the status of NSS certificate databases.
Dave Brolley [Wed, 25 Sep 2013 15:00:07 +0000 (11:00 -0400)]
stap-report: Report on the status of NSS certificate databases.

10 years agoDefine vzalloc() and vzalloc_node() for systems without them.
David Smith [Tue, 24 Sep 2013 16:20:22 +0000 (11:20 -0500)]
Define vzalloc() and vzalloc_node() for systems without them.

* buildrun.cxx (compile_pass): Add 'exportconf' tests for vzalloc() and
  vzalloc_node().
* runtime/linux/alloc.c: Use STAPCONF_VZALLOC and STAPCONF_VZALLOC_NODE to
  know if we need private versions of vzalloc() and vzalloc_node().

10 years agoMerge branch 'master' of ssh://sourceware.org/git/systemtap
David Smith [Tue, 24 Sep 2013 16:05:04 +0000 (11:05 -0500)]
Merge branch 'master' of ssh://sourceware.org/git/systemtap

10 years agoDefine KERN_CONT for old kernels in runtime/transport/symbols.c.
David Smith [Tue, 24 Sep 2013 16:04:12 +0000 (11:04 -0500)]
Define KERN_CONT for old kernels in runtime/transport/symbols.c.

10 years agostap-report: also collect NSS* env vars
Frank Ch. Eigler [Mon, 23 Sep 2013 18:32:00 +0000 (14:32 -0400)]
stap-report: also collect NSS* env vars

10 years agostap-report: add stap-server-related data
Frank Ch. Eigler [Sat, 21 Sep 2013 01:18:36 +0000 (21:18 -0400)]
stap-report: add stap-server-related data

... like the stap-server logs and DNS/hostname data

10 years agoFixes for CC=clang CXX=clang++
Josh Stone [Fri, 20 Sep 2013 23:57:27 +0000 (16:57 -0700)]
Fixes for CC=clang CXX=clang++

We can compile almost everything with clang now, except:
- loc2c.c due to nested functions.
- stapdyn/ because dyninst pulls in __gnu_cxx::hash_map for GNUC < 4.3,
  which triggers -Wdeprecated in libstdc++-4.8.1.
  (clang #defines itself as GNUC 4.2.1.)

* loc2c-test.c (fail): Indicate that this is itself a formatted
  function, so it doesn't complain about non-const 'fmt' passed to
  vfprintf.  (The callers are in fact passing const strings.)
* session.cxx (systemtap_session::parse_cmdline): Added braces so
  that the if-for-if-else doesn't have a dangling else.
* stapregex-dfa.h: translator_output is a class.
* stapregex.h: translator_output is a class; dfa is a struct.
* tapset-method.cxx (java_builder): Remove unused cache_initialized.

10 years agotestsuite: split std_asm out of std_misc.exp
Josh Stone [Fri, 20 Sep 2013 23:08:28 +0000 (16:08 -0700)]
testsuite: split std_asm out of std_misc.exp

The asm part of sdt_misc.exp was not really dependent on any other part
of that testcase, so we can let it stand alone for direct testing.  Its
reported name in test results is left as "sdt_misc", so it can still be
easily compared to previous test runs.

10 years agoSDT: Use %foo for section types rather than "foo"
Josh Stone [Fri, 20 Sep 2013 23:00:44 +0000 (16:00 -0700)]
SDT: Use %foo for section types rather than "foo"

GAS can take section types as "foo", @foo, or %foo.  We had the quoted
form, but this is not documented, and llvm-mc doesn't support it.  Using
@foo starts a comment on ARM, so we're left with %foo.

For note, we have to escape it to %%note for the asm()'s operand
expansion, but leave it as %note for pure assembly.  For progbits, there
are no operands, so it's %progbits either way.

Thanks to Martin C. Martin for first reporting this to LLVM[1], and then
returning to systemtap with a suggested compatibility fix.
 [1] http://llvm.org/bugs/show_bug.cgi?id=17270

10 years agoFix up testsuite/Makefile.am RUNTEST variable
William Cohen [Thu, 19 Sep 2013 20:56:00 +0000 (16:56 -0400)]
Fix up testsuite/Makefile.am RUNTEST variable

The '"'s in the definition of RUNTEST in testsuite/Makefile.am was
making causing the test for DEJAGNU to fail.  There didn't seem to be
a reason to keep the quotes around, so they were removed and "make
installcheck" works again.

10 years agoNew test: compile server recovers from avahi-daemon restart.
Dave Brolley [Thu, 19 Sep 2013 20:20:05 +0000 (16:20 -0400)]
New test: compile server recovers from avahi-daemon restart.

10 years agoFix incorrect determination of the compile server's address.
Dave Brolley [Thu, 19 Sep 2013 20:08:47 +0000 (16:08 -0400)]
Fix incorrect determination of the compile server's address.

The message in the server log which was used for this had
changed.

10 years agoCorrect systemtap.spec to match support currently available on aarch64
William Cohen [Wed, 18 Sep 2013 17:25:29 +0000 (13:25 -0400)]
Correct systemtap.spec to match support currently available on aarch64

The aarch64 does not have dyninst, crash, or publican available.  Thus,
the systmetap.spec file needs to turn those off those features
to allow systemtap to build  on aarch64.

10 years agoUpdate gettext related material
William Cohen [Thu, 19 Sep 2013 18:25:20 +0000 (14:25 -0400)]
Update gettext related material

The autoreconf command did not update the po/Makefile.in file.  Needed
to update files files with a "gettext -f" so there is no complaint
about version mismatch for gettext.

10 years agoUpdate autoconf related files to support aarch64
William Cohen [Thu, 19 Sep 2013 15:39:17 +0000 (11:39 -0400)]
Update autoconf related files to support aarch64

The config.sub and config.guess were generated with an older version
of autoconf that did not know about aarch64 (64-bit ARM).  Updated the
various files to support the aarch64 by running the following command:

autoreconf -v -f -i

10 years agoRHBZ 874205 [FJ6.2 Bug] Handle avahi-deamon restart gracefully in stap-serverd.
Dave Brolley [Wed, 18 Sep 2013 15:17:05 +0000 (11:17 -0400)]
RHBZ 874205 [FJ6.2 Bug] Handle avahi-deamon restart gracefully in stap-serverd.

stap-serverd was crashing when the avahi-daemon was restarted. There was
some inproper use of the avahi-client API which casued this.
avahi_threaded_poll_stop() was being called from within the client callback
function.

Some reading of the API docs revelaed that, in this situation, the old
client should be freed and a new one created in order to transition
to the new daemon if/when it is started.

Also noticed a potential double free of objects associated with the client
when freeing the client. Freeing the client also frees the associated objects,
so it is not necessary, and potentially wrong, to free them ourselves before
freeing the client.

10 years agoIn the compile-server client, save the returned module before printing its name.
Dave Brolley [Tue, 17 Sep 2013 20:05:17 +0000 (16:05 -0400)]
In the compile-server client, save the returned module before printing its name.

10 years agoAvoid module compilation problems by unsetting the environment variable 'ARCH'.
David Smith [Wed, 18 Sep 2013 14:44:13 +0000 (09:44 -0500)]
Avoid module compilation problems by unsetting the environment variable 'ARCH'.

* testsuite/lib/systemtap.exp (setup_systemtap_environment): Make sure the
  environment variable 'ARCH' isn't set. If it is, it can cause custom
  module building to fail.

10 years agosystemtap.spec: %changelog tweaks
Frank Ch. Eigler [Mon, 16 Sep 2013 22:11:33 +0000 (18:11 -0400)]
systemtap.spec: %changelog tweaks

- Add belated 2.3 entry.
- Add reminder to include a wiki link to full release notes.

10 years agoPR15731 update: Fix 'syscall.{execve,compat_execve}' for older kernels.
David Smith [Mon, 16 Sep 2013 20:39:23 +0000 (15:39 -0500)]
PR15731 update: Fix 'syscall.{execve,compat_execve}' for older kernels.

* tapset/linux/syscalls.stp (syscall.execve): On kernels < 3.7, go back to
  using 'do_execve', since sys_execve was in arch-specific code and had
  varying arguments.
  (syscall.compat_execve): Ditto.
* tapset/linux/nd_syscalls.stp: Ditto.

10 years agoPR14960 etc., buildrun.cxx: weaken from 256 to -Wframe-larger-than=512
Frank Ch. Eigler [Mon, 16 Sep 2013 15:58:07 +0000 (11:58 -0400)]
PR14960 etc., buildrun.cxx: weaken from 256 to -Wframe-larger-than=512

Several tests have popped up where gcc goes just a little over 256.

"512 should be enough for anybody".  It was always 512.  We have
always been at war with 256.

10 years agoMerge branch 'master' of ssh://sourceware.org/git/systemtap
Lukas Berk [Fri, 13 Sep 2013 19:33:26 +0000 (15:33 -0400)]
Merge branch 'master' of ssh://sourceware.org/git/systemtap

10 years agoProperly check and use minidebuginfo
Lukas Berk [Fri, 13 Sep 2013 19:27:45 +0000 (15:27 -0400)]
Properly check and use minidebuginfo

dwflpp.cxx: add bool has_gnu_debuginfo() to check if section exists
dwflpp.h: declare bool has_gnu_debuginfo()
tapsets.cxx: check for .gnu_debuginfo as condition to query_module_symtab
     and listing functions in a process
minidebuginfo.stp: correct the binary to probe

10 years agoAdded test for the caller() function.
David Smith [Fri, 13 Sep 2013 17:30:54 +0000 (12:30 -0500)]
Added test for the caller() function.

* testsuite/systemtap.base/caller.exp: New test of the "caller" function.

10 years agoRemove temporary cpp file also when generating header file. Debian #722649
Mark Wielaard [Fri, 13 Sep 2013 10:22:05 +0000 (12:22 +0200)]
Remove temporary cpp file also when generating header file. Debian #722649

10 years agoBump python source releases.
Stan Cox [Thu, 12 Sep 2013 19:44:19 +0000 (15:44 -0400)]
Bump python source releases.

* testsuite/systemtap.apps/python.exp:  Bump python2release and python3release.
* testsuite/systemtap.apps/python2.stp:  Check dict value before trying to
  cast it.

10 years agoclient.exp: Make sure spawned stap finishes.
Dave Brolley [Thu, 12 Sep 2013 17:30:25 +0000 (13:30 -0400)]
client.exp: Make sure spawned stap finishes.

Test cases should ensure that all spawned processes are
sufficiently complete before the expect {} block for that
test exits. This prevents any subsequent 'close' statement
from generating a SIGHUP and possibly interrupting the spawned
process.

10 years agoFix BZ996065 by updating systemtap.base/bz10078.stp
David Smith [Thu, 12 Sep 2013 15:07:15 +0000 (10:07 -0500)]
Fix BZ996065 by updating systemtap.base/bz10078.stp

* testsuite/systemtap.base/bz10078.stp: Change probefunc() to ppfunc(),
  since probefunc()'s semantics have changed.

10 years agoParse additional SDT ARM arguments variations
William Cohen [Wed, 11 Sep 2013 21:18:29 +0000 (17:18 -0400)]
Parse additional SDT ARM arguments variations

When running qemu_count.stp example on arm a there were a number of
cases where systemtap could not parse the location of the marker
arguments for the qemu-system-arm.stp tapset.  There were two cases
that were not handled in the code:

- Use of r10 in the argument location information
- Locations with zero offsets that omit the ", #0"

10 years agoNote that inode-uprobes gained return probes in 3.10
Josh Stone [Wed, 11 Sep 2013 16:56:59 +0000 (09:56 -0700)]
Note that inode-uprobes gained return probes in 3.10

10 years agoBZ915180: fix _stp_is_comat_task typo in s390 test case
Frank Ch. Eigler [Wed, 11 Sep 2013 10:12:52 +0000 (06:12 -0400)]
BZ915180: fix _stp_is_comat_task typo in s390 test case

10 years agoFix i[36]86 target matching in systemtap.base/sdt_misc.exp.
David Smith [Tue, 10 Sep 2013 20:16:42 +0000 (15:16 -0500)]
Fix i[36]86 target matching in systemtap.base/sdt_misc.exp.

10 years agoMake user_string_n_quoted.exp more robust.
David Smith [Mon, 9 Sep 2013 20:03:31 +0000 (15:03 -0500)]
Make user_string_n_quoted.exp more robust.

* testsuite/systemtap.string/user_string_n_quoted.exp: Several small
  changes. If we're not doing install testing, mark the test as
  untested. Increase the timeout value, in case we're operating with a
  cold cache. If we timeout, try to kill stap. Properly call "close" and
  "wait" after "spawn" call.
* testsuite/systemtap.string/user_string_n_quoted.stp: Change
  'nd_syscall.write' to 'syscall.write', since the 'syscall' variant has
  more support.

10 years agoFix minidebuginfo.exp testcase
Lukas Berk [Fri, 6 Sep 2013 17:41:39 +0000 (13:41 -0400)]
Fix minidebuginfo.exp testcase

The minidebuginfo testcase was based off of an incomplete documenation.  We need
to properly fix the creation of the executable to test in a standalone instance.

create-minidebug.sh - properly create standalone testcase, this includes
      removing all symbol, relocation and .debug_* sections.
      Tweak naming of files with binary. prefix for easier
      tracking

minidebuginfo.exp - updated file names to target and cleanup

10 years agominidebuginfo: tighten up create-minidebug.sh
Frank Ch. Eigler [Thu, 5 Sep 2013 19:16:41 +0000 (15:16 -0400)]
minidebuginfo: tighten up create-minidebug.sh

... so we remove .debug_* and .sym* stuff, leaving only the
new .gnu_debugdata.

10 years agoAdded s390x kfails when reading certain addresses that should error, but don't.
David Smith [Thu, 5 Sep 2013 16:53:40 +0000 (11:53 -0500)]
Added s390x kfails when reading certain addresses that should error, but don't.

* testsuite/systemtap.base/net-sanity.exp: Add s390x kfails.
* testsuite/systemtap.base/atomic.exp: Ditto.

10 years agoAdded a testcase for BZ1003976.
David Smith [Thu, 5 Sep 2013 16:49:08 +0000 (11:49 -0500)]
Added a testcase for BZ1003976.

* testsuite/systemtap.base/cmdline.exp: New file.
* testsuite/systemtap.base/cmdline.stp: Ditto.

10 years agoBZ1003976: fix function::cmdline_arg processing
Frank Ch. Eigler [Thu, 5 Sep 2013 15:48:39 +0000 (11:48 -0400)]
BZ1003976: fix function::cmdline_arg processing

* tapset/linux/context.stp (cmdline_arg): Simplify, correct.

10 years agoMinor fixes for java/Makefile
Josh Stone [Wed, 4 Sep 2013 22:52:52 +0000 (15:52 -0700)]
Minor fixes for java/Makefile

- Use the full path to refer to HelperSDT.class, so that make can
  actually tell when it needs to be rebuilt.

- libselinux and git_version.h are not used by this component.

10 years agoFixed PR15928 by making memory1.exp read kernel memory instead of user memory.
David Smith [Wed, 4 Sep 2013 18:25:05 +0000 (13:25 -0500)]
Fixed PR15928 by making memory1.exp read kernel memory instead of user memory.

* testsuite/systemtap.printf/memory1.exp: Build a custom kernel module to
  probe.
* testsuite/systemtap.printf/memory1.stp: Instead of probing
  'syscall.open', probe the custom kernel module instead.
* testsuite/systemtap.printf/memory1_module.Makefile: New file.
* testsuite/systemtap.printf/memory1_module.c: Ditto.

10 years agoDo better testing to determine whether the hw_watch-*.stp will work
William Cohen [Tue, 3 Sep 2013 21:26:00 +0000 (17:26 -0400)]
Do better testing to determine whether the hw_watch-*.stp will work

If perf doesn't support the hardware watchpoints, then systemtap hardware
watchpoints are not going to work either.

10 years agoSkip debugtypes.exp if we don't have uprobes.
David Smith [Tue, 3 Sep 2013 19:39:51 +0000 (14:39 -0500)]
Skip debugtypes.exp if we don't have uprobes.

10 years agoRemove PR15913 fix, since the problem isn't just with nd_syscall.execve.
David Smith [Tue, 3 Sep 2013 19:38:29 +0000 (14:38 -0500)]
Remove PR15913 fix, since the problem isn't just with nd_syscall.execve.

* tapset/linux/nd_syscalls.stp: Revert s390x using register r2 for the
  first argument.

10 years agoUpdate s390's syscall.getresgid16 and syscall.getresuid16 probe aliases.
David Smith [Tue, 3 Sep 2013 16:12:55 +0000 (11:12 -0500)]
Update s390's syscall.getresgid16 and syscall.getresuid16 probe aliases.

* tapset/linux/s390/syscalls.stp: Update syscall.getresgid16 and
  syscall.getresuid16 probe aliases to handle upstream renaming of
  arguments.

10 years agoFix PR15913 by handling nd_syscall.execve's 'filename' argument on s390x.
David Smith [Fri, 30 Aug 2013 20:52:52 +0000 (15:52 -0500)]
Fix PR15913 by handling nd_syscall.execve's 'filename' argument on s390x.

* tapset/linux/nd_syscalls.stp: On s390x, use register r2 for the filename
  argument.

10 years agoImprove the 'num_args' subtest of systemtap.context/context.exp.
David Smith [Fri, 30 Aug 2013 18:51:42 +0000 (13:51 -0500)]
Improve the 'num_args' subtest of systemtap.context/context.exp.

* testsuite/systemtap.context/num_args.stp: Improve s390 support by
  looking in r2 for the first argument.
* testsuite/systemtap.context/num_args.tcl: Fail if we don't get the
  proper string function arguments (instead of silently ignoring the
  error).

10 years agoSkip the 'utf' tests if we don't have uprobes.
David Smith [Fri, 30 Aug 2013 16:12:34 +0000 (11:12 -0500)]
Skip the 'utf' tests if we don't have uprobes.

* testsuite/systemtap.base/utf_pretty.exp: Don't run test if we're not
  doing install testing or if we don't have uprobes.
* testsuite/systemtap.base/utf_user.exp: Ditto.
* testsuite/systemtap.base/utf_user_trunc.exp: Ditto.

10 years agoProperly read user memory in target_set.stp.
David Smith [Fri, 30 Aug 2013 16:03:14 +0000 (11:03 -0500)]
Properly read user memory in target_set.stp.

* testsuite/systemtap.base/target_set.stp: Be sure to read user memory
  with user_long().

10 years agoDon't run target_set_thread.exp if we don't have uprobes.
David Smith [Fri, 30 Aug 2013 15:59:16 +0000 (10:59 -0500)]
Don't run target_set_thread.exp if we don't have uprobes.

10 years agoImprove skipping perf probe tests on unsupported systems.
David Smith [Fri, 30 Aug 2013 14:55:52 +0000 (09:55 -0500)]
Improve skipping perf probe tests on unsupported systems.

* testsuite/lib/systemtap.exp (perf_probes_p): New function.
* testsuite/systemtap.stress/conversions.exp: Use new 'perf_probes_p'
  function instead of an explicit test.
* testsuite/systemtap.base/perf.exp: If we don't have perf probes, mark
  test as untested.
* testsuite/systemtap.base/pt_user_mode.exp: Skip test if we're not doing
  an install test. We don't need to check for perf probe support.
* testsuite/systemtap.examples/profiling/perf.tcl: Skip the example if we
  don't have perf probes or uprobes.

10 years agoMark systemtap.base/pthread_stacks.exp untested when necessary.
David Smith [Fri, 30 Aug 2013 14:51:20 +0000 (09:51 -0500)]
Mark systemtap.base/pthread_stacks.exp untested when necessary.

* testsuite/systemtap.base/pthread_stacks.exp: Don't run test if we're not
  doing install testing or if we don't have uprobes.

10 years agoFix minidebuginfo.exp testcase problems.
David Smith [Fri, 30 Aug 2013 13:43:25 +0000 (08:43 -0500)]
Fix minidebuginfo.exp testcase problems.

* testsuite/systemtap.base/minidebuginfo.exp: If the tested system doesn't
  have uprobes, mark as untested.
* testsuite/systemtap.base/create-minidebug.sh: Change "/usr/bin/bash" to
  "/bin/bash", so older systems can run the script.

10 years agoMake systemtap.examples/check.exp look for an example's optional tcl file.
David Smith [Thu, 29 Aug 2013 21:28:27 +0000 (16:28 -0500)]
Make systemtap.examples/check.exp look for an example's optional tcl file.

* testsuite/systemtap.examples/check.exp: If the example has an associated
  tcl file, run it.
* testsuite/systemtap.examples/README: Mention new tcl file that can be
  optionally associated with an example.
* testsuite/systemtap.examples/stapgames/pingpong.meta: Add a
  'test_support' tag.
* testsuite/systemtap.examples/virtualization/kvm_service_time.meta: Make
  the 'test_support' tag more specific.
* testsuite/systemtap.examples/process/auditbt.tcl: Skip the example if we
  don't have uprobes.
* testsuite/systemtap.examples/process/mutex-contention.tcl: Ditto.
* testsuite/systemtap.examples/process/threadstacks.tcl: Ditto.
* testsuite/systemtap.examples/profiling/pf4.tcl: Ditto.
* testsuite/systemtap.examples/process/ltrace.tcl: Skip the example if we
  don't have .plt probes.
* testsuite/systemtap.examples/interrupt/scf.tcl: Skip the example if
  we're on ia64, which has no dwarf unwinding support.
* testsuite/systemtap.examples/io/io_submit.tcl: Ditto.
* testsuite/systemtap.examples/io/mbrwatch.tcl: Ditto.
* testsuite/systemtap.examples/process/chng_cpu.tcl: Ditto.
* testsuite/systemtap.examples/process/sleepingBeauties.tcl: Ditto.
* testsuite/systemtap.examples/profiling/latencytap.tcl: Ditto.
* testsuite/systemtap.examples/process/strace.tcl: Skip the example if
  we're on ia64, which doesn't have nd_syscall support.
* testsuite/systemtap.examples/process/thread-business.tcl: Ditto.

10 years agoPR15906: staprun: suppress loading of stap modules in FIPS mode
Frank Ch. Eigler [Thu, 29 Aug 2013 17:02:07 +0000 (13:02 -0400)]
PR15906: staprun: suppress loading of stap modules in FIPS mode

* staprun/staprun.c (insert_stap_module): Check & fear
  /proc/sys/crypto/fips_enabled.

10 years agoFix failures in uprobes_filtering.exp by improving as_non_root().
David Smith [Wed, 28 Aug 2013 20:39:29 +0000 (15:39 -0500)]
Fix failures in uprobes_filtering.exp by improving as_non_root().

* testsuite/lib/systemtap.exp (as_non_root): If we're using user 'nobody',
  override SYSTEMTAP_DIR to '/tmp/.systemtap-nobody'.

10 years agoman page error::pass2: mention stap-prep
Frank Ch. Eigler [Wed, 28 Aug 2013 19:48:28 +0000 (15:48 -0400)]
man page error::pass2: mention stap-prep

10 years agoImprove skipping .plt tests on unsupported systems.
David Smith [Wed, 28 Aug 2013 17:39:41 +0000 (12:39 -0500)]
Improve skipping .plt tests on unsupported systems.

* testsuite/lib/systemtap.exp (plt_probes_p): New function.
* testsuite/systemtap.base/list.exp: Uses 'plt_probes_p' to know to mark
  .plt probe tests as 'untested'.
* testsuite/systemtap.base/plt.exp: Uses 'plt_probes_p'.
* testsuite/systemtap.pass1-4/semok.exp: Ditto.
* testsuite/systemtap.unprivileged/unprivileged_myproc.exp: Ditto.
* testsuite/systemtap.unprivileged/unprivileged_probes.exp: Ditto.

10 years agoImproved spawned process cleanup in bz6850.exp and fib.exp.
David Smith [Wed, 28 Aug 2013 15:35:03 +0000 (10:35 -0500)]
Improved spawned process cleanup in bz6850.exp and fib.exp.

* testsuite/systemtap.base/bz6850.exp: Improved cleanup logic.
* testsuite/systemtap.context/fib.exp: Ditto.

10 years agoUpdate badname.stp example for newer kernels (with inlined may_create()).
David Smith [Wed, 28 Aug 2013 15:31:57 +0000 (10:31 -0500)]
Update badname.stp example for newer kernels (with inlined may_create()).

* testsuite/systemtap.examples/general/badname.stp: Since may_create() is
  now always inlined (and we can't find its arguments), probe
  may_create()'s callers instead.

10 years agoAdd some dyninst XFAILS in sdt_misc.exp.
David Smith [Tue, 27 Aug 2013 21:39:09 +0000 (16:39 -0500)]
Add some dyninst XFAILS in sdt_misc.exp.

* testsuite/systemtap.base/sdt_misc.exp: XFAIL tests that attach to
  processes when testing dyninst.

10 years agoAdd note to NEWS for PR15805.
David Smith [Tue, 27 Aug 2013 19:08:53 +0000 (14:08 -0500)]
Add note to NEWS for PR15805.

10 years agostaprun requires elfutils 0.142+, so always assume we have elf_getshdrstrndx().
David Smith [Tue, 27 Aug 2013 19:05:15 +0000 (14:05 -0500)]
staprun requires elfutils 0.142+, so always assume we have elf_getshdrstrndx().

* staprun/common.c (usage): Always assume we have elf_getshdrstrndx().
* staprun/staprun.c (init_staprun): Ditto.
* staprun/staprun_funcs.c: Ditto.
* configure.ac: For staprun, the lowest version of elfutils we require is
0.142+, which has elf_getshdrstrndx(). So, if elf_getshdrstrndx()
doesn't exist in libelf, fail.
* Makefile.in: Regenerated.
* aclocal.m4: Ditto.
* config.in: Ditto.
* configure: Ditto.
* doc/Makefile.in: Ditto.
* doc/SystemTap_Tapset_Reference/Makefile.in: Ditto.
* doc/beginners/Makefile.in: Ditto.
* java/Makefile.in: Ditto.
* man/Makefile.in: Ditto.
* stapdyn/Makefile.in: Ditto.
* staprun/Makefile.in: Ditto.
* NEWS: Mention staprun requiring elfuilts 0.142+.

10 years agoPR15900 weaken & simplify server_locale.exp test case
Frank Ch. Eigler [Tue, 27 Aug 2013 18:22:37 +0000 (14:22 -0400)]
PR15900 weaken & simplify server_locale.exp test case

The server_locale.exp test case need only confirm that selected
local-related environment variables are passed to the server.  A
smaller & simpler set of tests are sufficient for that.

This also reverts commit dcd8a2ebbcc00ab6aed227ebd721346d81c26a7b.

10 years agoPR15900 fix syntax errors in server_local.exp test case
Martin Cermak [Tue, 27 Aug 2013 15:15:32 +0000 (11:15 -0400)]
PR15900 fix syntax errors in server_local.exp test case

10 years agoBZ998595, systemtap.spec fix disagreement between %file attrs and explicit chmods
Frank Ch. Eigler [Tue, 27 Aug 2013 15:08:35 +0000 (11:08 -0400)]
BZ998595, systemtap.spec fix disagreement between %file attrs and explicit chmods

10 years agoMake pr13158.exp test results less random.
David Smith [Tue, 27 Aug 2013 14:58:22 +0000 (09:58 -0500)]
Make pr13158.exp test results less random.

* testsuite/systemtap.base/pr13158.exp: Make test result less random, by
  making sure the first copy of the module is loaded before trying to load
  the second copy.

10 years agoMake the 'systemtap-testsuite' rpm require 'nc' for ipaddr.exp.
David Smith [Mon, 26 Aug 2013 21:43:40 +0000 (16:43 -0500)]
Make the 'systemtap-testsuite' rpm require 'nc' for ipaddr.exp.

10 years agoMove %changelog pruning into diff check block
Lukas Berk [Fri, 23 Aug 2013 19:05:30 +0000 (15:05 -0400)]
Move %changelog pruning into diff check block

If there is no spec diff, then there's no need to even check for a
difference in the %changelog section.  Furthermore we should check
that there is even a %changelog section in the diff and only attempt
to prune accordingly

scripts/spin-rawhide - move pruning into file check statements

10 years agoTweak spin-rawhide script to stop overwriting the changelog
Lukas Berk [Fri, 23 Aug 2013 18:26:54 +0000 (14:26 -0400)]
Tweak spin-rawhide script to stop overwriting the changelog

scripts/spin-rawhide - when merging an upstream diff, sometimes the
       changelog can be overwritten, which shouldn't happen
       trim the changelog diffs and their context lines

10 years agoTestcase and documentation for minidebuginfo
Lukas Berk [Fri, 23 Aug 2013 15:31:48 +0000 (11:31 -0400)]
Testcase and documentation for minidebuginfo

man/warning::debuginfo.7stap - explain basics of minidebuginfo, note
       that it requires elfutils 0.156 and add
       a pointer to the fedora feature page
testsuite/systemtap.base/ files:
create-minidebuginfo.sh - script to create minidebuginfo
minidebug.c - simple c program with multiple function calls
minidebuginfo.exp  - compile minidebug.c and generate minidebuginfo,
  test that the functions are still listed with
  probefunc()
minidebuginfo.stp - script to probe process.function("*") and list
  probefunc()'s

10 years agoSimplify the testsuite tests for uprobes and utrace
Josh Stone [Thu, 22 Aug 2013 22:39:26 +0000 (15:39 -0700)]
Simplify the testsuite tests for uprobes and utrace

- Searching /proc/kallsyms is now standardized to grep_kallsyms.
- utrace and uprobes tests are broken into separate procs for the
  different variants, then a unified proc combines variants.

10 years agoFix PR15625 by making unprivileged_embedded_C.exp ignore stub functions.
David Smith [Thu, 22 Aug 2013 21:09:47 +0000 (16:09 -0500)]
Fix PR15625 by making unprivileged_embedded_C.exp ignore stub functions.

* testsuite/systemtap.unprivileged/unprivileged_embedded_C.exp: Ignore
  stub functions in registers.stp.

10 years agoFix PR15881 by fixing unprivileged_myproc.exp failures.
David Smith [Thu, 22 Aug 2013 20:31:04 +0000 (15:31 -0500)]
Fix PR15881 by fixing unprivileged_myproc.exp failures.

* testsuite/systemtap.unprivileged/unprivileged_myproc.exp: KFAIL
  '.absolute' and '.absolute.return' probe tests when using inode uprobes,
  since inode uprobes don't support those probe types. For
  'library.plt.statement(NUMBER)' probe tests, use the address of the
  library function, instead of the address of the main program
  function. With the last problem fixed, remove the XFAILS for those probe
  tests (an update to PR13373).

10 years agoAvoid problems for unprivileged users when getting MAXSTRINGLEN value.
David Smith [Thu, 22 Aug 2013 15:34:51 +0000 (10:34 -0500)]
Avoid problems for unprivileged users when getting MAXSTRINGLEN value.

* tapset/macros.stpm: New '@MAXSTRINGLEN' macro.
* tapset/linux/context-caller.stp: To avoid problems for unprivileged
  users, use new '@MAXSTRINGLEN' macro instead of '%{ MAXSTRINGLEN %}'.
* tapset/linux/context-symbols.stp: Ditto.
* tapset/linux/ucontext-symbols.stp: Ditto.
* tapset/linux/ucontext.stp: Ditto.

10 years agoActually add the i386 portions of the spec file fix
Lukas Berk [Thu, 22 Aug 2013 03:37:38 +0000 (23:37 -0400)]
Actually add the i386 portions of the spec file fix

systemtap.spec - add the i386 portions of the arch symlink fix.

10 years agoFix BZ999585 where spec file symlinks don't match java directories
Lukas Berk [Thu, 22 Aug 2013 03:31:20 +0000 (23:31 -0400)]
Fix BZ999585 where spec file symlinks don't match java directories

systemtap.spec - add clauses to catch cases (i386, ppc64) where the
         java directory we want to symlink to doesn't actually
 match the basename type

10 years agoFix PR15876 by making the ptridx.exp testcase more robust.
David Smith [Wed, 21 Aug 2013 21:16:53 +0000 (16:16 -0500)]
Fix PR15876 by making the ptridx.exp testcase more robust.

* testsuite/systemtap.base/ptridx.exp: Set up the timeout value to be 60
  seconds and kills stap if we do have a timeout.

10 years agoPR15074 update: Relaxed pthread_stacks.exp debuginfo check.
David Smith [Wed, 21 Aug 2013 19:55:33 +0000 (14:55 -0500)]
PR15074 update: Relaxed pthread_stacks.exp debuginfo check.

* testsuite/systemtap.base/pthread_stacks.exp: Relaxed debuginfo check a
  bit, since we only need "native" glibc debuginfo installed on multilib
  systems like x86_64.

10 years agoFix PR15875 by making sure 'strace' is on a system before running ptrace.exp.
David Smith [Wed, 21 Aug 2013 18:30:18 +0000 (13:30 -0500)]
Fix PR15875 by making sure 'strace' is on a system before running ptrace.exp.

* testsuite/systemtap.base/ptrace.exp: If 'strace' doesn't exist on the
  system, quit early.
* systemtap.spec: Make 'systemtap-testsuite' require 'strace', since
  ptrace.exp needs it.

10 years agoFix PR15874 by making systemtap.base/onoffprobe.exp more robust.
David Smith [Wed, 21 Aug 2013 17:42:27 +0000 (12:42 -0500)]
Fix PR15874 by making systemtap.base/onoffprobe.exp more robust.

* testsuite/systemtap.base/onoffprobe.exp: Make more robust.
* testsuite/systemtap.base/onoffprobe.stp: Call exit() when finished.

10 years agoFew typos in langref and tutorial
Miroslav Franc [Wed, 21 Aug 2013 11:41:25 +0000 (13:41 +0200)]
Few typos in langref and tutorial

10 years agoFix up 3 XPASS results in the semko.exp testcase.
David Smith [Tue, 20 Aug 2013 21:49:20 +0000 (16:49 -0500)]
Fix up 3 XPASS results in the semko.exp testcase.

* testsuite/systemtap.pass1-4/semko.exp: Mark the utrace.stp test as
  "untested" when using dyninst, since dyninst contains utrace-like
  functionality.
* testsuite/semko/badregex01.stp: Actually add an invalid regexp to the
  testcase.

10 years agoFix PR15866 by updating the signal.pending/signal.pending.return probe aliases.
David Smith [Tue, 20 Aug 2013 19:59:20 +0000 (14:59 -0500)]
Fix PR15866 by updating the signal.pending/signal.pending.return probe aliases.

* tapset/linux/signal.stp: Make the 'signal.pending' and
  'signal.pending.return' probe aliases use 'sys_rt_sigpending' and
  'compat_sys_rt_sigpending' if 'do_sigpending' is an inlined function.

10 years agoFixed PR15865 by updating nfs_proc.stp to handle removal of NFSv2.
David Smith [Tue, 20 Aug 2013 18:22:32 +0000 (13:22 -0500)]
Fixed PR15865 by updating nfs_proc.stp to handle removal of NFSv2.

* tapset/linux/nfs_proc.stp: Handle removal of NFSv2 functions from the
  kernel. Aliased all NFSv2 functions to 'never' if not present.

10 years agostrace example: add a note re. PR6762
Frank Ch. Eigler [Tue, 20 Aug 2013 10:11:30 +0000 (06:11 -0400)]
strace example: add a note re. PR6762

The reminder was motivated by coming across Jan Kratoch's much more
elaborate strace-in-systemtap prototype, which solves this problem:
http://git.jankratochvil.net/?p=staptrace.git

This page took 0.063783 seconds and 5 git commands to generate.