]> sourceware.org Git - lvm2.git/log
lvm2.git
16 years agoMakefile.in: correct distclean rule
Jim Meyering [Thu, 12 Jun 2008 09:48:45 +0000 (09:48 +0000)]
Makefile.in: correct distclean rule

* Makefile.in (SUBDIRS): Remove long-unused test/* names.
(SUBDIRS) [distclean]: Append "test".
Discovered with Zdeněk Kabeláč.

16 years agobreak (rather than return) so we have only one point of return
Jim Meyering [Wed, 11 Jun 2008 15:02:52 +0000 (15:02 +0000)]
break (rather than return) so we have only one point of return

* tools/toollib.c (process_each_segment_in_lv): Upon sigint_caught,
break rather than returning ret_max.  No semantic change.

16 years agocopy vgid only when volume group is present in import_pool_pv
Zdenek Kabelac [Wed, 11 Jun 2008 13:14:41 +0000 (13:14 +0000)]
copy vgid only when volume group is present in import_pool_pv

16 years agopost-release
Alasdair Kergon [Wed, 11 Jun 2008 12:14:41 +0000 (12:14 +0000)]
post-release

16 years agopre-release
Alasdair Kergon [Wed, 11 Jun 2008 12:08:19 +0000 (12:08 +0000)]
pre-release

16 years agoFix tracking of validity of PVs with no mdas in lvmcache.
Alasdair Kergon [Wed, 11 Jun 2008 11:02:05 +0000 (11:02 +0000)]
Fix tracking of validity of PVs with no mdas in lvmcache.

16 years agoFix return values for reporting commands when run with no PVs, LVs, or VGs.
Dave Wysochanski [Tue, 10 Jun 2008 20:07:04 +0000 (20:07 +0000)]
Fix return values for reporting commands when run with no PVs, LVs, or VGs.
The new error checking code caught some commands that were returning '0' as
an exit status for success.  This is incorrect and resulted in a benign error
message displayed (see below).  As of today, all commands should return a
value defined in lib/commands/errors.h (1-5).  This results in an exit code of
0 on success, or > 0 on failure (as stated in the lvm.8 man page).

Before change:
1. Make sure no PVs are on the system
2. Run 'pvs'
  Command failed with status code 0.

After change:
<no output>

16 years agoAdd ommitted unlock_vg() call when sigint_caught() during vg processing.
Dave Wysochanski [Tue, 10 Jun 2008 15:25:38 +0000 (15:25 +0000)]
Add ommitted unlock_vg() call when sigint_caught() during vg processing.

Specific test case:
1. pvcreate /dev/loop1; vgcreate vg1 /dev/loop1; lvcreate -L 64M -n lv1 vg1
2. vgremove vg1 (will prompt user)
3. CTRL-C
Code will exit with:
Do you really want to remove volume group "vg2" containing 2 logical volumes? [y/n]:
  Volume group "vg2" not removed
  Command failed with status code 5.
  Internal error: Volume Group vg2 was not unlocked
  Device '/dev/loop1' has been left open.

After change:
Do you really want to remove volume group "vg2" containing 2 logical volumes? [y/n]:
  Volume group "vg2" not removed
  Command failed with status code 5.

16 years agoFix wrong free_count on imported volume group from pool device
Zdenek Kabelac [Tue, 10 Jun 2008 14:55:14 +0000 (14:55 +0000)]
Fix wrong free_count on imported volume group from pool device
Fix segfault when calling pvcreate on the pool device

16 years agoFix inverted no_flush debug message. (mpatocka)
Alasdair Kergon [Tue, 10 Jun 2008 11:19:19 +0000 (11:19 +0000)]
Fix inverted no_flush debug message. (mpatocka)

16 years agoFix segfault after _free_vginfo by remembering to remove vginfo from list.
Alasdair Kergon [Mon, 9 Jun 2008 16:22:33 +0000 (16:22 +0000)]
Fix segfault after _free_vginfo by remembering to remove vginfo from list.

16 years agoAdd simple test case to repro pvs segfault with duplicate vgnames.
Dave Wysochanski [Mon, 9 Jun 2008 15:31:58 +0000 (15:31 +0000)]
Add simple test case to repro pvs segfault with duplicate vgnames.

16 years agobring list.h into line with lvm2
Alasdair Kergon [Sun, 8 Jun 2008 14:53:51 +0000 (14:53 +0000)]
bring list.h into line with lvm2

16 years agoTweak detection of invalid fid after changes to PVs in VG in _vg_read.
Alasdair Kergon [Sun, 8 Jun 2008 14:18:44 +0000 (14:18 +0000)]
Tweak detection of invalid fid after changes to PVs in VG in _vg_read.

16 years agoRevert assuming precommitted metadata is live when activating (unnecessary).
Alasdair Kergon [Sun, 8 Jun 2008 11:33:15 +0000 (11:33 +0000)]
Revert assuming precommitted metadata is live when activating (unnecessary).

16 years ago.
Alasdair Kergon [Fri, 6 Jun 2008 20:45:41 +0000 (20:45 +0000)]
.

16 years agorename some config vars
Alasdair Kergon [Fri, 6 Jun 2008 20:44:35 +0000 (20:44 +0000)]
rename some config vars

16 years agoBring configure.in into line with the lvm2 version.
Alasdair Kergon [Fri, 6 Jun 2008 20:33:13 +0000 (20:33 +0000)]
Bring configure.in into line with the lvm2 version.

16 years agoDrop cached metadata for disappearing VG in vgmerge.
Alasdair Kergon [Fri, 6 Jun 2008 19:32:35 +0000 (19:32 +0000)]
Drop cached metadata for disappearing VG in vgmerge.

16 years agopost-release
Alasdair Kergon [Fri, 6 Jun 2008 19:28:35 +0000 (19:28 +0000)]
post-release

16 years agopre-release
Alasdair Kergon [Fri, 6 Jun 2008 19:09:19 +0000 (19:09 +0000)]
pre-release

16 years agoswitch to single quotes rather than double for nameprefixes
Alasdair Kergon [Fri, 6 Jun 2008 19:07:47 +0000 (19:07 +0000)]
switch to single quotes rather than double for nameprefixes

16 years agonameprefixes
Alasdair Kergon [Fri, 6 Jun 2008 18:53:26 +0000 (18:53 +0000)]
nameprefixes

16 years agochange --prefixes to --nameprefixes
Alasdair Kergon [Fri, 6 Jun 2008 18:53:08 +0000 (18:53 +0000)]
change --prefixes to --nameprefixes

16 years agoback out unnecessary changes for this release
Alasdair Kergon [Fri, 6 Jun 2008 17:36:19 +0000 (17:36 +0000)]
back out unnecessary changes for this release

16 years agopre-release
Alasdair Kergon [Fri, 6 Jun 2008 17:24:28 +0000 (17:24 +0000)]
pre-release

16 years agocleaner LCK_LV decoding
Alasdair Kergon [Fri, 6 Jun 2008 16:37:51 +0000 (16:37 +0000)]
cleaner LCK_LV decoding

16 years agocache dropping needs to use old name not new
Alasdair Kergon [Fri, 6 Jun 2008 16:13:35 +0000 (16:13 +0000)]
cache dropping needs to use old name not new
rename variable to reduce confusion

16 years ago* lvm-utils.sh (init_root_dir_): Correct a diagnostic.
Jim Meyering [Fri, 6 Jun 2008 13:48:57 +0000 (13:48 +0000)]
* lvm-utils.sh (init_root_dir_): Correct a diagnostic.

Author: Jim Meyering <meyering@redhat.com>

16 years agoDrop cached metadata when renaming a VG.
Alasdair Kergon [Fri, 6 Jun 2008 13:04:44 +0000 (13:04 +0000)]
Drop cached metadata when renaming a VG.

16 years agofix _free_vginfo not to remove a ref to a *different* vginfo from the vgid cache
Alasdair Kergon [Fri, 6 Jun 2008 12:43:40 +0000 (12:43 +0000)]
fix _free_vginfo not to remove a ref to a *different* vginfo from the vgid cache

16 years agocope with volatile vginfo in vg_read
Alasdair Kergon [Fri, 6 Jun 2008 11:12:50 +0000 (11:12 +0000)]
cope with volatile vginfo in vg_read

16 years agoAllow for vginfo changing during _vg_read.
Alasdair Kergon [Fri, 6 Jun 2008 09:48:04 +0000 (09:48 +0000)]
Allow for vginfo changing during _vg_read.

16 years agoInitialise params buffer to empty string in _emit_segment.
Alasdair Kergon [Thu, 5 Jun 2008 19:10:35 +0000 (19:10 +0000)]
Initialise params buffer to empty string in _emit_segment.

16 years agoDecode numbers in clvmd debugging output.
Alasdair Kergon [Thu, 5 Jun 2008 14:24:28 +0000 (14:24 +0000)]
Decode numbers in clvmd debugging output.

16 years agoAdd missing deactivation after activation failure in lvcreate -Zy.
Alasdair Kergon [Thu, 5 Jun 2008 13:38:30 +0000 (13:38 +0000)]
Add missing deactivation after activation failure in lvcreate -Zy.

16 years agoWhen activating, if precommitted metadata is still cached, assume it's live.
Alasdair Kergon [Thu, 5 Jun 2008 13:06:39 +0000 (13:06 +0000)]
When activating, if precommitted metadata is still cached, assume it's live.

16 years agoWhen removing LV symlinks, skip any where the VG name is not determined.
Alasdair Kergon [Thu, 5 Jun 2008 12:45:55 +0000 (12:45 +0000)]
When removing LV symlinks, skip any where the VG name is not determined.

16 years agoDrop metadata cache if update fails in vg_revert or vg_commit.
Alasdair Kergon [Tue, 3 Jun 2008 17:56:54 +0000 (17:56 +0000)]
Drop metadata cache if update fails in vg_revert or vg_commit.

16 years agoCorrect config file line numbers in messages when parsing comments. (kabi)
Alasdair Kergon [Tue, 3 Jun 2008 17:51:04 +0000 (17:51 +0000)]
Correct config file line numbers in messages when parsing comments. (kabi)

16 years agosuppress warning on silent failure with ECMD_PROCESSED
Alasdair Kergon [Tue, 3 Jun 2008 17:48:13 +0000 (17:48 +0000)]
suppress warning on silent failure with ECMD_PROCESSED

16 years agoTrivial fix to lvchange man pg for consistency.
Dave Wysochanski [Mon, 2 Jun 2008 15:54:32 +0000 (15:54 +0000)]
Trivial fix to lvchange man pg for consistency.

16 years agoIn script-processing mode, stop if any command fails.
Alasdair Kergon [Fri, 30 May 2008 15:27:44 +0000 (15:27 +0000)]
In script-processing mode, stop if any command fails.
Warn if command exits with non-zero status code without a prior log_error.

16 years agofix setpriority int error
Alasdair Kergon [Wed, 28 May 2008 23:12:45 +0000 (23:12 +0000)]
fix setpriority int error

16 years agoAvoid spurious duplicate VG messages referring to VGs that are gone.
Alasdair Kergon [Wed, 28 May 2008 22:27:47 +0000 (22:27 +0000)]
Avoid spurious duplicate VG messages referring to VGs that are gone.
(untested)

16 years agoSkip add_dev_node when ioctls disabled.
Alasdair Kergon [Wed, 21 May 2008 16:14:46 +0000 (16:14 +0000)]
Skip add_dev_node when ioctls disabled.
Make dm_hash_iter safe against deletion.
Accept a NULL pointer to dm_free silently.

16 years agoTemporarily disable dmeventd mirror monitoring during lvchange --resync.
Alasdair Kergon [Wed, 21 May 2008 14:10:11 +0000 (14:10 +0000)]
Temporarily disable dmeventd mirror monitoring during lvchange --resync.

16 years agorevert accidental checkin
Alasdair Kergon [Mon, 19 May 2008 20:06:34 +0000 (20:06 +0000)]
revert accidental checkin

16 years agoRefactor some vginfo manipulation code.
Alasdair Kergon [Mon, 19 May 2008 19:49:56 +0000 (19:49 +0000)]
Refactor some vginfo manipulation code.

16 years agomore cleanup
Alasdair Kergon [Fri, 9 May 2008 19:26:58 +0000 (19:26 +0000)]
more cleanup

16 years agoMore P_ and V_ lock cleanup.
Alasdair Kergon [Fri, 9 May 2008 18:45:15 +0000 (18:45 +0000)]
More P_ and V_ lock cleanup.

16 years agoAdd missing mutex around clvmd lvmcache_drop_metadata library call.
Alasdair Kergon [Fri, 9 May 2008 15:13:20 +0000 (15:13 +0000)]
Add missing mutex around clvmd lvmcache_drop_metadata library call.

16 years agoFix uninitialised mutex in clvmd if all daemons are not running at startup.
Christine Caulfield [Fri, 9 May 2008 09:59:39 +0000 (09:59 +0000)]
Fix uninitialised mutex in clvmd if all daemons are not running at startup.

Thanks to Mark Hlawatschek for pointing this out.

16 years agoMake clvmd-cman use a hash rather than an array for node updown info.
Christine Caulfield [Fri, 9 May 2008 07:20:04 +0000 (07:20 +0000)]
Make clvmd-cman use a hash rather than an array for node updown info.
This will allow it to cope with very large nodeids such as those
generated by clusters using cman_tool join -X

16 years agoAvoid unnecessary unlock attempts with LCK_CACHE pseudo-locks.
Alasdair Kergon [Thu, 8 May 2008 18:35:58 +0000 (18:35 +0000)]
Avoid unnecessary unlock attempts with LCK_CACHE pseudo-locks.

16 years agoWhen asked to drop cached committed VG metadata, invalidate cached PV labels.
Alasdair Kergon [Thu, 8 May 2008 18:28:27 +0000 (18:28 +0000)]
When asked to drop cached committed VG metadata, invalidate cached PV labels.

16 years agoDrop metadata cache before writing precommitted metadata instead of after.
Alasdair Kergon [Thu, 8 May 2008 18:06:58 +0000 (18:06 +0000)]
Drop metadata cache before writing precommitted metadata instead of after.

16 years agoremove unused lvmcache_drop_vg prototype
Alasdair Kergon [Thu, 8 May 2008 18:00:47 +0000 (18:00 +0000)]
remove unused lvmcache_drop_vg prototype

16 years agoDon't touch /dev in vgrename if activation is disabled.
Alasdair Kergon [Wed, 30 Apr 2008 14:34:02 +0000 (14:34 +0000)]
Don't touch /dev in vgrename if activation is disabled.

16 years agopost-release - reinstate incomplete enhancements
Alasdair Kergon [Tue, 29 Apr 2008 16:11:28 +0000 (16:11 +0000)]
post-release - reinstate incomplete enhancements

16 years agopre-release (bug fixes only - enhancements excluded)
Alasdair Kergon [Tue, 29 Apr 2008 15:58:25 +0000 (15:58 +0000)]
pre-release (bug fixes only - enhancements excluded)

16 years agofixing fsadm usage with older blockdev,blkid,readline tools
Zdenek Kabelac [Tue, 29 Apr 2008 15:25:28 +0000 (15:25 +0000)]
fixing fsadm usage with older blockdev,blkid,readline tools
fixing lvresize extension code path where size was not set for fsadm

16 years ago. remove_lock_wait.diff remove the definition of "struct lock_wait",
Christine Caulfield [Tue, 29 Apr 2008 08:55:20 +0000 (08:55 +0000)]
. remove_lock_wait.diff remove the definition of "struct lock_wait",
which is not used since the switch away from async version saLck
. num_nodes should equal to member_list_entries, i.e.
joined_list_entires is 0 when a node leaves the group.

Thanks to Xinwei Hu for the patch.

16 years agoThe attached patch is a try to make clvmd work correctly on openais stack.
Christine Caulfield [Mon, 28 Apr 2008 08:57:11 +0000 (08:57 +0000)]
The attached patch is a try to make clvmd work correctly on openais stack.
It does 2 things.

1. The cpg_deliver_callback make a compare between target_nodeid and our_nodeid.
It turns out openais set target_nodeid to 0 sometimes. for broadcasting ? I change the behavior so that lvm will process_remote also on target_nodeid == 0

2. The joined_list passed to cpg_confchg_callback doesn't include the already exist nodes in the group, which leads to an incomplete node_hash. I simply add all other nodes in member_list to node_hash also.

Thanks to Xinwei Hu for this patch.

16 years agoExclude VG_GLOBAL from internal concurrent VG lock counter.
Alasdair Kergon [Thu, 24 Apr 2008 02:22:07 +0000 (02:22 +0000)]
Exclude VG_GLOBAL from internal concurrent VG lock counter.
(Avoids 'device left open' warning messages from vgscan etc.)

16 years agoAdd test for rhbz440405 - lvconvert -m0 fails incorrectly if all PEs allocated.
Dave Wysochanski [Wed, 23 Apr 2008 18:27:59 +0000 (18:27 +0000)]
Add test for rhbz440405 - lvconvert -m0 fails incorrectly if all PEs allocated.

16 years agoFix vgsplit internal counting of snapshot LVs.
Dave Wysochanski [Wed, 23 Apr 2008 14:33:06 +0000 (14:33 +0000)]
Fix vgsplit internal counting of snapshot LVs.

16 years agoUpdate test function _check_{vg|lv|pv}_field to aid in test debug.
Dave Wysochanski [Wed, 23 Apr 2008 13:02:03 +0000 (13:02 +0000)]
Update test function _check_{vg|lv|pv}_field to aid in test debug.

Author: Dave Wysochanski <dwysocha@redhat.com>

16 years agoFix internal snapshot_count when vgmerge with snapshots in source VG.
Dave Wysochanski [Wed, 23 Apr 2008 12:53:10 +0000 (12:53 +0000)]
Fix internal snapshot_count when vgmerge with snapshots in source VG.

16 years agoSimplify locking code by using saLckResourceLock rather than
Christine Caulfield [Wed, 23 Apr 2008 09:53:49 +0000 (09:53 +0000)]
Simplify locking code by using saLckResourceLock rather than
saLckResourceLockAsync.

Thanks to Xinwei Hu for the patch.

16 years agoCheck lv_count in vg_validate.
Alasdair Kergon [Tue, 22 Apr 2008 12:54:33 +0000 (12:54 +0000)]
Check lv_count in vg_validate.
Fix internal LV counter when a snapshot is removed.

16 years agoFix metadata corruption writing lvm1-formatted metadata with snapshots.
Alasdair Kergon [Tue, 22 Apr 2008 11:47:22 +0000 (11:47 +0000)]
Fix metadata corruption writing lvm1-formatted metadata with snapshots.

16 years agoUse 'active' for !suspended as the code already uses that.
Alasdair Kergon [Mon, 21 Apr 2008 16:57:11 +0000 (16:57 +0000)]
Use 'active' for !suspended as the code already uses that.

16 years agoAdd 3 new reporting colums: tables_loaded, readonly, suspended.
Alasdair Kergon [Mon, 21 Apr 2008 13:16:30 +0000 (13:16 +0000)]
Add 3 new reporting colums: tables_loaded, readonly, suspended.

16 years agoAdd --prefixes to dmsetup
Alasdair Kergon [Mon, 21 Apr 2008 11:59:22 +0000 (11:59 +0000)]
Add --prefixes to dmsetup

E.g. dmsetup info -c --prefixes

Again, might change the name of this option.

16 years agoAdd --prefixes to reporting tools for field name prefix output format.
Alasdair Kergon [Sun, 20 Apr 2008 00:15:08 +0000 (00:15 +0000)]
Add --prefixes to reporting tools for field name prefix output format.

E.g. lvs --prefixes --noheadings --unbuffered --units m --nosuffix

(Used '--prefixes' for now, but I'm looking for a better name.)

16 years agoAdd field name prefix option to reporting functions.
Alasdair Kergon [Sun, 20 Apr 2008 00:11:08 +0000 (00:11 +0000)]
Add field name prefix option to reporting functions.

16 years agoCalculate string size within dm_pool_grow_object.
Alasdair Kergon [Sat, 19 Apr 2008 15:50:18 +0000 (15:50 +0000)]
Calculate string size within dm_pool_grow_object.

16 years agoFix lvconvert -m0 allocatable space check.
Alasdair Kergon [Fri, 18 Apr 2008 12:50:24 +0000 (12:50 +0000)]
Fix lvconvert -m0 allocatable space check.

16 years agopost-release
Alasdair Kergon [Tue, 15 Apr 2008 15:01:18 +0000 (15:01 +0000)]
post-release

16 years agomissing stack
Alasdair Kergon [Tue, 15 Apr 2008 14:57:12 +0000 (14:57 +0000)]
missing stack

16 years agopre-release
Alasdair Kergon [Tue, 15 Apr 2008 14:49:17 +0000 (14:49 +0000)]
pre-release

16 years agoDrop cached VG metadata before and after committing changes to it.
Milan Broz [Tue, 15 Apr 2008 14:46:19 +0000 (14:46 +0000)]
Drop cached VG metadata before and after committing changes to it.

16 years agorename P_global to P_#global
Alasdair Kergon [Tue, 15 Apr 2008 11:36:46 +0000 (11:36 +0000)]
rename P_global to P_#global

16 years agoDon't attempt remote metadata backups of non-clustered VGs. (2.02.29)
Alasdair Kergon [Mon, 14 Apr 2008 19:49:12 +0000 (19:49 +0000)]
Don't attempt remote metadata backups of non-clustered VGs. (2.02.29)

16 years agoDon't store fid in VG metadata cache to avoid clvmd segfault. (2.02.34)
Alasdair Kergon [Mon, 14 Apr 2008 19:24:16 +0000 (19:24 +0000)]
Don't store fid in VG metadata cache to avoid clvmd segfault. (2.02.34)

16 years agoFix vgsplit and vgmerge tests for updated lv counting.
Dave Wysochanski [Fri, 11 Apr 2008 14:06:16 +0000 (14:06 +0000)]
Fix vgsplit and vgmerge tests for updated lv counting.

16 years agoUpdate vgsplit test to verify loosening of active LV restriction.
Dave Wysochanski [Thu, 10 Apr 2008 21:38:52 +0000 (21:38 +0000)]
Update vgsplit test to verify loosening of active LV restriction.

This and prior 2 commits resolve Red Hat bz 252041:
Ability to vgsplit an active Volume Group where the split involves only inactive LVs

16 years agoUpdate vgsplit to only restrict split with active LVs involved in split.
Dave Wysochanski [Thu, 10 Apr 2008 21:34:53 +0000 (21:34 +0000)]
Update vgsplit to only restrict split with active LVs involved in split.

Existing code will reject a vgsplit if any LVs in the source VG are active.
This patch updates vgsplit to only check LVs involved in the split.

16 years agoAdd lv_is_active() to determine whether an lv is active.
Dave Wysochanski [Thu, 10 Apr 2008 21:34:18 +0000 (21:34 +0000)]
Add lv_is_active() to determine whether an lv is active.

Handles non-clustered as well as clustered.  For clustered,
the best we can do is try exclusive local activation.  If this
succeeds, we know it is not active elsewhere in the cluster.
Otherwise, we assume it is active elsewhere.

16 years agopost-release
Alasdair Kergon [Thu, 10 Apr 2008 20:07:19 +0000 (20:07 +0000)]
post-release

16 years ago.
Alasdair Kergon [Thu, 10 Apr 2008 20:02:04 +0000 (20:02 +0000)]
.

16 years agomore pre-release cleanup
Alasdair Kergon [Thu, 10 Apr 2008 19:59:43 +0000 (19:59 +0000)]
more pre-release cleanup

16 years agofix 3rd copy
Alasdair Kergon [Thu, 10 Apr 2008 19:16:35 +0000 (19:16 +0000)]
fix 3rd copy

16 years agomake list_move consistent with other list fns
Alasdair Kergon [Thu, 10 Apr 2008 19:14:27 +0000 (19:14 +0000)]
make list_move consistent with other list fns

16 years agoUpdate vgsplit tests that count LVs for adjusted LV counting.
Dave Wysochanski [Thu, 10 Apr 2008 18:55:40 +0000 (18:55 +0000)]
Update vgsplit tests that count LVs for adjusted LV counting.

16 years ago.
Alasdair Kergon [Thu, 10 Apr 2008 18:53:36 +0000 (18:53 +0000)]
.

16 years agopre-release
Alasdair Kergon [Thu, 10 Apr 2008 18:19:49 +0000 (18:19 +0000)]
pre-release

16 years agopost-release
Alasdair Kergon [Thu, 10 Apr 2008 18:04:31 +0000 (18:04 +0000)]
post-release

16 years agopre-release
Alasdair Kergon [Thu, 10 Apr 2008 18:00:45 +0000 (18:00 +0000)]
pre-release

This page took 0.065386 seconds and 5 git commands to generate.