]> sourceware.org Git - glibc.git/log
glibc.git
21 months agocsu: Disable stack protector for static-reloc for static-pie
Adhemerval Zanella [Wed, 5 Oct 2022 17:07:28 +0000 (14:07 -0300)]
csu: Disable stack protector for static-reloc for static-pie

For instance on x86_64 with gcc 12.1.1 andwith fstack-protector
enabled the empty function still generates a stack protector code
sequence:

  0000000000000000 <_dl_relocate_static_pie>:
     0:   48 83 ec 18             sub    $0x18,%rsp
     4:   64 48 8b 04 25 28 00    mov    %fs:0x28,%rax
     b:   00 00
     d:   48 89 44 24 08          mov    %rax,0x8(%rsp)
    12:   31 c0                   xor    %eax,%eax
    14:   48 8b 44 24 08          mov    0x8(%rsp),%rax
    19:   64 48 2b 04 25 28 00    sub    %fs:0x28,%rax
    20:   00 00
    22:   75 05                   jne    29 <_dl_relocate_static_pie+0x29>
    24:   48 83 c4 18             add    $0x18,%rsp
    28:   c3                      ret
    29:   e8 00 00 00 00          call   2e <_dl_relocate_static_pie+0x2e>

And since the function is called prior thread pointer setup, it
triggers a invalid memory access (this is shown with the failure
of elf/tst-tls1-static-non-pie).

Although it might characterizes as compiler issue or missed
optimization, to be safe also disables stack protector on
static-reloc object.

Checked on x86_64-linux-gnu and sparc64-linux-gnu.
Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
21 months agoNEWS: Fix grammar
Andreas Schwab [Thu, 6 Oct 2022 11:17:16 +0000 (13:17 +0200)]
NEWS: Fix grammar

21 months agoelf: Simplify output of hwcap subdirectories in ld.so help
Javier Pello [Tue, 27 Sep 2022 18:10:08 +0000 (20:10 +0200)]
elf: Simplify output of hwcap subdirectories in ld.so help

The print_hwcap_1 machinery was useful for the legacy hwcaps
subdirectories, but it is not worth the trouble now that they
are gone.

Signed-off-by: Javier Pello <devel@otheo.eu>
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
21 months agoelf: Remove _dl_string_hwcap
Javier Pello [Tue, 27 Sep 2022 18:09:28 +0000 (20:09 +0200)]
elf: Remove _dl_string_hwcap

Removal of legacy hwcaps support from the dynamic loader left
no users of _dl_string_hwcap.

Signed-off-by: Javier Pello <devel@otheo.eu>
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
21 months agoAdd NEWS entry for legacy hwcaps removal
Javier Pello [Tue, 27 Sep 2022 18:08:47 +0000 (20:08 +0200)]
Add NEWS entry for legacy hwcaps removal

Add a NEWS entry noting the removal of the legacy hwcaps search
mechanism for shared objects.

Signed-off-by: Javier Pello <devel@otheo.eu>
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
21 months agoelf: Remove hwcap and bits_hwcap fields from struct cache_entry
Javier Pello [Tue, 27 Sep 2022 18:08:09 +0000 (20:08 +0200)]
elf: Remove hwcap and bits_hwcap fields from struct cache_entry

They were set to 0 on initialisation and never changed later after
last commit.

Signed-off-by: Javier Pello <devel@otheo.eu>
Reviewed-by: Florian Weimer <fweimer@redhat.com>
21 months agoelf: Remove hwcap parameter from add_to_cache signature
Javier Pello [Tue, 27 Sep 2022 18:07:24 +0000 (20:07 +0200)]
elf: Remove hwcap parameter from add_to_cache signature

Last commit made it so that the value passed for that parameter was
always 0 at its only call site.

Signed-off-by: Javier Pello <devel@otheo.eu>
Reviewed-by: Florian Weimer <fweimer@redhat.com>
21 months agoelf: Remove legacy hwcaps support from ldconfig
Javier Pello [Tue, 27 Sep 2022 18:06:45 +0000 (20:06 +0200)]
elf: Remove legacy hwcaps support from ldconfig

Remove support for the legacy hwcaps subdirectories from ldconfig.

Signed-off-by: Javier Pello <devel@otheo.eu>
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
21 months agoelf: Remove legacy hwcaps support from the dynamic loader
Javier Pello [Tue, 27 Sep 2022 18:05:59 +0000 (20:05 +0200)]
elf: Remove legacy hwcaps support from the dynamic loader

Remove support for the legacy hwcaps subdirectories from the dynamic
loader.

Signed-off-by: Javier Pello <devel@otheo.eu>
Reviewed-by: Florian Weimer <fweimer@redhat.com>
21 months agox86_64: Remove platform directory library loading test
Javier Pello [Tue, 27 Sep 2022 18:05:15 +0000 (20:05 +0200)]
x86_64: Remove platform directory library loading test

This was to test loading of shared libraries from platform
subdirectories, but this functionality is going away in the
following commits.

Signed-off-by: Javier Pello <devel@otheo.eu>
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
21 months agoUpdate to Unicode 15.0.0 [BZ #29604]
Mike FABIAN [Thu, 29 Sep 2022 14:04:42 +0000 (16:04 +0200)]
Update to Unicode 15.0.0 [BZ #29604]

Unicode 15.0.0 Support: Character encoding, character type info, and
transliteration tables are all updated to Unicode 15.0.0, using
the generator scripts contributed by Mike FABIAN (Red Hat).

    Total added characters in newly generated CHARMAP: 4489
    Total removed characters in newly generated WIDTH: 0
    Total changed characters in newly generated WIDTH: 0
    Total added characters in newly generated WIDTH: 4257

    alpha: Added 4389 characters in new ctype which were not in old ctype
    combining: Added 42 characters in new ctype which were not in old ctype
    combining_level3: Added 34 characters in new ctype which were not in old ctype
    graph: Added 4489 characters in new ctype which were not in old ctype
    lower: Added 73 characters in new ctype which were not in old ctype
    print: Added 4489 characters in new ctype which were not in old ctype
    punct: Missing 5 characters of old ctype in new ctype
        punct: Missing: ఄ 0xc04 TELUGU SIGN COMBINING ANUSVARA ABOVE
        punct: Missing: ྂ 0xf82 TIBETAN SIGN NYI ZLA NAA DA
        punct: Missing: ྃ 0xf83 TIBETAN SIGN SNA LDAN
        punct: Missing: 𑂀 0x11080 KAITHI SIGN CANDRABINDU
        punct: Missing: 𑂁 0x11081 KAITHI SIGN ANUSVARA
            That’s OK, because these are now Alphabetic in DerivedCoreProperties.txt
    punct: Added 105 characters in new ctype which were not in old ctype

Resolves: BZ #29604
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
21 months agoUpdate kernel version to 6.0 in header constant tests
Joseph Myers [Wed, 5 Oct 2022 22:11:27 +0000 (22:11 +0000)]
Update kernel version to 6.0 in header constant tests

This patch updates the kernel version in the tests tst-mman-consts.py,
tst-mount-consts.py and tst-pidfd-consts.py to 6.0.  (There are no new
constants covered by these tests in 6.0 that need any other header
changes.)

Tested with build-many-glibcs.py.

21 months agox86: Fix -Os build (BZ #29576)
Adhemerval Zanella Netto [Wed, 21 Sep 2022 13:51:08 +0000 (10:51 -0300)]
x86: Fix -Os build (BZ #29576)

The compiler might transform __stpcpy calls (which are routed to
__builtin_stpcpy as an optimization) to strcpy and x86_64 strcpy
multiarch implementation does not build any working symbol due
ISA_SHOULD_BUILD not being evaluated for IS_IN(rtld).

Checked on x86_64-linux-gnu.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>
21 months agosunrpc: Suppress GCC -Os warning on user2netname
Adhemerval Zanella Netto [Wed, 21 Sep 2022 13:51:07 +0000 (10:51 -0300)]
sunrpc: Suppress GCC -Os warning on user2netname

GCC with -Os warns that sprint might overflow:

  netname.c: In function ‘user2netname’:
  netname.c:51:28: error: ‘%s’ directive writing up to 255 bytes into a
  region of size between 239 and 249 [-Werror=format-overflow=]
     51 |   sprintf (netname, "%s.%d@%s", OPSYS, uid, dfltdom);
        |                            ^~               ~~~~~~~
  netname.c:51:3: note: ‘sprintf’ output between 8 and 273 bytes into a
  destination of size 256
     51 |   sprintf (netname, "%s.%d@%s", OPSYS, uid, dfltdom);
        |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  cc1: all warnings being treated as errors

However the code does test prior the sprintf call that dfltdom plus
the required extra space for OPSYS, uid, and extra character will not
overflow and return 0 instead.

Checked on x86_64-linux-gnu and i686-linux-gnu.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>
21 months agort: Initialize mq_send input on tst-mqueue{5,6}
Adhemerval Zanella Netto [Wed, 21 Sep 2022 13:51:06 +0000 (10:51 -0300)]
rt: Initialize mq_send input on tst-mqueue{5,6}

GCC with -Os warns that the mq_send input may be used uninitialized.
Although for the tests the data content sent is not important, since
both tests checks only if mq_notify was properly set, the warning is
correct and data is indeed uninitialized.

Checked on x86_64-linux-gnu and i686-linux-gnu.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>
21 months agoposix: Suppress -Os may be used uninitialized warnings on regexec
Adhemerval Zanella Netto [Wed, 21 Sep 2022 13:51:05 +0000 (10:51 -0300)]
posix: Suppress -Os may be used uninitialized warnings on regexec

GCC with -Os issues may uninitialized warnings on regexec code.

Checked on x86_64-linux-gnu and i686-linux-gnu.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>
21 months agoposix: Suppress -Os warnings on fnmatch
Adhemerval Zanella Netto [Wed, 21 Sep 2022 13:51:04 +0000 (10:51 -0300)]
posix: Suppress -Os warnings on fnmatch

GCC with -Os issues some may uninitialized warnings on fnmatch code.
All of the variables are already set when they are accessed on the
loop prior.

Checked on x86_64-linux-gnu and i686-linux-gnu.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>
21 months agolocale: prevent maybe-uninitialized errors with -Os [BZ #19444]
Martin Jansa [Wed, 21 Sep 2022 13:51:03 +0000 (10:51 -0300)]
locale: prevent maybe-uninitialized errors with -Os [BZ #19444]

Fixes following error when building  with -Os:
| In file included from strcoll_l.c:43:
| strcoll_l.c: In function '__strcoll_l':
| ../locale/weight.h:31:26: error: 'seq2.back_us' may be used
uninitialized in this function [-Werror=maybe-uninitialized]
|    int_fast32_t i = table[*(*cpp)++];
|                           ^~~~~~~~~
| strcoll_l.c:304:18: note: 'seq2.back_us' was declared here
|    coll_seq seq1, seq2;
|                   ^~~~
| In file included from strcoll_l.c:43:
| ../locale/weight.h:31:26: error: 'seq1.back_us' may be used
uninitialized in this function [-Werror=maybe-uninitialized]
|    int_fast32_t i = table[*(*cpp)++];
|                           ^~~~~~~~~
| strcoll_l.c:304:12: note: 'seq1.back_us' was declared here
|    coll_seq seq1, seq2;
|             ^~~~
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>
21 months agoRegenerate sysdeps/mach/hurd/bits/errno.h
Joseph Myers [Wed, 5 Oct 2022 19:21:25 +0000 (19:21 +0000)]
Regenerate sysdeps/mach/hurd/bits/errno.h

This addition to the list of source headers in
sysdeps/mach/hurd/bits/errno.h appears in the source tree after
build-many-glibcs.py runs, I'm guessing resulting from gnumach commit
c566ad85a2d6728ebc8ec0f461a3b35df300e96e.

21 months agoUpdate syscall lists for Linux 6.0
Joseph Myers [Wed, 5 Oct 2022 14:33:14 +0000 (14:33 +0000)]
Update syscall lists for Linux 6.0

Linux 6.0 has no new syscalls.  Update the version number in
syscall-names.list to reflect that it is still current for 6.0.

Tested with build-many-glibcs.py.

21 months agonscd: Drop local address tuple variable [BZ #29607]
Siddhesh Poyarekar [Tue, 4 Oct 2022 22:40:25 +0000 (18:40 -0400)]
nscd: Drop local address tuple variable [BZ #29607]

When a request needs to be resent (e.g. due to insufficient buffer
space), the references to subsequent tuples in the local variable are
stale and should not be used.  This used to work by accident before, but
since 1d495912a it no longer does.  Instead of trying to reset it, just
let gethostbyname4_r write into TUMPBUF6 for us, thus maintaining a
consistent state at all times.  This is now consistent with what is done
in gaih_inet for getaddrinfo.

Resolves: BZ #29607
Reported-by: Holger Hoffstätte <holger@applied-asynchrony.com>
Tested-by: Holger Hoffstätte <holger@applied-asynchrony.com>
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
21 months agoUse Linux 6.0 in build-many-glibcs.py
Joseph Myers [Tue, 4 Oct 2022 13:57:19 +0000 (13:57 +0000)]
Use Linux 6.0 in build-many-glibcs.py

This patch makes build-many-glibcs.py use Linux 6.0.

Tested with build-many-glibcs.py (host-libraries, compilers and glibcs
builds).

21 months agox86-64: Require BMI1/BMI2 for AVX2 strrchr and wcsrchr implementations
Aurelien Jarno [Mon, 3 Oct 2022 21:46:11 +0000 (23:46 +0200)]
x86-64: Require BMI1/BMI2 for AVX2 strrchr and wcsrchr implementations

The AVX2 strrchr and wcsrchr implementation uses the 'blsmsk'
instruction which belongs to the BMI1 CPU feature and the 'shrx'
instruction, which belongs to the BMI2 CPU feature.

Fixes: df7e295d18ff ("x86: Optimize {str|wcs}rchr-avx2")
Partially resolves: BZ #29611

Reviewed-by: Noah Goldstein <goldstein.w.n@gmail.com>
21 months agox86-64: Require BMI2 and LZCNT for AVX2 memrchr implementation
Aurelien Jarno [Mon, 3 Oct 2022 21:46:11 +0000 (23:46 +0200)]
x86-64: Require BMI2 and LZCNT for AVX2 memrchr implementation

The AVX2 memrchr implementation uses the 'shlxl' instruction, which
belongs to the BMI2 CPU feature and uses the 'lzcnt' instruction, which
belongs to the LZCNT CPU feature.

Fixes: af5306a735eb ("x86: Optimize memrchr-avx2.S")
Partially resolves: BZ #29611

Reviewed-by: Noah Goldstein <goldstein.w.n@gmail.com>
21 months agox86-64: Require BMI2 for AVX2 (raw|w)memchr implementations
Aurelien Jarno [Mon, 3 Oct 2022 21:46:11 +0000 (23:46 +0200)]
x86-64: Require BMI2 for AVX2 (raw|w)memchr implementations

The AVX2 memchr, rawmemchr and wmemchr implementations use the 'bzhi'
and 'sarx' instructions, which belongs to the BMI2 CPU feature.

Fixes: acfd088a1963 ("x86: Optimize memchr-avx2.S")
Partially resolves: BZ #29611

Reviewed-by: Noah Goldstein <goldstein.w.n@gmail.com>
21 months agox86-64: Require BMI2 for AVX2 wcs(n)cmp implementations
Aurelien Jarno [Mon, 3 Oct 2022 21:46:11 +0000 (23:46 +0200)]
x86-64: Require BMI2 for AVX2 wcs(n)cmp implementations

The AVX2 wcs(n)cmp implementations use the 'bzhi' instruction, which
belongs to the BMI2 CPU feature.

NB: It also uses the 'tzcnt' BMI1 instruction, but it is executed as BSF
as BSF if the CPU doesn't support TZCNT, and produces the same result
for non-zero input.

Partially fixes: b77b06e0e296 ("x86: Optimize strcmp-avx2.S")
Partially resolves: BZ #29611

Reviewed-by: Noah Goldstein <goldstein.w.n@gmail.com>
21 months agox86-64: Require BMI2 for AVX2 strncmp implementation
Aurelien Jarno [Mon, 3 Oct 2022 21:46:11 +0000 (23:46 +0200)]
x86-64: Require BMI2 for AVX2 strncmp implementation

The AVX2 strncmp implementations uses the 'bzhi' instruction, which
belongs to the BMI2 CPU feature.

NB: It also uses the 'tzcnt' BMI1 instruction, but it is executed as BSF
as BSF if the CPU doesn't support TZCNT, and produces the same result
for non-zero input.

Partially fixes: b77b06e0e296 ("x86: Optimize strcmp-avx2.S")
Partially resolves: BZ #29611

Reviewed-by: Noah Goldstein <goldstein.w.n@gmail.com>
21 months agox86-64: Require BMI2 for AVX2 strcmp implementation
Aurelien Jarno [Mon, 3 Oct 2022 21:46:11 +0000 (23:46 +0200)]
x86-64: Require BMI2 for AVX2 strcmp implementation

The AVX2 strcmp implementation uses the 'bzhi' instruction, which
belongs to the BMI2 CPU feature.

NB: It also uses the 'tzcnt' BMI1 instruction, but it is executed as BSF
as BSF if the CPU doesn't support TZCNT, and produces the same result
for non-zero input.

Partially fixes: b77b06e0e296 ("x86: Optimize strcmp-avx2.S")
Partially resolves: BZ #29611

Reviewed-by: Noah Goldstein <goldstein.w.n@gmail.com>
21 months agox86-64: Require BMI2 for AVX2 str(n)casecmp implementations
Aurelien Jarno [Mon, 3 Oct 2022 21:46:11 +0000 (23:46 +0200)]
x86-64: Require BMI2 for AVX2 str(n)casecmp implementations

The AVX2 str(n)casecmp implementations use the 'bzhi' instruction, which
belongs to the BMI2 CPU feature.

NB: It also uses the 'tzcnt' BMI1 instruction, but it is executed as BSF
as BSF if the CPU doesn't support TZCNT, and produces the same result
for non-zero input.

Partially fixes: b77b06e0e296 ("x86: Optimize strcmp-avx2.S")
Partially resolves: BZ #29611

Reviewed-by: Noah Goldstein <goldstein.w.n@gmail.com>
21 months agox86: include BMI1 and BMI2 in x86-64-v3 level
Aurelien Jarno [Mon, 3 Oct 2022 21:46:11 +0000 (23:46 +0200)]
x86: include BMI1 and BMI2 in x86-64-v3 level

The "System V Application Binary Interface AMD64 Architecture Processor
Supplement" mandates the BMI1 and BMI2 CPU features for the x86-64-v3
level.

Reviewed-by: Noah Goldstein <goldstein.w.n@gmail.com>
21 months agox86: Cleanup pthread_spin_{try}lock.S
Noah Goldstein [Sat, 1 Oct 2022 04:13:27 +0000 (21:13 -0700)]
x86: Cleanup pthread_spin_{try}lock.S

Save a jmp on the lock path coming from an initial failure in
pthread_spin_lock.S.  This costs 4-bytes of code but since the
function still fits in the same number of 16-byte blocks (default
function alignment) it does not have affect on the total binary size
of libc.so (unchanged after this commit).

pthread_spin_trylock was using a CAS when a simple xchg works which
is often more expensive.

Full check passes on x86-64.

21 months agoBenchtests: Add bench for pthread_spin_{try}lock and mutex_trylock
Noah Goldstein [Sat, 1 Oct 2022 04:13:26 +0000 (21:13 -0700)]
Benchtests: Add bench for pthread_spin_{try}lock and mutex_trylock

Reuses infrastructure from previous pthread_mutex_lock benchmarks to
test other performance sensitive functions.

21 months agox86: Remove .tfloat usage
Adhemerval Zanella [Fri, 11 Mar 2022 14:08:55 +0000 (11:08 -0300)]
x86: Remove .tfloat usage

Some compiler does not support it (such as clang integrated assembler)
neither gcc emits it.

21 months agonptl: Convert tst-setuid2 to test-driver
Yu Chien Peter Lin [Fri, 30 Sep 2022 12:19:51 +0000 (20:19 +0800)]
nptl: Convert tst-setuid2 to test-driver

Use <support/test-driver.c> and replace pthread calls to its xpthread
equivalents.

Signed-off-by: Yu Chien Peter Lin <peterlin@andestech.com>
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
21 months agosupport: Add xpthread_cond_signal wrapper
Yu Chien Peter Lin [Fri, 30 Sep 2022 12:19:50 +0000 (20:19 +0800)]
support: Add xpthread_cond_signal wrapper

Signed-off-by: Yu Chien Peter Lin <peterlin@andestech.com>
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
21 months agohppa: Fix initialization of dp register [BZ 29635]
John David Anglin [Sat, 1 Oct 2022 19:49:25 +0000 (19:49 +0000)]
hppa: Fix initialization of dp register [BZ 29635]

After upgrading glibc to Debian 2.35-1, gdb faulted on
startup and dropped core in a function call in the main
application.  This was caused by not initializing the
global dp register for the main application early enough.

Restore the code to initialize dp in _dl_start_user.
It was removed when code was added to initialize dp in
elf_machine_runtime_setup.

Signed-off-by: John David Anglin <dave.anglin@bell.net>
21 months agoFix iseqsig for _FloatN and _FloatNx in C++ with GCC 13
Joseph Myers [Fri, 30 Sep 2022 19:36:41 +0000 (19:36 +0000)]
Fix iseqsig for _FloatN and _FloatNx in C++ with GCC 13

With GCC 13, _FloatN and _FloatNx types, when they exist, are distinct
types like they are in C with GCC 7 and later, rather than typedefs
for types such as float, double or long double.

This breaks the templated iseqsig implementation for C++ in <math.h>,
when used with types that were previously implemented as aliases.  Add
the necessary definitions for _Float32, _Float64, _Float128 (when the
same format as long double), _Float32x and _Float64x in this case, so
that iseqsig can be used with such types in C++ with GCC 13 as it
could with previous GCC versions.

Also add tests for calling iseqsig in C++ with arguments of such types
(more minimal than existing tests, so that they can work with older
GCC versions and without relying on any C++ library support for the
types or on hardcoding details of their formats).  The LDBL_MANT_DIG
!= 106 conditionals on some tests are because the type-generic
comparison macros have undefined behavior when neither argument has a
type whose set of values is a subset of those for the type of the
other argument, which applies when one argument is IBM long double and
the other is an IEEE format wider than binary64.

Tested with build-many-glibcs.py glibcs build for aarch64-linux-gnu
i686-linux-gnu mips-linux-gnu mips64-linux-gnu-n32 powerpc-linux-gnu
powerpc64le-linux-gnu x86_64-linux-gnu.

21 months agomalloc: Do not clobber errno on __getrandom_nocancel (BZ #29624)
Adhemerval Zanella [Thu, 29 Sep 2022 19:18:06 +0000 (16:18 -0300)]
malloc: Do not clobber errno on __getrandom_nocancel (BZ #29624)

Use INTERNAL_SYSCALL_CALL instead of INLINE_SYSCALL_CALL.  This
requires emulate the semantic for hurd call (so __arc4random_buf
uses the fallback).

Checked on x86_64-linux-gnu.

Reviewed-by: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
21 months agostdlib: Fix __getrandom_nocancel type and arc4random usage (BZ #29638)
Adhemerval Zanella [Thu, 29 Sep 2022 19:15:20 +0000 (16:15 -0300)]
stdlib: Fix __getrandom_nocancel type and arc4random usage (BZ #29638)

Using an unsigned type prevents the fallback to be used if kernel
does not support getrandom syscall.

Checked on x86_64-linux-gnu.

Reviewed-by: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
21 months agoLoongArch: Add static PIE support
Xi Ruoyao [Sat, 24 Sep 2022 07:45:34 +0000 (15:45 +0800)]
LoongArch: Add static PIE support

If the compiler is new enough, enable static PIE support.  In the static
PIE version of _start (in rcrt1.o), use la.pcrel instead of la.got
because in a static PIE we cannot use GOT entries until the dynamic
relocations for GOT are resolved.

21 months agoBenchtest: Add additional benchmarks for strlen and strnlen
Noah Goldstein [Wed, 28 Sep 2022 19:20:12 +0000 (12:20 -0700)]
Benchtest: Add additional benchmarks for strlen and strnlen

Current benchmarks are missing many cases in the mid-length range
which is often the hottest size range.

21 months agox86: Fix wcsnlen-avx2 page cross length comparison [BZ #29591]
Noah Goldstein [Wed, 21 Sep 2022 00:58:04 +0000 (17:58 -0700)]
x86: Fix wcsnlen-avx2 page cross length comparison [BZ #29591]

Previous implementation was adjusting length (rsi) to match
bytes (eax), but since there is no bound to length this can cause
overflow.

Fix is to just convert the byte-count (eax) to length by dividing by
sizeof (wchar_t) before the comparison.

Full check passes on x86-64 and build succeeds w/ and w/o multiarch.

21 months agoUpdate _FloatN header support for C++ in GCC 13
Joseph Myers [Wed, 28 Sep 2022 20:09:34 +0000 (20:09 +0000)]
Update _FloatN header support for C++ in GCC 13

GCC 13 adds support for _FloatN and _FloatNx types in C++, so breaking
the installed glibc headers that assume such support is not present.
GCC mostly works around this with fixincludes, but that doesn't help
for building glibc and its tests (glibc doesn't itself contain C++
code, but there's C++ code built for tests).  Update glibc's
bits/floatn-common.h and bits/floatn.h headers to handle the GCC 13
support directly.

In general the changes match those made by fixincludes, though I think
the ones in sysdeps/powerpc/bits/floatn.h, where the header tests
__LDBL_MANT_DIG__ == 113 or uses #elif, wouldn't match the existing
fixincludes patterns.

Some places involving special C++ handling in relation to _FloatN
support are not changed.  There's no need to change the
__HAVE_FLOATN_NOT_TYPEDEF definition (also in a form that wouldn't be
matched by the fixincludes fixes) because it's only used in relation
to macro definitions using features not supported for C++
(__builtin_types_compatible_p and _Generic).  And there's no need to
change the inline function overloads for issignaling, iszero and
iscanonical in C++ because cases where types have the same format but
are no longer compatible types are handled automatically by the C++
overload resolution rules.

This patch also does not change the overload handling for iseqsig, and
there I think changes *are* needed, beyond those in this patch or made
by fixincludes.  The way that overload is defined, via a template
parameter to a structure type, requires overloads whenever the types
are incompatible, even if they have the same format.  So I think we
need to add overloads with GCC 13 for every supported _FloatN and
_FloatNx type, rather than just having one for _Float128 when it has a
different ABI to long double as at present (but for older GCC, such
overloads must not be defined for types that end up defined as
typedefs for another type).

Tested with build-many-glibcs.py: compilers build for
aarch64-linux-gnu ia64-linux-gnu mips64-linux-gnu powerpc-linux-gnu
powerpc64le-linux-gnu x86_64-linux-gnu; glibcs build for
aarch64-linux-gnu ia64-linux-gnu i686-linux-gnu mips-linux-gnu
mips64-linux-gnu-n32 powerpc-linux-gnu powerpc64le-linux-gnu
x86_64-linux-gnu.

21 months agohurd: Fix typo
Samuel Thibault [Wed, 28 Sep 2022 17:21:44 +0000 (19:21 +0200)]
hurd: Fix typo

21 months agoget_nscd_addresses: Fix subscript typos [BZ #29605]
Jörg Sonnenberger [Mon, 26 Sep 2022 17:59:16 +0000 (13:59 -0400)]
get_nscd_addresses: Fix subscript typos [BZ #29605]

Fix the subscript on air->family, which was accidentally set to COUNT
when it should have remained as I.

Resolves: BZ #29605

Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
21 months agohurd: Increase SOMAXCONN to 4096
Samuel Thibault [Tue, 27 Sep 2022 21:37:42 +0000 (23:37 +0200)]
hurd: Increase SOMAXCONN to 4096

Notably fakeroot-tcp may introduce a lot of parallel connections.

21 months agoUse atomic_exchange_release/acquire
Wilco Dijkstra [Mon, 26 Sep 2022 15:58:08 +0000 (16:58 +0100)]
Use atomic_exchange_release/acquire

Rename atomic_exchange_rel/acq to use atomic_exchange_release/acquire
since these map to the standard C11 atomic builtins.

Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
21 months agonss: Use shared prefix in IPv4 address in tst-reload1
Florian Weimer [Fri, 23 Sep 2022 17:30:57 +0000 (19:30 +0200)]
nss: Use shared prefix in IPv4 address in tst-reload1

Otherwise, sorting based on the longest-matching prefix in
getaddrinfo can reorder the addresses in ways the test does not
expect, depending on the IPv4 address of the host.

Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
21 months agonss: Enhance tst-reload1 coverage and logging
Florian Weimer [Fri, 23 Sep 2022 17:30:57 +0000 (19:30 +0200)]
nss: Enhance tst-reload1 coverage and logging

Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
21 months agoUse C11 atomics instead of atomic_decrement_and_test
Wilco Dijkstra [Thu, 22 Sep 2022 14:40:37 +0000 (15:40 +0100)]
Use C11 atomics instead of atomic_decrement_and_test

Replace atomic_decrement_and_test with atomic_fetch_add_relaxed.
These are simple counters which do not protect any shared data from
concurrent accesses. Also remove the unused file cond-perf.c.

Passes regress on AArch64.

Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
21 months agoUse C11 atomics instead of atomic_increment(_val)
Wilco Dijkstra [Thu, 22 Sep 2022 14:32:40 +0000 (15:32 +0100)]
Use C11 atomics instead of atomic_increment(_val)

Replace atomic_increment and atomic_increment_val with atomic_fetch_add_relaxed.
One case in sem_post.c uses release semantics (see comment above it).
The others are simple counters and do not protect any shared data from
concurrent accesses.

Passes regress on AArch64.

Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
21 months agoUse C11 atomics instead of atomic_and/or
Wilco Dijkstra [Thu, 22 Sep 2022 14:27:20 +0000 (15:27 +0100)]
Use C11 atomics instead of atomic_and/or

Remove the 4 uses of atomic_and and atomic_or with atomic_fetch_and_acquire
and atomic_fetch_or_acquire. This is preserves existing implied semantics,
however relaxed MO on FUTEX_OWNER_DIED accesses may be correct.

Passes regress on AArch64.

Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
21 months agomalloc: Print error when oldsize is not equal to the current size.
Qingqing Li [Thu, 22 Sep 2022 19:32:56 +0000 (15:32 -0400)]
malloc: Print error when oldsize is not equal to the current size.

This is used to detect errors early.  The read of the oldsize is
not protected by any lock, so check this value to avoid causing
bigger mistakes.

Reviewed-by: DJ Delorie <dj@redhat.com>
21 months agoUse '%z' instead of '%Z' on printf functions
Adhemerval Zanella Netto [Thu, 1 Sep 2022 13:02:30 +0000 (10:02 -0300)]
Use '%z' instead of '%Z' on printf functions

The Z modifier is a nonstandard synonymn for z (that predates z
itself) and compiler might issue an warning for in invalid
conversion specifier.

Reviewed-by: Florian Weimer <fweimer@redhat.com>
21 months agoelf: Extract glibcelf constants from <elf.h>
Florian Weimer [Thu, 22 Sep 2022 10:10:41 +0000 (12:10 +0200)]
elf: Extract glibcelf constants from <elf.h>

The need to maintain elf/elf.h and scripts/glibcelf.py in parallel
results in a backporting hazard: they need to be kept in sync to
avoid elf/tst-glibcelf consistency check failures.  glibcelf (unlike
tst-glibcelf) does not use the C implementation to extract constants.
This applies the additional glibcpp syntax checks to <elf.h>.

This  changereplaces the types derived from Python enum types with
custom types _TypedConstant, _IntConstant, and _FlagConstant.  These
types have fewer safeguards, but this also allows incremental
construction and greater flexibility for grouping constants among
the types.  Architectures-specific named constants are now added
as members into their superclasses (but value-based lookup is
still restricted to generic constants only).

Consequently, check_duplicates in elf/tst-glibcelf has been adjusted
to accept differently-named constants of the same value if their
subtypes are distinct.  The ordering check for named constants
has been dropped because they are no longer strictly ordered.

Further test adjustments: Some of the type names are different.
The new types do not support iteration (because it is unclear
whether iteration should cover the all named values (including
architecture-specific constants), or only the generic named values),
so elf/tst-glibcelf now uses by_name explicit (to get all constants).
PF_HP_SBP and PF_PARISC_SBP are now of distinct types (PfHP and
PfPARISC), so they are how both present on the Python side.  EM_NUM
and PT_NUM are filtered (which was an oversight in the old
conversion).

The new version of glibcelf should also be compatible with earlier
Python versions because it no longer depends on the enum module and its
advanced features.

Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
21 months agoscripts: Enhance glibcpp to do basic macro processing
Florian Weimer [Thu, 22 Sep 2022 10:10:41 +0000 (12:10 +0200)]
scripts: Enhance glibcpp to do basic macro processing

Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
21 months agoscripts: Extract glibcpp.py from check-obsolete-constructs.py
Florian Weimer [Thu, 22 Sep 2022 10:10:41 +0000 (12:10 +0200)]
scripts: Extract glibcpp.py from check-obsolete-constructs.py

The C tokenizer is useful separately.

Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
21 months agoriscv: Remove RV32 floating point functions
Alistair Francis [Tue, 20 Sep 2022 19:21:13 +0000 (15:21 -0400)]
riscv: Remove RV32 floating point functions

We don't need RV32 specific floating point functions, instead make them
generic for RISC-V.

Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
21 months agoriscv: Consolidate the libm-test-ulps
Alistair Francis [Thu, 15 Sep 2022 04:37:10 +0000 (00:37 -0400)]
riscv: Consolidate the libm-test-ulps

Both RV32 and RV64 should have the same libm-test-ulps, so consolidate
them into a single file.

Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
21 months agohurd: Fix SIOCADD/DELRT ioctls
Samuel Thibault [Wed, 21 Sep 2022 17:28:56 +0000 (19:28 +0200)]
hurd: Fix SIOCADD/DELRT ioctls

The hurd network stack uses struct ifrtreq rather than ortentry.

21 months agohurd: Drop struct rtentry and in6_rtmsg
Samuel Thibault [Wed, 21 Sep 2022 17:28:25 +0000 (19:28 +0200)]
hurd: Drop struct rtentry and in6_rtmsg

These were cargo-culted, they are not used at all in Hurd interfaces.

21 months agohurd: Add _IOT_ifrtreq to <net/route.h>
Damien Zammit [Wed, 21 Sep 2022 17:27:39 +0000 (19:27 +0200)]
hurd: Add _IOT_ifrtreq to <net/route.h>

So that we can use struct ifrtreq in ioctls.

21 months agoelf: Use C11 atomics on _dl_mcount
Adhemerval Zanella [Tue, 20 Sep 2022 19:04:13 +0000 (16:04 -0300)]
elf: Use C11 atomics on _dl_mcount

All atomic operation are counters, so relaxed MO should be suffice.

Checked on x86_64-linux-gnu.
Reviewed-by: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
21 months agohurd: Use IF_NAMESIZE rather than IFNAMSIZ
Samuel Thibault [Wed, 21 Sep 2022 06:51:50 +0000 (08:51 +0200)]
hurd: Use IF_NAMESIZE rather than IFNAMSIZ

The latter is not available without __USE_MISC.

21 months agohurd: Add ifrtreq structure to net/route.h
Damien Zammit [Tue, 20 Sep 2022 22:41:31 +0000 (00:41 +0200)]
hurd: Add ifrtreq structure to net/route.h

As used by the hurdish route ioctls.

21 months agohppa: undef __ASSUME_SET_ROBUST_LIST
John David Anglin [Tue, 20 Sep 2022 20:14:14 +0000 (20:14 +0000)]
hppa: undef __ASSUME_SET_ROBUST_LIST

QEMU does not support support set_robust_list. Thus, we need
to enable detection of set_robust_list system call.

Signed-off-by: John David Anglin <dave.anglin@bell.net>
21 months agolinux: Use same type for MMAP2_PAGE_UNIT
Adhemerval Zanella [Thu, 10 Mar 2022 11:07:37 +0000 (08:07 -0300)]
linux: Use same type for MMAP2_PAGE_UNIT

It avoid a possible compiler warning where right size of operator
is converted from a negative value to unsigned.

Reviewed-by: Florian Weimer <fweimer@redhat.com>
21 months agom68k: Enforce 4-byte alignment on internal locks (BZ #29537)
Adhemerval Zanella [Tue, 30 Aug 2022 13:33:15 +0000 (10:33 -0300)]
m68k: Enforce 4-byte alignment on internal locks (BZ #29537)

A new internal definition, __LIBC_LOCK_ALIGNMENT, is used to force
the 4-byte alignment only for m68k, other architecture keep the
natural alignment of the type used internally (and hppa does not
require 16-byte alignment for kernel-assisted CAS).

Reviewed-by: Florian Weimer <fweimer@redhat.com>
21 months agonss: Fix tst-nss-files-hosts-long on single-stack hosts (bug 24816)
Florian Weimer [Tue, 13 Sep 2022 14:11:40 +0000 (16:11 +0200)]
nss: Fix tst-nss-files-hosts-long on single-stack hosts (bug 24816)

getent implicitly passes AI_ADDRCONFIG to getaddrinfo by default.
Use --no-addrconfig to suppress that, so that both IPv4 and IPv6
lookups succeed even if the address family is not supported by the
host.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
21 months agonss: Implement --no-addrconfig option for getent
Florian Weimer [Tue, 13 Sep 2022 14:10:20 +0000 (16:10 +0200)]
nss: Implement --no-addrconfig option for getent

The ahosts, ahostsv4, ahostsv6 commands unconditionally pass
AI_ADDRCONFIG to getaddrinfo, which is not always desired.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
21 months agogconv: Use 64-bit interfaces in gconv_parseconfdir (bug 29583)
Florian Weimer [Tue, 20 Sep 2022 10:12:43 +0000 (12:12 +0200)]
gconv: Use 64-bit interfaces in gconv_parseconfdir (bug 29583)

It's possible that inode numbers are outside the 32-bit range.
The existing code only handles the in-libc case correctly, and
still uses the legacy interfaces when building iconv.

Suggested-by: Helge Deller <deller@gmx.de>
21 months agoelf: Implement force_first handling in _dl_sort_maps_dfs (bug 28937)
Florian Weimer [Tue, 20 Sep 2022 09:00:42 +0000 (11:00 +0200)]
elf: Implement force_first handling in _dl_sort_maps_dfs (bug 28937)

The implementation in _dl_close_worker requires that the first
element of l_initfini is always this very map (“We are always the
zeroth entry, and since we don't include ourselves in the
dependency analysis start at 1.”).  Rather than fixing that
assumption, this commit adds an implementation of the force_first
argument to the new dependency sorting algorithm.  This also means
that the directly dlopen'ed shared object is always initialized last,
which is the least surprising behavior in the presence of cycles.

Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
21 months agoLinux: Do not skip d_ino == 0 entries in readdir, readdir64 (bug 12165)
Florian Weimer [Mon, 19 Sep 2022 06:10:41 +0000 (08:10 +0200)]
Linux: Do not skip d_ino == 0 entries in readdir, readdir64 (bug 12165)

POSIX does not say this value is special.  For example, old XFS file
systems may still use inode number zero.

Also update the comment regarding ENOENT.  Linux may return ENOENT
for some file systems.

21 months agohurd: Factorize at/non-at functions
Samuel Thibault [Sat, 17 Sep 2022 19:47:57 +0000 (19:47 +0000)]
hurd: Factorize at/non-at functions

Non-at functions can be implemented by just calling the corresponding at
function with AT_FDCWD and zero at_flags.

In the linkat case, the at behavior is different (O_NOLINK), so this introduces
__linkat_common to pass O_NOLINK as appropriate.

lstat functions can also be implemented with fstatat by adding
__fstatat64_common which takes a flags parameter in addition to the at_flags
parameter,

In the end this factorizes chmod, chown, link, lstat64, mkdir, readlink,
rename, stat64, symlink, unlink, utimes.

This also makes __lstat, __lxstat64, __stat and __xstat64 directly use
__fstatat64_common instead of __lstat64 or __stat64.

21 months agotst-sprintf-errno: Update Hurd message length
Samuel Thibault [Sat, 17 Sep 2022 15:42:42 +0000 (17:42 +0200)]
tst-sprintf-errno: Update Hurd message length

03ad444e8e08 ("mach: Fix incoherency between perror and strerror") fixesd
the output of error messages, but tst-sprintf-errno.c was still checking
the old (erroneous) format length. This updates the expected output length
according to the 03ad444e8e08 fix.

21 months agoRISC-V: Allow long jumps to __syscall_error
Łukasz Stelmach [Fri, 16 Sep 2022 19:31:27 +0000 (21:31 +0200)]
RISC-V: Allow long jumps to __syscall_error

__syscall_error may end up farther than 1MiB away from a caller,
especially when linking statically large binaries. tail allows for
4GiB jumps and is reduced to j when a linked symbol is within range.

Fixes: 36960f0c76 ("RISC-V: Linux Syscall Interface")
Fixes: 7f33b09c65 ("RISC-V: Linux ABI")
Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
21 months agohurd: Make readlink* just reopen the file used for stat
Samuel Thibault [Thu, 15 Sep 2022 19:53:57 +0000 (21:53 +0200)]
hurd: Make readlink* just reopen the file used for stat

9e5c991106cb ("hurd: Fix readlink() hanging on fifo") separated opening
the file for the stat call from opening the file for the read call. That
however opened a small window for the file to change. Better make this
atomic by reopening the file with O_READ.

21 months agohurd: Fix readlink() hanging on fifo
Samuel Thibault [Wed, 14 Sep 2022 16:52:52 +0000 (18:52 +0200)]
hurd: Fix readlink() hanging on fifo

readlink() opens the target with O_READ to be able to read the symlink
content. When the target is actually a fifo, that would hang waiting for a
writer (caught in the coreutils testsuite). We thus have to first lookup the
target without O_READ to perform io_stat and lookout for fifos, and only
after checking the symlink type, we can re-lookup with O_READ.

21 months agoFix BRE typos in check-safety.sh
Paul Eggert [Wed, 14 Sep 2022 05:10:45 +0000 (00:10 -0500)]
Fix BRE typos in check-safety.sh

* manual/check-safety.sh: Fix BRE portability typos.
POSIX says \] produces undefined results.

21 months agoMakerules: fix MAKEFLAGS assignment for upcoming make-4.4 [BZ# 29564]
Sergei Trofimovich [Tue, 13 Sep 2022 17:39:13 +0000 (13:39 -0400)]
Makerules: fix MAKEFLAGS assignment for upcoming make-4.4 [BZ# 29564]

make-4.4 will add long flags to MAKEFLAGS variable:

    * WARNING: Backward-incompatibility!
      Previously only simple (one-letter) options were added to the MAKEFLAGS
      variable that was visible while parsing makefiles.  Now, all options
      are available in MAKEFLAGS.

This causes locale builds to fail when long options are used:

    $ make --shuffle
    ...
    make  -C localedata install-locales
    make: invalid shuffle mode: '1662724426r'

The change fixes it by passing eash option via whitespace and dashes.
That way option is appended to both single-word form and whitespace
separated form.

While at it fixed --silent mode detection in $(MAKEFLAGS) by filtering
out --long-options. Otherwise options like --shuffle flag enable silent
mode unintentionally. $(silent-make) variable consolidates the checks.

Resolves: BZ# 29564

CC: Paul Smith <psmith@gnu.org>
CC: Siddhesh Poyarekar <siddhesh@gotplt.org>
Signed-off-by: Sergei Trofimovich <slyich@gmail.com>
Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
21 months agoUse relaxed atomics since there is no MO dependence
Wilco Dijkstra [Tue, 13 Sep 2022 10:58:07 +0000 (11:58 +0100)]
Use relaxed atomics since there is no MO dependence

Replace the 3 uses of atomic_bit_set and atomic_bit_test_set with
atomic_fetch_or_relaxed.  Using relaxed MO is correct since the
atomics are used to ensure memory is released only once.

Reviewed-by: Florian Weimer <fweimer@redhat.com>
21 months agomakedb: fix build with libselinux >= 3.1 (Bug 26233)
Aurelien Jarno [Sun, 11 Sep 2022 15:30:17 +0000 (11:30 -0400)]
makedb: fix build with libselinux >= 3.1 (Bug 26233)

glibc doesn't build with libselinux 3.1 that has been released recently
due to new deprecations introduced in that version and the fact that
glibc is built with -Werror by default:

| makedb.c: In function ‘set_file_creation_context’:
| makedb.c:849:3: error: ‘security_context_t’ is deprecated [-Werror=deprecated-declarations]
|   849 |   security_context_t ctx;
|       |   ^~~~~~~~~~~~~~~~~~
| makedb.c:863:3: error: ‘matchpathcon’ is deprecated: Use selabel_lookup instead [-Werror=deprecated-declarations]
|   863 |   if (matchpathcon (outname, S_IFREG | mode, &ctx) == 0 && ctx != NULL)
|       |   ^~
| In file included from makedb.c:50:
| /usr/include/selinux/selinux.h:500:12: note: declared here
|   500 | extern int matchpathcon(const char *path,
|       |            ^~~~~~~~~~~~
| cc1: all warnings being treated as errors

This patch fixes the makedb half of bug 26233 by moving to the new
SELinux APIs and removes the existing compiler pragmas as no longer
required. Upstream API usage feedback gathered by Arjun is integrated
into this version of the fix.

The built makedb was tested and operates as expected on x86_64 with
SELinu in enforcing mode.

No regressions on x86_64 with libselinux 3.3.

Co-authored-by: Arjun Shankar <arjun@redhat.com>
Co-authored-by: Carlos O'Donell <carlos@redhat.com>
Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
21 months agotst-sprintf-errno: Update Hurd message output
Samuel Thibault [Sun, 11 Sep 2022 12:20:32 +0000 (14:20 +0200)]
tst-sprintf-errno: Update Hurd message output

03ad444e8e08 ("mach: Fix incoherency between perror and strerror")
fixesd the output of error messages, but tst-sprintf-errno.c was still
checking the old (erroneous) format. This updates the expected output
according to the 03ad444e8e08 fix.

21 months agoUse C11 atomics instead of atomic_decrement(_val)
Wilco Dijkstra [Fri, 9 Sep 2022 13:22:26 +0000 (14:22 +0100)]
Use C11 atomics instead of atomic_decrement(_val)

Replace atomic_decrement and atomic_decrement_val with
atomic_fetch_add_relaxed.

Reviewed-by: DJ Delorie <dj@redhat.com>
21 months agoUse C11 atomics instead atomic_add(_zero)
Wilco Dijkstra [Fri, 9 Sep 2022 13:11:23 +0000 (14:11 +0100)]
Use C11 atomics instead atomic_add(_zero)

Replace atomic_add and atomic_add_zero with atomic_fetch_add_relaxed.

Reviewed-by: DJ Delorie <dj@redhat.com>
21 months agomktime: improve heuristic for ca-1986 Indiana DST
Paul Eggert [Fri, 9 Sep 2022 01:08:32 +0000 (20:08 -0500)]
mktime: improve heuristic for ca-1986 Indiana DST

This patch syncs mktime.c from Gnulib, fixing a
problem reported by Mark Krenz <https://bugs.gnu.org/48085>,
and it should fix BZ#29035 too.
* time/mktime.c (__mktime_internal): Be more generous about
accepting arguments with the wrong value of tm_isdst, by falling
back to a one-hour DST difference if we find no nearby DST that is
unusual.  This fixes a problem where "1986-04-28 00:00 EDT" was
rejected when TZ="America/Indianapolis" because the nearest DST
timestamp occurred in 1970, a temporal distance too great for the
old heuristic.  This also also narrows the search a bit, which
is a minor performance win.

21 months agoAssume HAVE_TZSET in time/mktime.c
Paul Eggert [Fri, 9 Sep 2022 01:08:32 +0000 (20:08 -0500)]
Assume HAVE_TZSET in time/mktime.c

This patch does not affect glibc.  It affects only Gnulib-specific
code and is for coordination with Gnulib.

21 months agoelf: Fix hwcaps string size overestimation
Javier Pello [Mon, 5 Sep 2022 18:09:01 +0000 (20:09 +0200)]
elf: Fix hwcaps string size overestimation

Commit dad90d528259b669342757c37dedefa8577e2636 added glibc-hwcaps
support for LD_LIBRARY_PATH and, for this, it adjusted the total
string size required in _dl_important_hwcaps. However, in doing so
it inadvertently altered the calculation of the size required for
the power set strings, as the computation of the power set string
size depended on the first value assigned to the total variable,
which is later shifted, resulting in overallocation of string
space. Fix this now by using a different variable to hold the
string size required for glibc-hwcaps.

Signed-off-by: Javier Pello <devel@otheo.eu>
21 months agoerrlist: add missing entry for EDEADLOCK (bug 29545)
Andreas Schwab [Thu, 8 Sep 2022 08:25:21 +0000 (10:25 +0200)]
errlist: add missing entry for EDEADLOCK (bug 29545)

Some architectures (mips, powerpc and sparc) define separate values for
EDEADLOCK and EDEADLK.  Readd the errlist entry for EDEADLOCK for those
configurations.  Also use the dependency files from generating the
auxiliary errlist and siglist files.

22 months agoDo not define static_assert or thread_local in headers for C2x
Joseph Myers [Wed, 7 Sep 2022 18:39:28 +0000 (18:39 +0000)]
Do not define static_assert or thread_local in headers for C2x

C2x makes static_assert and thread_local into keywords, removing the
definitions as macros in assert.h and threads.h.  Thus, disable those
macros in those glibc headers for C2x.

The disabling is done based on a combination of language version and
__GNUC_PREREQ, *not* based on __GLIBC_USE (ISOC2X), on the principle
that users of the header (when requesting C11 or later APIs - not
assert.h for C99 and older API versions) should always have the names
static_assert or thread_local available after inclusion of the header,
whether as a keyword or as a macro.  Thus, when using a compiler
without the keywords (whether an older compiler, possibly in C2x mode,
or _GNU_SOURCE with any compiler but in an older language mode, for
example) the macros should be defined, even when C2x APIs have been
requested.  The __GNUC_PREREQ conditionals here may well need updating
with the versions of other compilers that gained support for these
keywords in C2x mode.

Tested for x86_64.

22 months agomalloc: Use C11 atomics rather than atomic_exchange_and_add
Wilco Dijkstra [Tue, 6 Sep 2022 15:49:01 +0000 (16:49 +0100)]
malloc: Use C11 atomics rather than atomic_exchange_and_add

Replace a few counters using atomic_exchange_and_add with
atomic_fetch_add_relaxed.

Reviewed-by: Florian Weimer <fweimer@redhat.com>
22 months agoAdd NEWS entry for CVE-2022-39046
Siddhesh Poyarekar [Tue, 6 Sep 2022 13:31:50 +0000 (09:31 -0400)]
Add NEWS entry for CVE-2022-39046

22 months agoelf: Rename _dl_sort_maps parameter from skip to force_first
Florian Weimer [Tue, 6 Sep 2022 05:38:10 +0000 (07:38 +0200)]
elf: Rename _dl_sort_maps parameter from skip to force_first

The new implementation will not be able to skip an arbitrary number
of objects.

Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
22 months agoscripts/dso-ordering-test.py: Generate program run-time dependencies
Florian Weimer [Tue, 6 Sep 2022 05:38:10 +0000 (07:38 +0200)]
scripts/dso-ordering-test.py: Generate program run-time dependencies

The main program needs to depend on all shared objects, even objects
that have link-time dependencies among shared objects.  Filtering
out shared objects that already have an link-time dependencies is not
necessary here; make will do this automatically.

Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
22 months agomath: x86: Use prefix for FP_INIT_ROUNDMODE
Adhemerval Zanella [Thu, 10 Mar 2022 17:48:44 +0000 (14:48 -0300)]
math: x86: Use prefix for FP_INIT_ROUNDMODE

Not all compilers support the inline asm prefix '%v' to emit the avx
instruction if AVX is enable.  Use a prefix instead.

Checked on x86_64-linux-gnu and i686-linux-gnu.

22 months agoscripts/build-many-glibcs.py: Use https:// for sourceware.org Git clones
Florian Weimer [Mon, 5 Sep 2022 13:51:05 +0000 (15:51 +0200)]
scripts/build-many-glibcs.py: Use https:// for sourceware.org Git clones

Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
22 months agodebug: test for more required cacellation points (BZ# 29274)
Adhemerval Zanella [Mon, 27 Jun 2022 20:37:45 +0000 (20:37 +0000)]
debug: test for more required cacellation points (BZ# 29274)

Generalize the test for cancellation point in __read_chk to also test
the other fortified functions with required cancellation points.

Since there is not easy way to force some syscalls to block (for
instance pread) the test tests two modes: cancellation on blocked
syscalls and early cancellation on pending request.

Checked on x86_64-linux-gnu and aarch64-linux-gnu.

Co-authored-by: Andreas Schwab <schwab@suse.de>
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
22 months agoelf.h: Remove duplicate definition of VER_FLG_WEAK
Florian Weimer [Mon, 5 Sep 2022 10:11:19 +0000 (12:11 +0200)]
elf.h: Remove duplicate definition of VER_FLG_WEAK

This did not cause a warning before because the token sequence for
the two definitions was identical.

Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
22 months agosyslog: Remove extra whitespace between timestamp and message (BZ#29544)
Adhemerval Zanella [Mon, 5 Sep 2022 12:34:39 +0000 (09:34 -0300)]
syslog: Remove extra whitespace between timestamp and message (BZ#29544)

The rfc3164 clear states that a single space character must follow
the timestamp field.

Checked on x86_64-linux-gnu.

22 months agoLoongArch: Add soft float support.
caiyinyu [Mon, 22 Aug 2022 08:00:51 +0000 (16:00 +0800)]
LoongArch: Add soft float support.

This page took 0.088683 seconds and 5 git commands to generate.