]> sourceware.org Git - insight.git/log
insight.git
6 years agoUpgrade submodules, sync patches.
Patrick Monnerat [Fri, 31 Aug 2018 18:10:22 +0000 (20:10 +0200)]
Upgrade submodules, sync patches.

6 years agoRegisters are target-dependent, not frame-dependant.
Patrick Monnerat [Fri, 31 Aug 2018 17:44:08 +0000 (19:44 +0200)]
Registers are target-dependent, not frame-dependant.

This fixes a bug occurring when starting a compatible, non-native architecture
program, like a 32-bit program on a 64-bit architecture.

Reported-By: Igor <astandet at gmail.com>
* gdbtk/generic/gdbtk-register.c (gdb_regformat): check registers architecture
  against target, not frame.

6 years agoTcl expects a return value: wrapped function cannot be typed void.
Patrick Monnerat [Fri, 31 Aug 2018 17:40:19 +0000 (19:40 +0200)]
Tcl expects a return value: wrapped function cannot be typed void.

* gdbtk/generic/gdbtk-register.c (setup_architecture_data): typed int and
  return Tcl status.

6 years agoUpgrade submodule.
Patrick Monnerat [Mon, 27 Aug 2018 16:45:09 +0000 (18:45 +0200)]
Upgrade submodule.

6 years agoFix a C++ translation sort bug.
Patrick Monnerat [Mon, 27 Aug 2018 16:38:09 +0000 (18:38 +0200)]
Fix a C++ translation sort bug.

Reported-by: Igor <astandet at gmail dot com>
* gdbtk/generic/gdbtk-cmds.c (gdb_listfiles): use a lambda compare function for
  sorting.

6 years agoUpgrade submodule.
Patrick Monnerat [Fri, 24 Aug 2018 10:39:21 +0000 (12:39 +0200)]
Upgrade submodule.

6 years agoUpgrade submodule, sync patch.
Patrick Monnerat [Sun, 19 Aug 2018 23:52:14 +0000 (01:52 +0200)]
Upgrade submodule, sync patch.

6 years agoUpgrade submodule.
Patrick Monnerat [Fri, 10 Aug 2018 07:12:09 +0000 (09:12 +0200)]
Upgrade submodule.

6 years agoUpgrade submodule, sync patch.
Patrick Monnerat [Fri, 27 Jul 2018 09:11:20 +0000 (11:11 +0200)]
Upgrade submodule, sync patch.

6 years agoRemove unused variables.
Patrick Monnerat [Fri, 27 Jul 2018 09:02:00 +0000 (11:02 +0200)]
Remove unused variables.

* gdbtk/generic/gdbtk-bp.c (gdb_get_breakpoint_info): remove new_obj.
  (gdb_set_bp): remove e.
* gdbtk/generic/gdbtk-cmds.c (gdb_listfiles): remove psymtab and pathname.
* gdbtk/generic/gdbtk-register.c (get_register): remove addr, lval and dummy.
  (setup_architecture_data): remove numregs.
  (gdb_reggrouplist): remove i.
* gdbtk/generic/gdbtk-varobj.c (variable_update): remove i.
  (variable_value): remove e.
  (variable_print): remove except.

6 years agoUpgrade submodule, sync patch.
Patrick Monnerat [Fri, 20 Jul 2018 07:56:37 +0000 (09:56 +0200)]
Upgrade submodule, sync patch.

6 years agoUpgrade submodule, sync patches and code.
Patrick Monnerat [Fri, 13 Jul 2018 09:27:46 +0000 (11:27 +0200)]
Upgrade submodule, sync patches and code.

Insight gdb interpreter is no longer automatically initialized by gdb.
Initalize it explicitly.

* gdbtk/generic/gdbtk-interp.c (_initialize_gdbtk_interp): rename
  as initialize_gdbtk_interp.
* gdbtk/generic/gdbtk-main.c (main): call initialize_gdbtk_interp ().

6 years agoRemove obsolete targets.
Patrick Monnerat [Fri, 6 Jul 2018 11:50:15 +0000 (13:50 +0200)]
Remove obsolete targets.

* gdbtk/library/targetselection.itb (TargetSelection::init_target_db):
  targets sds, rdi, rdp, m32r, mon2000, sparclite, ice, mips, pmon,
  ddb, picobug, cisco, vxworks removed.

6 years agoUpgrade submodule, sync code.
Patrick Monnerat [Thu, 5 Jul 2018 23:30:14 +0000 (01:30 +0200)]
Upgrade submodule, sync code.

* gdbtk/generic/gdbtk-bp.c (gdb_trace_status): tp_vec is now an
  std::vector<breakpoint *>.
* gdbtk/generic/gdbtk-cmds.c (gdb_clear_file): replace ptid_equal() call
  by the inequality operator.
  (gdb_target_has_execution_command): likewise.
  (gdb_loc): likewise.
* gdbtk/generic/gdbtk-hooks.c (gdbtk_call_command): replace ptid_equal() call
  by the inequality operator.
  (gdbtk_annotate_signal): replace ptid_equal() call by the equality operator.

6 years agoRemove redundant empty methods.
Patrick Monnerat [Sat, 30 Jun 2018 10:32:20 +0000 (12:32 +0200)]
Remove redundant empty methods.

* gdbtk/library/pointwin.it[hb] (PointWin::breakpoint): removed.
  (PointWin::tracepoint): removed.
  (PointWin::watchpoint): removed.
* gdbtk/library/srctextwin.it[hb] (SrcTextWin::watchpoint): removed.

6 years agoFix an error message.
Patrick Monnerat [Sat, 30 Jun 2018 10:24:37 +0000 (12:24 +0200)]
Fix an error message.

The usage text of an error message was erroneous.

* gdbtk/library/gdbevent.itb (UpdateEvent::get): fix error message.

6 years agoUpgrade submodule, sync patch and code.
Patrick Monnerat [Fri, 29 Jun 2018 09:49:43 +0000 (11:49 +0200)]
Upgrade submodule, sync patch and code.

* gdbtk/generic/gdbtk-cmds.c (gdb_loc): get stop_pc from inferior thread
  structure (gdb global stop_pc has been removed).

6 years agoUpgrade submodule.
Patrick Monnerat [Mon, 25 Jun 2018 12:46:07 +0000 (14:46 +0200)]
Upgrade submodule.

6 years agoAdd gdb patch to fix breakpoint auto-disable notification.
Patrick Monnerat [Mon, 25 Jun 2018 12:41:57 +0000 (14:41 +0200)]
Add gdb patch to fix breakpoint auto-disable notification.

6 years agoTpWin: get rid of obsolete tracepoint commands.
Patrick Monnerat [Mon, 25 Jun 2018 09:50:20 +0000 (11:50 +0200)]
TpWin: get rid of obsolete tracepoint commands.

This also allows to simplify PointWin methods.

* gdbtk/library/pointwin.it[hb] (PointWin::enable_disable): remove
  type parameter.
  (PointWin::remove): Likewise.
  (PointWin::forall): remove arg parameter.
* gdbtk/library/tpwin.it[hb] (TpWin::forall): deleted.
  (TpWin::enable_disable): deleted.
  (TpWin::remove): deleted.
* gdbtk/library/bpwin.itb (BpWin::enable_disable): chain without type parameter.

6 years agoFix "enable count" breakpoints handling in source window.
Patrick Monnerat [Mon, 25 Jun 2018 09:31:21 +0000 (11:31 +0200)]
Fix "enable count" breakpoints handling in source window.

Consider those as normal breakpoints.

* gdbtk/library/srctextwin.itb (SrcTextWin::do_bp): always define remove_type.
  Process type "disable".

6 years agoIntroduce watchpoints.
Patrick Monnerat [Sun, 24 Jun 2018 15:00:35 +0000 (17:00 +0200)]
Introduce watchpoints.

New watchpoint events, a watchpoint window (double-click shows the
expression in the watch window), menu entries and icons to open watchpoint
window and add a watchpoint for a variable.

* gdbtk/generic/gdbtk-bp.c (have_masked_watchpoints): new local procedure.
  (gdb_get_watchpoint_list): new tcl procedure.
  (gdb_get_watchpoint_info): new tcl procedure.
  (gdb_have_masked_watchpoints): new tcl procedure.
  (breakpoint_notify): handle watchpoints.
* gdbtk/library/ehandler.ith (GDBEventHandler::watchpoint): new method.
* gdbtk/library/gdbevent.ith (WatchpointEvent): new class.
* gdbtk/library/gdbevent.itb (WatchpointEvent::get): new method.
  (WatchpointEvent::_init): new method.
* gdbtk/library/interface.tcl (gdbtk_tcl_watchpoint): new procedure.
* gdbtk/library/pointwin.it[hb] (PointWin::watchpoint): new method.
* gdbtk/library/images/wp.gif: new icon image
* gdbtk/library/images2/wp.gif: new icon image
* gdbtk/library/prefs.tcl (pref_set_defaults): define watchpoints preferences.
* gdbtk/library/session.tcl (_serialize_bps): serialize watchpoints too.
* gdbtk/library/srcbar.itcl (SrcBar::create_view_menu): new Watchpoints entry.
  (SrcBar::create_window_buttons): new watchpoints button.
  (SrcBar::_load_images): load watchpoints icon image.
* gdbtk/library/srctextwin.it[hb] (SrcTextWin::config_win): bind watchpoints
  shortcut.
  (SrcTextWin::watchpoint): new method.
  (SrcTextWin::do_source_popup): add menu entry to set a watchpoint on variable.
  (SrcTextWin::do_key): handle watchpoint key binding.
* gdbtk/library/wpwin.it[hb] (WpWin) new class.
  (WpWin::constructor): new.
  (WpWin::watch_type): new variable.
  (WpWin::watch_entry): new variable.
  (WpWin::global_menu): new overloaded method.
  (WpWin::local_menu): new overloaded method.
  (WpWin::update_local_menu): new overloaded method.
  (WpWin::header): new overloaded method.
  (WpWin::change): new overloaded method.
  (WpWin::add): new overloaded method.
  (WpWin::store): new method.
  (WpWin::watchpoint): new overloaded method.
  (WpWin::toggle_threads): new method.
  (WpWin::set_type): new method.
  (WpWin::goto): new overloaded method.
  (WpWin::delete_point): new overloaded method.
  (WpWin::get_point_list): new overloaded method.

6 years agoFix error occurring upon watch window closing.
Patrick Monnerat [Sun, 24 Jun 2018 14:14:06 +0000 (16:14 +0200)]
Fix error occurring upon watch window closing.

Since some idle script can be pending for a VarTree, let tcl destroy it
when possible.

* gdbtk/library/watch.tcl (WatchTree::destructor): only delete variables
  and clear root list; do not act on parent VarTree.
  (WatchWin::destructor): do not explicitly delete tree, just unreference it.

6 years agoRestructure breakpoint/tracepoint window code.
Patrick Monnerat [Sun, 24 Jun 2018 12:18:45 +0000 (14:18 +0200)]
Restructure breakpoint/tracepoint window code.

BpWin and TpWin classes are now subclasses of a new PointWin class.
PointWin implements the window layout and its subclasses only provide
specific content-related code. See gdbtk/library/pointwin.ith for more
details.

Condition, ignore count and hits count columns are also added.

* gdbtk/library/pointwin.ith (PointWin): new class.
  (PointWin::PointKind): new variable.
  (PointWin::MenuBar): new variable.
  (PointWin::Menu): new variable.
  (PointWin::columns): new variable.
  (PointWin::twin): new variable.
  (PointWin::selected): new variable.
  (PointWin::next_row): new variable.
  (PointWin::bg1): new variable.
  (PointWin::index_to_num): new variable.
  (PointWin::enabled): new variable.
  (PointWin::hidden): new variable.
* gdbtk/library/pointwin.itb (PointWin::constructor): new method.
  (PointWin::create_event): new method.
  (PointWin)::select): new method.
  (PointWin::enable_disable): new method.
  (PointWin::remove): new method.
  (PointWin::delete_point): new method.
  (PointWin::breakpoint): new method.
  (PointWin::tracepoint): new method.
  (PointWin::forall): new method.
  (PointWin::hide_column): new method.
  (PointWin::show_column): new method.
  (PointWin::change): new method.
  (PointWin::add): new method.
  (PointWin::modify): new method.
  (PointWin::restore): new method.
  (PointWin::_select_and_popup): new method.
  (PointWin::basename): new method.
  (PointWin::header): new method.
  (PointWin::global_menu): new method.
  (PointWin::local_menu): new method.
  (PointWin::update_local_menu): new method.
  (PointWin::goto): new method.
  (PointWin::store_details): new method.
* gdbtk/library/bpwin.it[hb] (BpWin): subclass of PointWin.
  (BpWin::tracepoints): removed.
  (BpWin::twin): removed.
  (BpWin::next_row): removed.
  (BpWin::index_to_bpnum): removed.
  (BpWin::Index_to_bptype): renamed BpWin::disposition.
  (BpWin::selected): removed.
  (BpWin::mbar): removed.
  (BpWin::bg1): removed.
  (BpWin::Menu): removed.
  (BpWin::show_threads): removed.
  (BpWin::constructor): moved to bpwin.ith.
  (BpWin::destructor): removed.
  (BpWin::build_win): removed.
  (BpWin::bp_add): renamed BpWin::add. Uses parent method.
  (BpWin::bp_store): renamed BpWin::store.
  (BpWin::bp_restore): removed.
  (BpWin::bp_select): removed.
  (BpWin:: _select_and_popup): removed.
  (BpWin::bp_modify): removed.
  (BpWin::bp_able): renamed BpWin::enable_disable. Uses parent method.
  (BpWin::bp_remove): removed.
  (BpWin::bp_type): renamed BpWin::set_type.
  (BpWin::bp_delete): removed.
  (BpWin::tracepoint): removed.
  (BpWin::bp_all): renamed BpWin::forall. Uses parent method.
  (BpWin::get_actions): removed.
  (BpWin::toggle_threads): Use parent methods hide_column/show_column.
  (BpWin::reconfig): removed.
  (BpWin::goto_bp): renamed BpWin::goto.
  (BpWin::global_menu): new overloaded method.
  (BpWin::local_menu): new overloaded method.
  (BpWin::update_local_menu): new overloaded method.
  (BpWin::header): new overloaded method.
  (BpWin::change): new overloaded method.
  (BpWin::get_point_list): new overloaded method.
* gdbtk/library/tpwin.itcl: deleted.
* gdbtk/library/tpwin.it[hb] (TpWin): subclass of PointWin.
  (TpWin::constructor): uses parent method.
  (TpWin::local_menu): new overloaded method.
  (TpWin::update_local_menu): new overloaded method.
  (TpWin::header): new overloaded method.
  (TpWin::change): new overloaded method.
  (TpWin::add): new overloaded method.
  (TpWin::store): new method.
  (TpWin::forall): new overloaded method.
  (TpWin::enable_disable): new overloaded method.
  (TpWin::remove): new overloaded method.
  (TpWin::tracepoint): new overloaded method.
  (TpWin::get_actions): new method.
  (TpWin::goto): new overloaded method.
  (TpWin::get_point_list): new overloaded method.

6 years agoRemove redundant method body.
Patrick Monnerat [Sun, 24 Jun 2018 12:00:41 +0000 (14:00 +0200)]
Remove redundant method body.

* gdbtk/library/gdbevent.itb (TracepointEvent::get): remove 2nd body occurrence.

6 years agoBreakpoint events do no include other point events anymore.
Patrick Monnerat [Sun, 24 Jun 2018 10:14:47 +0000 (12:14 +0200)]
Breakpoint events do no include other point events anymore.

* gdbtk/generic/gdbtk-bp.c (get_point_list): new function.
  (gdb_get_breakpoint_info): do not return user_specification.
  (gdb_get_breakpoint_list): use get_point_list.
  (breakpoint_notify): suppress get_tracepoint call since it should
  always fail if get_breakpoint does.
  Dispatch by point type to check it and build tcl command.
  (gdb_get_tracepoint_info): return condition.
  (gdb_get_tracepoint_list): use get_point_list.
* gdbtk/library/bpwin.itb (BpWin::bp_store): do not handle user_spec.
  (BpWin::bp_type): likewise.
  (BpWin::get_actions): adjust to gdb_get_tracepoint_info additional list value.
* gdbtk/library/gdbevent.ith, gdbtk/library/gdbevent.itb:
  (BreakpointEvent): no more user_specification.
  (TracepointEvent): implement condition.
* gdbtk/library/session.tcl (Session::_serialize_bps): handle breakpoints
  only and drop user_specification.
* gdbtk/library/srctextwin.itb (SrcTextWin::showBPBalloon): drop
  user_specification.
  (SrcTextWin::showTPBalloon): lassign tracepoint condition.
* gdbtk/library/tracedlg.tcl (TraceDlg::build_win): comment new
  get_get_tracepoint_info condition list item.
* gdbtk/library/util.tcl (bp_exists): drop user_specification.

6 years agoWatch: Automatic gdb variable clean-up.
Patrick Monnerat [Sun, 24 Jun 2018 09:14:34 +0000 (11:14 +0200)]
Watch: Automatic gdb variable clean-up.

Also supports specifying the frame context for an expression, external
selection and checking if a variable is watched.

The overall is handled by a new WatchTree subclass of VarTree.

* gdbtk/library/vartree.ith (VarTree::rootlist): protected.
  (VarTree::setselection): public.
* gdbtk/library/watch.tcl (WatchTree): new class.
  (WatchTree::add): new overloaded method.
  (WatchTree::remove): new overloaded method.
  (WatchTree::in_tree): new method.
  (WatchWin::no_inferior): Delegate variable removal to tree methods.
  (WatchWin::build_win): tree is a WatchTree.
  (WatchWin::destructor): explicitly delete tree.
  (WatchWin::remove): delegate removal to tree.
  parameter.
  (WatchWin::select): new method.
  (WatchWin::watched): new method.
  (WatchWin::add): delegate addition to tree. Supports an optional frame
  (WatchWin::Watched): removed.

6 years agoAdd lmap command for tcl pre 8.6 versions.
Patrick Monnerat [Sun, 24 Jun 2018 08:59:37 +0000 (10:59 +0200)]
Add lmap command for tcl pre 8.6 versions.

* libgui/library/list.tcl (lmap): new procedure.

6 years agoUpgrade submodule, sync patches.
Patrick Monnerat [Fri, 22 Jun 2018 09:00:14 +0000 (11:00 +0200)]
Upgrade submodule, sync patches.

6 years agoUpgrade submodule, sync patch.
Patrick Monnerat [Tue, 19 Jun 2018 10:35:02 +0000 (12:35 +0200)]
Upgrade submodule, sync patch.

6 years agoSync bptypes string table with enum bptype.
Patrick Monnerat [Tue, 19 Jun 2018 09:58:47 +0000 (11:58 +0200)]
Sync bptypes string table with enum bptype.

* gdbtk/generic/gdbtk-bp.c (bptypes): Synced to match current enum definitions.

6 years agoUpgrade submodule, sync code.
Patrick Monnerat [Tue, 12 Jun 2018 15:00:58 +0000 (17:00 +0200)]
Upgrade submodule, sync code.

* gdbtk/generic/gdbtk-register.c (gdbtk_reg_buffer::changed_p): variable
  regstatus is now of type register_status.

6 years agoReplace most dynamic allocations by STL objects.
Patrick Monnerat [Tue, 12 Jun 2018 14:24:07 +0000 (16:24 +0200)]
Replace most dynamic allocations by STL objects.

This saves the need to explicitly deallocate storage when no longer used.

* gdbtk/generic/gdbtk-bp.c (breakpoint_notify): buf is now an std::string.
  (tracepoint_exists): file is now an std::string. Catch allocation errors.
* gdbtk/generic/gdbtk-cmds.c (listfiles_info): keep files in a std::vector.
  pathname is now a std::string. New method addfile ().
  (do_listfiles): Use updated listfiles_info structure.
  (gdb_listfiles): Variables files, file_size; numfiles and len deleted.
  Use updated listfiles_info structure. Use std::sort rather than qsort.
  (comp_files): deleted.
  (gdb_search): files is now a std::vector. Catch allocation errors.
  (gdbtk_load_asm): buffer is now a std::string.
  (gdb_update_mem): mbuf is now a std::vector.
  (gdbtk_set_result): buf is now a std::string.
* gdbtk/generic/gdbtk-register.c (gdbtk_reg_buffer): m_format and m_types are
  now of type std::vector. Destructor deleted.
  (get_register_types): buff deleted.
* gdbtk/generic/gdbtk.c (gdbtk_init): variable s deleted. Use string_printf
  instad of xstrprintf.
  (tk_command): result is now a std::string. Remove unneeded cleanup chain
  handling.
  (view_command): script is now a std::string. Remove unneeded cleanup chain
  handling.

6 years agoUpgrade submodule, sync code.
Patrick Monnerat [Fri, 8 Jun 2018 09:38:50 +0000 (11:38 +0200)]
Upgrade submodule, sync code.

* gdbtk/generic/gdbtk-cmds.c
  (gdb_entry_point): target_stack --> current_top_target().
  (gdb_update_mem): likewise.
* gdbtk/generic/gdbtk.c (gdbtk_start_timer): likewise.

6 years agoUpgrade submodule.
Patrick Monnerat [Thu, 31 May 2018 22:50:33 +0000 (00:50 +0200)]
Upgrade submodule.

6 years agoREADME: suggest disabling isl library in configure example.
Patrick Monnerat [Fri, 25 May 2018 13:30:54 +0000 (15:30 +0200)]
README: suggest disabling isl library in configure example.

6 years agoUpgrade submodule.
Patrick Monnerat [Fri, 25 May 2018 13:29:32 +0000 (15:29 +0200)]
Upgrade submodule.

6 years agoconfigure: use "--add-missing" on automake invocations.
Patrick Monnerat [Fri, 25 May 2018 13:21:00 +0000 (15:21 +0200)]
configure: use "--add-missing" on automake invocations.

This allows newer versions of automake to create files that were not
implemented in automake version use by binutils/gdb.

6 years agoUpgrade submodule, sync patch.
Patrick Monnerat [Fri, 18 May 2018 00:28:51 +0000 (02:28 +0200)]
Upgrade submodule, sync patch.

6 years agoBug fix: the flattened current_target is gone.
Patrick Monnerat [Tue, 15 May 2018 01:59:15 +0000 (03:59 +0200)]
Bug fix: the flattened current_target is gone.

Thus do not use beneath member to access target memory.

* gdbtk/generic/gdbtk-cmds.c (gdb_update_mem): read memory from target_stack.

6 years agoUpgrade submodule, sync code.
Patrick Monnerat [Thu, 10 May 2018 10:59:27 +0000 (12:59 +0200)]
Upgrade submodule, sync code.

* gdbtk/generic/gdbtk-bp.c (get_breakpoint_commands): use body_list_0.get()  and
  body_list_1.get() instead of body_list[0] and body_list[1].
  body_count does not exist anymore: check instead body_list_1 being null.
  (gdb_actions_command): replace type command_line_up by counted_command_line.
  Pass a lambda function to read_command_lines_1 instead of removed
  check_tracepoint_command function.
  (gdb_get_action_list): use body_list_0 instead of body_list[0].

6 years agoUpgrade submodule, sync patch and code.
Patrick Monnerat [Fri, 4 May 2018 14:50:54 +0000 (16:50 +0200)]
Upgrade submodule, sync patch and code.

* gdbtk/generic/gdbtk-cmds.c (gdb_clear_file): use exec_close () instead of
  exec_file_clear ().
  (gdb_stop): do not check to_stop in non null, since this is now handled by
  virtual methods.
  (gdb_entry_point): use *target_stack instead of current_target.
  (gdb_update_mem): likewise.
* gdbtk/generic/gdbtk.c (gdb_interactive): use *target_stack instead of
  current_target.
  (target_is_native): use method shortname () instead of member to_shortname.

6 years agoUpgrade submodule, sync code.
Patrick Monnerat [Mon, 30 Apr 2018 00:38:01 +0000 (02:38 +0200)]
Upgrade submodule, sync code.

* gdbtk/generic/gdbtk-hooks.c (gdbtk_file::read): declare as virtual override.
 (gdbtk_file::write): likewise.

6 years agoUpgrade submodule.
Patrick Monnerat [Sat, 21 Apr 2018 00:41:21 +0000 (02:41 +0200)]
Upgrade submodule.

6 years agoUpgrade submodule, sync patch.
Patrick Monnerat [Mon, 16 Apr 2018 22:39:23 +0000 (00:39 +0200)]
Upgrade submodule, sync patch.

6 years agoUpgrade submodule, adapt gdbtk code.
Patrick Monnerat [Sat, 7 Apr 2018 17:19:21 +0000 (19:19 +0200)]
Upgrade submodule, adapt gdbtk code.

* gdbtk/generic/gdbtk-varobj.c (variable_print): variable->value is now
  a value_ref_ptr, thus call get() method to obtain the struct value *.

6 years agoUpgrade submodule.
Patrick Monnerat [Fri, 30 Mar 2018 17:54:26 +0000 (19:54 +0200)]
Upgrade submodule.

6 years agoSimplify gdb patches.
Patrick Monnerat [Fri, 30 Mar 2018 17:43:35 +0000 (19:43 +0200)]
Simplify gdb patches.

Use C++ default parameter values for updated gdb functions to minimize
gdb code change.

* patches/binutils-gdb/006-add_file_handler_with_mode.patch: deleted.
* patches/binutils-gdb/006-add_file_handler_event_mask.patch: new.
* gdbtk/generic/gdbtk.c (gdbtk_notifier_create_file_handler): use
  add_file_handler instead of (deleted) add_file_handler_with_mode.

6 years agoUpgrade submodule, sync patch.
Patrick Monnerat [Thu, 29 Mar 2018 03:13:36 +0000 (05:13 +0200)]
Upgrade submodule, sync patch.

6 years agoUpgate submodule, sync patch and code accordingly.
Patrick Monnerat [Fri, 23 Mar 2018 02:37:40 +0000 (03:37 +0100)]
Upgate submodule, sync patch and code accordingly.

Gdb replaced the C observers by C++ objects. Adapt insight code to these.

* gdbtk/generic/gdbtk-bp.c: observer.h not used. Remove inclusion.
* gdbtk/generic/gdbtk-hooks.c: include observable.h.
  (gdbtk_add_hooks): use C++ observers.

6 years agoUpgrade submodule, sync patch.
Patrick Monnerat [Fri, 16 Mar 2018 13:19:08 +0000 (14:19 +0100)]
Upgrade submodule, sync patch.

6 years agogdbtk-register: use a gdb reg_buffer subclass for register storage
Patrick Monnerat [Fri, 16 Mar 2018 13:10:59 +0000 (14:10 +0100)]
gdbtk-register: use a gdb reg_buffer subclass for register storage

gdbtk_reg_buffer class extends reg_buffer to handle register change
detection and hold type/format storage.

* gdbtk/generic/gdbtk-register.c (gdbtk_reg_buffer): new subclass.
  (old_regs, old_regs_count, regformat, regtype): replaced by a pointer to a
  gdbtk_reg_buffer instance (registers).
  (get_register): Use class instance.
  (register_changed_p): Check register change using class method.
  (setup_architecture_data): Allocate/free class instance.
  (gdb_regformat): Use class instance.

6 years agoUpgrade submodule.
Patrick Monnerat [Wed, 7 Mar 2018 17:01:27 +0000 (18:01 +0100)]
Upgrade submodule.

6 years agoUpgrade submodule.
Patrick Monnerat [Mon, 5 Mar 2018 03:37:05 +0000 (04:37 +0100)]
Upgrade submodule.

6 years agoPreferences: use global variable name prefix for PREFS_state where needed.
Patrick Monnerat [Mon, 5 Mar 2018 03:27:15 +0000 (04:27 +0100)]
Preferences: use global variable name prefix for PREFS_state where needed.

* libgui/library/prefs.tcl (PREFS_cmd_varname): return global name.
  (PREFS_cmd_add_hook): Use global name.
  (PREFS_cmd_remove_hook): Use global name.

6 years agoChange set/show remotebaud commands to set/show serial baud.
Patrick Monnerat [Mon, 5 Mar 2018 02:46:29 +0000 (03:46 +0100)]
Change set/show remotebaud commands to set/show serial baud.

The "remotebaud" subcommands have been removed from gdb and replaced by
"serial baud".

* gdbtk/library/interface.tcl (proc_set_baud): Use "set serial baud".
* gdbtk/library/targetselection.itb (TargetSelection::build_win): Use
  "show serial baud".
  (TargetSelection::change_baud): Use "set serial baud" and "show serial baud".
  (TargetSelection::cancel): Use "set serial baud".

6 years agoRework and simplify tcl notifier.
Patrick Monnerat [Sun, 4 Mar 2018 15:31:35 +0000 (16:31 +0100)]
Rework and simplify tcl notifier.

Replaces gdb_do_one_event expration parameter by a millisecond timeout
parameter.

Ignore notifier timer: tcl event rescheduling is handled explicitly.
Use thread storage for notifier state.

* gdbtk/generic/gdbtk-hooks.c (gdbtk_call_command): call gdb_do_one_event
  with an infinite timeout.
* gdbtk/generic/gdbtk.c: gdbtk_notifier_data state storage no longer static.
  New notifier state structure type gdbtk_notifier_state.
  (notifier_state): new procedure to get notifier state storage pointer.
  (gdbtk_notifier_defer): new procedure to defer tcl redispatching.
  (gdbtk_notifier_reschedule_tcl): use gdbtk_notifier_defer.
  (gdbtk_notifier_schedule_proc): use gdbtk_notifier_defer. Use bit flags.
  (gdbtk_notifier_get_file_data): use notifier state thread storage.
  (gdbtk_notifier_timeout): deleted.
  (gdbtk_notifier_set_timer): do nothing.
  (gdbtk_notifier_wait_for_event): call gdb_do_one_event with a timeout.
  (gdbtk_notifier_create_file_handler): use notifier state thread storage.
  (gdbtk_notifier_initialize): Initialize scheduler async event.
  (gdbtk_notifier_finalize): Release notifier state sub storage and clear
  state.
  (gdbtk_notifier_service_mode_hook): use notifier state thread storage.
  (gdbtk_install_notifier): Remove tcl scheduler async event initialisation:
  this is now done in gdbtk_notifier_initialize.
  (gdbtk_uninstall_notifier): Remove notifier state cleanup: now done in
  gdbtk_notifier_finalize.
* patches/binutils-gdb/005-gdb_do_one_event-add-an-expiration-parameter.patch:
  deleted.
* patches/binutils-gdb/005-gdb_do_one_event-add-timeout-parameter.patch:
  new patch.
* patches/binutils-gdb/006-add_file_handler_with_mode.patch: rebased.

6 years agoAdd gdb function add_file_handler_with_mode.
Patrick Monnerat [Fri, 2 Mar 2018 16:39:59 +0000 (17:39 +0100)]
Add gdb function add_file_handler_with_mode.

This merges patches 006-add_file_handler-implement-a-mask-parameter.patch and
007-Avoid-creating-a-file-handler-for-a-negative-fd.patch into a simplified
006-add_file_handler_with_mode.patch implementing this new function.

* gdbtk/generic/gdbtk.c (gdbtk_notifier_create_file_handler): call
  add_file_handler_with_mode instead of add_file_handler.

6 years agoUpgrade submodule, sync patch.
Patrick Monnerat [Fri, 2 Mar 2018 13:36:11 +0000 (14:36 +0100)]
Upgrade submodule, sync patch.

6 years agoUpgrade submodule.
Patrick Monnerat [Fri, 23 Feb 2018 14:52:51 +0000 (15:52 +0100)]
Upgrade submodule.

6 years agoUpgrade submodule, sync patch.
Patrick Monnerat [Fri, 16 Feb 2018 14:28:13 +0000 (15:28 +0100)]
Upgrade submodule, sync patch.

6 years agoUpgrade submodule, sync patch.
Patrick Monnerat [Fri, 9 Feb 2018 14:07:50 +0000 (15:07 +0100)]
Upgrade submodule, sync patch.

6 years agoUpgrade submodule, sync patches.
Patrick Monnerat [Fri, 2 Feb 2018 12:32:11 +0000 (13:32 +0100)]
Upgrade submodule, sync patches.

6 years agoUpgrade submodule, sync patch.
Patrick Monnerat [Fri, 26 Jan 2018 12:51:11 +0000 (13:51 +0100)]
Upgrade submodule, sync patch.

6 years agoUpgrade submodule, sync patches.
Patrick Monnerat [Thu, 18 Jan 2018 18:55:19 +0000 (19:55 +0100)]
Upgrade submodule, sync patches.

6 years agoUpgrade submodule, sync patches.
Patrick Monnerat [Fri, 12 Jan 2018 02:23:33 +0000 (03:23 +0100)]
Upgrade submodule, sync patches.

6 years agoUpgrade submodule.
Patrick Monnerat [Thu, 4 Jan 2018 16:43:28 +0000 (17:43 +0100)]
Upgrade submodule.

6 years agoUpgrade submodule.
Patrick Monnerat [Fri, 22 Dec 2017 11:31:33 +0000 (12:31 +0100)]
Upgrade submodule.

6 years agoUpgrade submodule, sync patch.
Patrick Monnerat [Fri, 15 Dec 2017 15:22:48 +0000 (16:22 +0100)]
Upgrade submodule, sync patch.

6 years agoUpgrade submodule, sync patch.
Patrick Monnerat [Sat, 9 Dec 2017 00:10:27 +0000 (01:10 +0100)]
Upgrade submodule, sync patch.

6 years agoUpgrade submodule, sync patches.
Patrick Monnerat [Fri, 1 Dec 2017 02:46:47 +0000 (03:46 +0100)]
Upgrade submodule, sync patches.

6 years agoUpgrade submodule, sync patch and code, reorder functions, drop value_ptr.
Patrick Monnerat [Sat, 25 Nov 2017 00:25:53 +0000 (01:25 +0100)]
Upgrade submodule, sync patch and code, reorder functions, drop value_ptr.

* gdbtk/generic/gdbtk-cmds.c (gdb_eval): drop value_ptr type, remove unused
  variable dummy.
  (gdb_update_mem); remove unused variable dummy.
* gdbtk/generic/gdbtk-varobj.c (variable_delete_tcl): children field is
  now a std::vector.
  (variable_children): varobj_list_children() now returns a std::vector&.
  (variable_update): use a std::vector& as GDB_varobj_update() argument.
* gdbtk/generic/gdbtk-wrapper.[ch]: drop value_ptr_type, reorder functions
  alphabetically, remove redundant prototypes.
  (GDB_varobj_update): argument `changes' is now a std::vector& to accomodate
  varobj_update() new result type.

6 years agoUpgrade submodule. Sync patches.
Patrick Monnerat [Fri, 17 Nov 2017 19:50:18 +0000 (20:50 +0100)]
Upgrade submodule. Sync patches.

6 years agoUpgrade submodule, sync patches and code.
Patrick Monnerat [Sat, 11 Nov 2017 02:04:38 +0000 (03:04 +0100)]
Upgrade submodule, sync patches and code.

* gdbtk/generic/gdbtk-hooks.c (gdbtk_call_command): constify arg.
* gdbtk/generic/gdbtk-interp.c (hack_disable_interpreter_exec): constify args.
  (gdbtk_do_const_cfunc): new function.
  (gdbtk_interp::init): replace set_cmd_cfunc call (no longer public) by
  assignment statements.
* gdbtk/generic/gdbtk.c (tk_command): constify cmd.
  (view_command): constify args.

7 years agoUpgrade submodule.
Patrick Monnerat [Fri, 3 Nov 2017 17:57:41 +0000 (18:57 +0100)]
Upgrade submodule.

7 years agoUpgrade submodule.
Patrick Monnerat [Sun, 29 Oct 2017 15:48:54 +0000 (16:48 +0100)]
Upgrade submodule.

7 years agoUpgrade submodule, sync patches.
Patrick Monnerat [Sat, 21 Oct 2017 16:38:19 +0000 (17:38 +0100)]
Upgrade submodule, sync patches.

7 years agoUpgrade submodule, update patch and code accordingly.
Patrick Monnerat [Sat, 14 Oct 2017 17:25:45 +0000 (18:25 +0100)]
Upgrade submodule, update patch and code accordingly.

Function catch_errors() does not exist anymore in gdb. Replace uses by
TRY/CATCH blocks.

* gdbtk/generic/gdbtk-cmds.c (wrapped_call): remove.
  (gdbtk_call_wrapper): Use TRY/CATCH instead of catch_errors().
  (gdb_loadfile): Likewise.
* gdbtk/generic/gdbtk-cmds.h (struct wrapped_call_args): no longer used: remove.
* gdbtk/generic/gdbtk-wrapper.c (GDB_parse_exp_1): was commented out: remove.
  (call_wrapped_function): no longer used: remove.
  (GDB_find_relative_frame): likewise.
  (GDB_parse_exp_1): remove.
  (wrap_type_print): remove.
  (wrap_evaluate_expression): remove.
  (wrap_value_fetch_lazy): remove.
  (wrap_value_equal): remove.
  (wrap_parse_exp_1): remove.
  (wrap_evaluate_type): remove.
  (wrap_block_for_pc): remove.
  (wrap_block_innermost_frame): remove.
  (wrap_reinit_frame_cache): remove.
  (wrap_value_ind): remove.
  (wrap_value_slice): remove.
  (wrap_value_coerce_array): remove.
  (wrap_value_struct_elt): remove.
  (wrap_value_cast): remove.
  (wrap_get_frame_block): remove.
  (wrap_get_prev_frame): remove.
  (wrap_get_next_frame): remove.
  (wrap_find_relative_frame): remove.
  (wrap_get_current_frame): remove.
  (wrap_varobj_update): remove.
  (GDBTK_CATCH_ERRORS): new macro implementing wrappers.
  (GDB_type_print): wrap using GDBTK_CATCH_ERRORS() instead of catch_errors().
  (GDB_value_fetch_lazy): likewise.
  (GDB_evaluate_expression): likewise.
  (GDB_value_equal): likewise.
  (GDB_evaluate_type): likewise.
  (GDB_block_for_pc): likewise.
  (GDB_block_innermost_frame): likewise.
  (GDB_reinit_frame_cache): likewise.
  (GDB_value_ind): likewise.
  (GDB_value_slice): likewise.
  (GDB_value_coerce_array): likewise.
  (GDB_value_struct_elt): likewise.
  (GDB_value_cast): likewise.
  (GDB_get_frame_block): likewise.
  (GDB_get_prev_frame): likewise.
  (GDB_get_next_frame): likewise.
  (GDB_find_relative_frame): likewise.
  (GDB_get_current_frame): likewise.
  (GDB_varobj_update): likewise.
  (GDB_find_relative_frame): likewise.
* gdbtk/generic/gdbtk-wrapper.h (struct gdb_wrapper_arguments): no longer used,
  remove.
  (GDB_parse_exp_1): remove.

7 years agoUpgrade submodule, update code accordingly.
Patrick Monnerat [Tue, 10 Oct 2017 14:23:44 +0000 (15:23 +0100)]
Upgrade submodule, update code accordingly.

* gdbtk/generic/gdbtk-cmds.c (gdb_search): search_symbols now returns a
  std::vector. List cleanup not needed anymore.

7 years agoUpgrade submodule, sync patches.
Patrick Monnerat [Sun, 8 Oct 2017 14:07:46 +0000 (15:07 +0100)]
Upgrade submodule, sync patches.

7 years agoUpgrade submodule, sync patches and code.
Patrick Monnerat [Sat, 30 Sep 2017 23:42:48 +0000 (00:42 +0100)]
Upgrade submodule, sync patches and code.

* gdbtk/generic/gdbtk-bp.c (tracepoint_exists): constify argument.
  (gdbtk_set_bp): constify address for string_to_event_location ().
  (gdb_tracepoint_exists_command): constify args.
* gdbtk/generic/gdbtk-cmds.c (gdb_get_line_command): constify args for
  string_to_event_location ().
  (gdb_get_file_command): likewise.
  (gdb_get_function_command): likewise.
* gdbtk/generic/gdbtk-hooks.c (gdbtk_file_changed): constify argument.
* gdbtk/generic/gdbtk-stack.c (gdb_get_vars_command): constify args for
  string_to_event_location ().
* gdbtk/generic/gdbtk-varobj.c (variable_create): retype obj_name to
  std::string. No explicit freeing needed anymore.

7 years agoUpgrade submodule, sync patch.
Patrick Monnerat [Mon, 25 Sep 2017 23:21:23 +0000 (00:21 +0100)]
Upgrade submodule, sync patch.

7 years agoUpgrade submodule.
Patrick Monnerat [Thu, 21 Sep 2017 12:37:09 +0000 (13:37 +0100)]
Upgrade submodule.

7 years agoDelete all gdb breakpoint with a private API
Patrick Monnerat [Thu, 21 Sep 2017 12:28:16 +0000 (13:28 +0100)]
Delete all gdb breakpoint with a private API

* gdbtk/generic/gdbtk-bp.c (gdbtk_delete_all_breakpoints): new function.
* gdbtk/generic/gdbtk-cmds.c (gdb_clear_file): Use
  gdbtk_delete_all_breakpoints() instead of delete_command().

7 years agoUpgrade submodule, sync patches, adjust code to changed ABI.
Patrick Monnerat [Tue, 19 Sep 2017 12:22:34 +0000 (13:22 +0100)]
Upgrade submodule, sync patches, adjust code to changed ABI.

struct symtabs_and_lines --> std::vector<symtab_and_line>

* gdbtk/generic/gdbtk-bp.c (tracepoint_exists): symtabs_and_lines.
* gdbtk/generic/gdbtk-cmds.c (gdb_get_line_command): symtabs_and_lines.
  (gdb_get_file_command): symtabs_and_lines.
  (gdb_get_function_command): symtabs_and_lines.
  (gdb_loc): adjust find_frame_sal() call to updated prototype.
  symtabs_and_lines.
* gdbtk/generic/gdbtk-stack.c (gdb_get_vars_command): symtabs_and_lines.
  (get_frame_name): adjust funname type to updated find_frame_funname()
  prototype.

7 years agoUpgrade submodule.
Patrick Monnerat [Mon, 4 Sep 2017 00:16:04 +0000 (01:16 +0100)]
Upgrade submodule.

7 years agoUpgrade submodule. Sync patch.
Patrick Monnerat [Tue, 29 Aug 2017 10:55:37 +0000 (11:55 +0100)]
Upgrade submodule. Sync patch.

7 years agoUpgrade submodule.
Patrick Monnerat [Fri, 11 Aug 2017 10:41:10 +0000 (11:41 +0100)]
Upgrade submodule.

7 years agoUpgrade submodule. Sync patches.
Patrick Monnerat [Fri, 4 Aug 2017 09:33:41 +0000 (10:33 +0100)]
Upgrade submodule. Sync patches.

7 years agoUpgrade submodule.
Patrick Monnerat [Sat, 29 Jul 2017 00:06:30 +0000 (01:06 +0100)]
Upgrade submodule.

7 years agoUpgrade submodule.
Patrick Monnerat [Thu, 20 Jul 2017 23:41:38 +0000 (00:41 +0100)]
Upgrade submodule.

7 years agoUpgrade submodule.
Patrick Monnerat [Tue, 11 Jul 2017 12:46:52 +0000 (13:46 +0100)]
Upgrade submodule.

7 years agoUpgrade submodule.
Patrick Monnerat [Fri, 30 Jun 2017 11:27:25 +0000 (12:27 +0100)]
Upgrade submodule.

7 years agoUpgrade submodule. Sync patch.
Patrick Monnerat [Fri, 23 Jun 2017 10:07:58 +0000 (11:07 +0100)]
Upgrade submodule. Sync patch.

7 years agoUpgrade submodule, sync patches.
Patrick Monnerat [Sun, 11 Jun 2017 12:51:51 +0000 (13:51 +0100)]
Upgrade submodule, sync patches.

7 years agoUpgrade submodule, sync patch and code accordingly.
Patrick Monnerat [Sat, 3 Jun 2017 10:06:16 +0000 (11:06 +0100)]
Upgrade submodule, sync patch and code accordingly.

Subclasses of struct breakpoint have been C++ified: no base class pointer in
struct tracepoint anymore.

* gdbtk/generic/gdbtk-bp.c (breakpoint_notify): remove <base> use.

7 years agoUpgrade submodule.
Patrick Monnerat [Thu, 25 May 2017 01:05:22 +0000 (02:05 +0100)]
Upgrade submodule.

7 years agoUpgrade submodule.
Patrick Monnerat [Sat, 13 May 2017 00:24:06 +0000 (01:24 +0100)]
Upgrade submodule.

7 years agoUpgrade submodule. Sync patch.
Patrick Monnerat [Wed, 3 May 2017 10:09:28 +0000 (11:09 +0100)]
Upgrade submodule. Sync patch.

7 years agoUpgrade submodule.
Patrick Monnerat [Sun, 30 Apr 2017 14:30:08 +0000 (15:30 +0100)]
Upgrade submodule.

This page took 0.062436 seconds and 5 git commands to generate.