Jonathan Lebon [Fri, 16 Jan 2015 18:29:40 +0000 (13:29 -0500)]
PR17860: match foreach logic in tmpcounter and unparser
This patch fixes PR17860 by ensuring that tmpvars are declared in
c_tmpcounter::visit_foreach_loop() in the same order as they are used in
c_unparser::visit_foreach_loop().
Martin Cermak [Wed, 21 Jan 2015 17:29:48 +0000 (18:29 +0100)]
PR17864: Fix alias_tapset.exp regression
* Take only interesting parts of the stap output into account
so that expect's match_max doesn't get exceeded.
* Adapt the testcase to commit befbf100 which modifies
syscall.read on s390x
If DW_AT_comp_dir is the same as s.kernel_build_tree, then it's not a
useful path for s.kernel_source_tree. By ignoring this case, we allow
the next block to check whether the source symlink is useful instead.
Martin Cermak [Mon, 12 Jan 2015 16:37:18 +0000 (17:37 +0100)]
PR17714: Work with valid pointers, correctly test for unimplemented syscalls.
* tapset/linux/syscalls.stp: Work with valid pointers in s390 compat task.
* testsuite/systemtap.syscall/poll.c: epoll_pwait() unimplemented on RHEL5 x86_64.
Jonathan Lebon [Fri, 19 Dec 2014 18:53:09 +0000 (13:53 -0500)]
don't support TRACE_SYSTEM for --compatible <= 2.6
When in compatibility mode, we want the probe name to remain the same so
that e.g. pn() still only displays the tracepoint name (without the
system prefix).
Jonathan Lebon [Fri, 26 Sep 2014 22:00:23 +0000 (18:00 -0400)]
tracepoint_builder: add section to hold TRACE_SYSTEM
Upon compiling the various headers, we also suck up the current value of
TRACE_SYSTEM into a new section called .stap_trace_system.
Unfortunately, we cannot play the same trick we do with the
stapprobe_{function} since TRACE_SYSTEM can be any string value and may
thus contain invalid identifier characters.
Josh Stone [Thu, 8 Jan 2015 22:47:20 +0000 (14:47 -0800)]
Use the kernel source symlink for tracepoints
When the source symlink is different than the build symlink, as for
out-of-tree kernel builds and Debian linux-headers, then we should use
that path as a prefix for finding tracepoint headers.
David Smith [Tue, 6 Jan 2015 21:43:42 +0000 (15:43 -0600)]
Fix PR17807 by updating the vfs tapset.
* tapset/linux/vfs.stp (generic.fop.aio_read): Make optional and fix
__iov_length() call to use VERIFY_WRITE.
(generic.fop.aio_read.return): Make optional.
(generic.fop.read_iter): New probe.
(generic.fop.read_iter.return): Ditto.
(generic.fop.aio_write): Make optional and fix __iov_length() call to
use VERIFY_READ.
(generic.fop.aio_write.return): Make optional.
(generic.fop.write_iter): New probe.
(generic.fop.write_iter.return): Ditto.
* tapset/linux/nfs.stp (nfs.fop.aio_read): Fix __iov_length() call to use
VERIFY_WRITE.
(nfs.fop.read_iter): Ditto.
(nfs.fop.aio_write): Fix __iov_length() call to use VERIFY_READ.
(nfs.fop.write_iter): Ditto.
* testsuite/buildok/vfs-detailed.stp: Add tests for the new probes.
On suggestion from Brendan Gregg, it would be helpful for the examples
list to highlight "best" scripts, out of the over-one-hundred we ship.
To begin, this is approximated by special support for the .meta keyword
"_best", which results in highlighting the marked samples at the top
of the [keyword-]index.html files.
Frank Ch. Eigler [Tue, 30 Dec 2014 15:25:01 +0000 (10:25 -0500)]
PR17743: stap* help/version text should go peacefully to stdout
As per GNU habits, specifically requested help/version strings for
our programs should go to stdout with rc=0 rather than stderr rc=1.
Adjust stap, staprun, stapio, stapdyn code to taste. helpout.exp
test case to confirm.
Jonathan Lebon [Mon, 22 Dec 2014 17:21:40 +0000 (12:21 -0500)]
listing_mode.exp: update for RHEL5
The listing_mode.exp testcase showed multiple failures on RHEL5. This
commit fixes these errors by making perf probe testing conditional on
system support and by adjusting linenos to play nice with RHEL5's GCC.
Frank Ch. Eigler [Mon, 22 Dec 2014 16:59:40 +0000 (11:59 -0500)]
PR17737: tapset-reference html chapters should not get <toc>
The docbook xsl-stylesheets' html output normally includes generated
TOC for incoming <chapter> blocks. Suppress this with a cunning
choice of generate.toc --stringparam for the xmlto. (On F21 at least,
the parameter needs to contain an embedded \ apparently due to layers
of being passed between shell scripts and xml parsers and whatnot.
Sorry.)
David Smith [Tue, 16 Dec 2014 16:58:05 +0000 (10:58 -0600)]
Fix PR17688 by updating the nfs tapset for kernels >= 3.16.
* tapset/linux/nfs.stp (nfs.fop.aio_read): Only use if the kernel version
is less than 3.16. Upstream kernel has switched from aio_{read,write} to
{read_write}_iter, but using the same function names.
(nfs.fop.aio_write): Ditto.
(nfs.fop.read_iter): New probe for kernel versions >= 3.16.
(nfs.fop.write_iter): Ditto.
* testsuite/buildok/nfs-detailed.stp: Added new tests.
William Cohen [Mon, 15 Dec 2014 19:45:40 +0000 (14:45 -0500)]
Improve the output of cycle_thief.stp to include executable name
Jeremy Eder suggested that it would be good to include the executable
name in the output to save people the step of looking up the
executable name of the various PIDs. The change also includes a
header for the output in that section to make it clearer what each
column is.
William Cohen [Mon, 8 Dec 2014 21:25:37 +0000 (16:25 -0500)]
Fix the SDT_V3 operand handling to recognize arm64 style address modes
The arm64 address operands are very similar to 32-bit arm address
operands, but they are not identical. The arm64 versions may lack
white space and the '#' before the offset value. The regular
expression matching has been adjusted to recognized both 32-bit and
64-bit arm versions.
David Smith [Mon, 8 Dec 2014 20:04:19 +0000 (14:04 -0600)]
Fix BZ1171823 by updating the __svc_fh() nfsd tapset function.
* tapset/linux/nfsd.stp: Rewrite __svc_fh() in systemtap script language
instead of embedded-C to get around the disappearance of struct svc_fh's
declaration from a public kernel header file.
William Cohen [Mon, 8 Dec 2014 19:39:25 +0000 (14:39 -0500)]
Allow speculate.exp to use syscall.openat on arm64
On arm64 the syscall.open is deprecated and will never be used. The
arm64 will use syscall.openat instead. The speculate.exp test has
been adjusted accept syscall.openat in the place of syscall.open.
William Cohen [Mon, 8 Dec 2014 17:08:05 +0000 (12:08 -0500)]
Allow pp.exp to use syscall.openat on arm64
On arm64 the syscall.open is deprecated and will never be used. The
arm64 will use syscall.openat instead. The pp.exp test has been
adjusted accept syscall.openat in the place of syscall.open.
William Cohen [Mon, 8 Dec 2014 14:47:41 +0000 (09:47 -0500)]
Corrections to global_var_kernel.stp tests
Newer kernels have moved kernel/time.c to kernel/time/time.c and the
@var() statements need to be less picky where it looks for sys_tz.
Also some machines such as the arm64 use the syscall.openat than
the deprecated syscall.open.
Martin Cermak [Fri, 5 Dec 2014 16:38:50 +0000 (17:38 +0100)]
PR16716 partial fix: Fix types in 'syscall.sched_{{get,set}param,get_priority_{max,min},yield}'
* tapset/linux/aux_syscalls.stp: Fix handling negative args in _sched_policy_str()
* tapset/linux/nd_syscalls2.stp: Fix argstr in sched_get_priority_{max,min}
* tapset/linux/syscalls2.stp: Fix types and argstr in sched_get_priority_{max,min}
and sched_{get,set}param
* testsuite/systemtap.syscall/mknod.c: Use thin wrapper around the syscall()
* testsuite/systemtap.syscall/sched.c: New testcase
William Cohen [Fri, 28 Nov 2014 05:01:50 +0000 (00:01 -0500)]
Allow systemtap.base/warnings.exp to work with newer kernels
Linux kernel commit f9c78b2be2cac2a7a397d489275e7d9f9ae785f2 moved
fs/bio.c to block/bio.c. Adjusted the test to be less picky about the
location of bio.c file.
William Cohen [Fri, 28 Nov 2014 02:53:16 +0000 (21:53 -0500)]
Allow at_var_tracepoint.stp to handle time.c move in newer Linux kernels
Kernel commit 5cee964597260237dd2cabb3ec22bba0da24b25d moved time.c
from kernel/time.c to kernel/time/time.c. The at_var_tracepoint.stp
test was failing because of the changed location of the file. The
test should not over specify the location of the time.c file. This
change should work with both old and new kernels.
William Cohen [Fri, 21 Nov 2014 15:58:16 +0000 (10:58 -0500)]
Split the access of sp from the rest of pt_regs regs[] accesses
The pt_regs struct has regs[0] through regs[30]. The sp is a separate
field and not regs[31] in the regs array. The compiler will fail to
compile modules when the code includes accesses to the sp because of
the warnings. This change splits out sp (and all the other reg)
accesses so this code compiles correctly without warnings. This
issues observed with the systemtap.base/rlimit.exp tests failures.
The rlimit.exp tests now all pass with the patch.
William Cohen [Fri, 21 Nov 2014 15:17:12 +0000 (10:17 -0500)]
Recognize the arm64 registers in SDT_V3 format
The check for the arm64 architecture was missing, so systemtap was not
recognizing the arm64 registers. This addition should allow systemtap
to find the various arguments being passed in by user-space markers.
William Cohen [Fri, 21 Nov 2014 01:04:23 +0000 (20:04 -0500)]
Allow syscall tests to match the arm64 remapped syscalls
The arm64 does not implement a number of deprecated syscalls. The
deprecated syscalls are remapped to more generic syscalls with the
additional arguments set to so the remapped systemcall emulates the
behavior the deprecated syscalls. The syscall tests matching needed
to be adjusted to match these remaped syscalls for inotify_init(),
pipe(), select(), and vfork(). These fixes are applied to the
following tests:
David Smith [Thu, 20 Nov 2014 15:34:08 +0000 (09:34 -0600)]
PR16716 partial fix: Fix types in 'syscall.{semctl,semget,semop,semtimedop}'.
* tapset/linux/syscalls2.stp: Fix types and nesting in syscall.semctl,
syscall.semget, syscall.semop, and syscall.semtimedop.
* tapset/linux/nd_syscalls2.stp: Ditto.
* tapset/linux/aux_syscalls.stp: Add SEMOP, SEMCTL, and SEMTIMEDOP defines
when needed.
* tapset/linux/syscalls.stpm: Add __compat_syscall_gate_negative macro.
* tapset/linux/s390/syscalls.stp: Since syscall.ipc was interferring with
the new syscall.sem* work, go ahead and deprecate syscall.ipc now.
* tapset/linux/s390/nd_syscalls.stp: Ditto.
* testsuite/systemtap.syscall/semctl.c: New testcase.
* testsuite/systemtap.syscall/semget.c: Ditto.
* testsuite/systemtap.syscall/semop.c: Ditto.
* testsuite/buildok/syscalls2-detailed.stp: Add tests for new convenience vars.
* testsuite/buildok/nd_syscalls2-detailed.stp: Ditto.
* testsuite/buildok/syscalls-arch-detailed.stp: Only test s390x
syscall.ipc when needed.
* testsuite/buildok/nd_syscalls-arch-detailed.stp:: Ditto.
William Cohen [Wed, 19 Nov 2014 14:48:49 +0000 (09:48 -0500)]
Add arm64 loader to the whitelist of interpreters
All the systemtap.base/listing_mode.exp tests that probed the library
were failing (pr17622) because the code did not have the arm64 loader
whitelisted. Added the appropriate arm64 loader to the whitelist to
resolve this issue.
William Cohen [Fri, 14 Nov 2014 04:52:44 +0000 (23:52 -0500)]
Correct nodebug mkdirat syscall argstr
The debuginfo mkdirat syscall prints a string for the first argument.
However, the nodebug version just printed the numerical value of the
first arg. Some of the testsuite/systemtap.syscall/nd_syscall.exp
tests were failing because of the difference in output.
William Cohen [Fri, 14 Nov 2014 04:39:27 +0000 (23:39 -0500)]
Improve arm64 syscall/nd_syscall test results
A number of syscalls are remapped on the arm64 to newer, more general syscalls.
The older syscalls are not implemented on arm64. The tests should match those
newer, more general syscalls.
David Smith [Thu, 6 Nov 2014 20:47:36 +0000 (14:47 -0600)]
Fixed BZ1160837 by updating the iostat-scsi.stp example.
* testsuite/systemtap.examples/io/iostat-scsi.stp: Updated for newer
kernels like RHEL7 and rawhide. Probes the "sd_init_command" kernel
function which replaced "sd_prep_fn" in newer kernels. Added whitespace
for more clarity.
William Cohen [Fri, 31 Oct 2014 16:24:55 +0000 (12:24 -0400)]
Estimate the frequency of the arch64 get_cycle()
Unlike 32-bit arm the 64-bit has a working get_cycle() function and
the SystemTap runtime support should make an attempt to estimate the
frequency of get_cycle(). This change will make scripts using time
information on aarch64 produce accurate results.
Frank Ch. Eigler [Thu, 16 Oct 2014 20:25:55 +0000 (16:25 -0400)]
RHBZ1153673: speculatively correct segv in dead_control_remover
It was reported that ::visit_block was occasionally called with
a 0-size input vs[]. That leads to an array overflow, as the
for condition becomes apprx. (i < UINT_MAX).
for (size_t i = 0; i < vs.size() - 1; ++i)
do_something_with (vs[i]);
git://sourceware.org / systemtap.git / log